From 24634dc7b16a0478ae610e94e5cd6519e0ef9dd5 Mon Sep 17 00:00:00 2001 From: Michael Nattfalk Date: Wed, 9 Nov 2016 14:09:56 +0100 Subject: [PATCH 1/2] Fix row-height calculation to accomodate for variable height rows --- src/jquery.scrollTableBody-1.0.0.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/jquery.scrollTableBody-1.0.0.js b/src/jquery.scrollTableBody-1.0.0.js index f5bf274..83eaa1c 100644 --- a/src/jquery.scrollTableBody-1.0.0.js +++ b/src/jquery.scrollTableBody-1.0.0.js @@ -23,8 +23,10 @@ var existingClasses = table.attr('class'); var existingMarginBottom = table.css('margin-bottom'); table.css('margin-bottom', 0); - var rowHeight = table.find('tbody tr:first').outerHeight(); - var tableHeight = rowHeight * options.rowsToDisplay; + var tableHeight = 0; + $.each(rows, function () { + tableHeight += $(this).outerHeight(); + }); var headerTable = $('
'), footerTable = $(''), From acc16fa175851929c18e65aad9dfff7fc5594259 Mon Sep 17 00:00:00 2001 From: Michael Nattfalk Date: Wed, 9 Nov 2016 14:19:43 +0100 Subject: [PATCH 2/2] Added missing row selector --- src/jquery.scrollTableBody-1.0.0.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/jquery.scrollTableBody-1.0.0.js b/src/jquery.scrollTableBody-1.0.0.js index 83eaa1c..cb91210 100644 --- a/src/jquery.scrollTableBody-1.0.0.js +++ b/src/jquery.scrollTableBody-1.0.0.js @@ -23,7 +23,9 @@ var existingClasses = table.attr('class'); var existingMarginBottom = table.css('margin-bottom'); table.css('margin-bottom', 0); + var tableHeight = 0; + var rows = table.find('tbody tr:lt(' + options.rowsToDisplay.toString() + ')'); $.each(rows, function () { tableHeight += $(this).outerHeight(); });