From 92f0c454a97d2d7214c28bf86da5faa16309f8e6 Mon Sep 17 00:00:00 2001 From: Vladimir Morozov Date: Thu, 8 Jan 2026 16:54:29 -0800 Subject: [PATCH] build,tools: fix addon build deadlock on errors --- tools/build_addons.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build_addons.py b/tools/build_addons.py index b8e36078d236cb..e985d6f67a4625 100755 --- a/tools/build_addons.py +++ b/tools/build_addons.py @@ -58,8 +58,8 @@ def node_gyp_rebuild(test_dir): # We buffer the output and print it out once the process is done in order # to avoid interleaved output from multiple builds running at once. - return_code = process.wait() stdout, stderr = process.communicate() + return_code = process.returncode if return_code != 0: print(f'Failed to build addon in {test_dir}:') if stdout: