From 2591d77cc77d7e1a2bc1cf5bcd9c4e15133297fc Mon Sep 17 00:00:00 2001 From: Mihkel Eidast Date: Mon, 2 Feb 2026 22:33:55 +0200 Subject: [PATCH 1/4] chore: build project before playwright test --- package.json | 5 +++-- playwright.config.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 331c391da..a658a4c61 100644 --- a/package.json +++ b/package.json @@ -12,6 +12,7 @@ "scripts": { "build": "nuxt build", "build:lunaria": "node ./lunaria/lunaria.ts", + "build:playwright": "NODE_ENV=test pnpm build", "dev": "nuxt dev", "dev:docs": "pnpm run --filter npmx-docs dev --port=3001", "i18n:check": "node scripts/compare-translations.ts", @@ -28,12 +29,12 @@ "generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear", "test": "vite test", "test:browser": "playwright test", - "test:browser:ui": "playwright test --ui", + "test:browser:ui": "pnpm build:playwright && playwright test --ui", "test:browser:update": "playwright test --update-snapshots", "test:nuxt": "vite test --project nuxt", "test:types": "nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types", "test:unit": "vite test --project unit", - "start:playwright:webserver": "NODE_ENV=test pnpm build && pnpm preview --port 5678" + "start:playwright:webserver": "NODE_ENV=test pnpm preview --port 5678" }, "dependencies": { "@atproto/api": "^0.18.17", diff --git a/playwright.config.ts b/playwright.config.ts index 93440406c..ffad053c6 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -16,7 +16,7 @@ export default defineConfig({ command: 'pnpm start:playwright:webserver', url: baseURL, reuseExistingServer: false, - timeout: 240_000, + timeout: 60_000, }, use: { baseURL, From 61f4c3e48a37236eccfc586f6e059d73b993c16a Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 3 Feb 2026 11:44:39 +0000 Subject: [PATCH 2/4] ci: add build step before playwright test --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c77557dae..27ebc525e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,6 +91,9 @@ jobs: - name: 📦 Install dependencies run: pnpm install + - name: 🏗️ Build project + run: pnpm build:playwrightt + - name: 🖥️ Test project (browser) run: pnpm test:browser From eb0f1e293055ab4016870c702a68a920745be0df Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 3 Feb 2026 11:50:43 +0000 Subject: [PATCH 3/4] fix: keep test:browser behaviour the same + add new test:browser:prebuilt command --- .github/workflows/ci.yml | 4 ++-- package.json | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6806c4596..fadde3c96 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,10 +88,10 @@ jobs: run: pnpm install - name: 🏗️ Build project - run: pnpm build:playwrightt + run: pnpm build:playwright - name: 🖥️ Test project (browser) - run: pnpm test:browser + run: pnpm test:browser:prebuilt a11y: runs-on: ubuntu-latest diff --git a/package.json b/package.json index 52a1164da..281359de3 100644 --- a/package.json +++ b/package.json @@ -28,8 +28,9 @@ "postinstall": "nuxt prepare && simple-git-hooks && pnpm generate:lexicons", "generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear", "test": "vite test", - "test:browser": "playwright test", - "test:browser:ui": "pnpm build:playwright && playwright test --ui", + "test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt", + "test:browser:prebuilt": "playwright test", + "test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui", "test:browser:update": "playwright test --update-snapshots", "test:nuxt": "vite test --project nuxt", "test:types": "nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types", From 2a8e8427ac55e4949ecb53b023d98310d9212c12 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 3 Feb 2026 11:59:30 +0000 Subject: [PATCH 4/4] Apply suggestion from @danielroe --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 281359de3..b76685fb7 100644 --- a/package.json +++ b/package.json @@ -31,7 +31,7 @@ "test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt", "test:browser:prebuilt": "playwright test", "test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui", - "test:browser:update": "playwright test --update-snapshots", + "test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots", "test:nuxt": "vite test --project nuxt", "test:types": "nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types", "test:unit": "vite test --project unit",