obs-ffmpeg: Add pause visibility behaviour#6739
Open
mvji wants to merge 1 commit intoobsproject:masterfrom
Open
obs-ffmpeg: Add pause visibility behaviour#6739mvji wants to merge 1 commit intoobsproject:masterfrom
mvji wants to merge 1 commit intoobsproject:masterfrom
Conversation
cg2121
reviewed
Jul 16, 2022
based on PR 6112 by dcmouser Replace for local file checkbox "restart playback..." by a combobox with same mode than slideshow/vlc source visibility behaviour
|
I'm happy to support this modification over my older pull request with pause functionality. |
6 tasks
Member
|
This needs testing against audio, video, and audio/video files, as well as remote content to ensure everything works appropriately. It hasn't been merged because the testing isn't complete, and it hasn't been a high priority for us. |
Member
|
There is a major issue with this PR (which might not be this PR's fault though):
By itself it all works as intended to a degree, but because of the way the media source is designed (and playback is handled) it introduces race conditions and unintuitive program states because of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #6112
Add ability to pause local media src when source is not visible, and unpause when not visible
Use combobox like slideshow/vlc source visibility behaviour
Use a similar UI code than PR #6239
Motivation and Context
Let user choose to pause a media when not visible
Another step to align media source features with other source.
How Has This Been Tested?
Mac os Intel 11.6.7
or new combobox "Visibility Behaviour" (in local file mode), correctly update UI
Types of changes
Checklist: