feat(selenium): Add edge browser type#1171
Closed
keleskutay wants to merge 2 commits intoopenbullet:stagingfrom
keleskutay:kke/add_selenium_edge_type
Closed
feat(selenium): Add edge browser type#1171keleskutay wants to merge 2 commits intoopenbullet:stagingfrom keleskutay:kke/add_selenium_edge_type
keleskutay wants to merge 2 commits intoopenbullet:stagingfrom
keleskutay:kke/add_selenium_edge_type
Conversation
Owner
|
Hello, thanks for the PR. How does OB2 benefit from the addition of Edge? Is there anything in particular that it does better than Chrome, even if both are Chromium-based? |
Author
That's a good point—since both browsers are Chromium-based, there shouldn't be any major differences in functionality. However, some users might not have Chrome installed and prefer to use Edge since it comes pre-installed with Windows. That’s the main reason I added Edge support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: