Skip to content

Display error messages for each failure #286

@mgoerens

Description

@mgoerens

Currently, only the error message related to the first failing step is communicated to the user.

See

if pr_content_result == "failure":
detail_message = append_to(
detail_message, prepare_pr_content_failure_comment()
)
gitutils.add_output("pr_passed", "false")
elif run_verifier_result == "failure":
detail_message = append_to(
detail_message, prepare_run_verifier_failure_comment()
)
gitutils.add_output("pr_passed", "false")
elif verify_result == "failure":
if community_manual_review:
outcome = "Pending Manual Review"
detail_message = append_to(detail_message, prepare_community_comment())
gitutils.add_output("pr_passed", "true")
else:
detail_message = append_to(detail_message, prepare_failure_comment())
gitutils.add_output("pr_passed", "false")
elif oc_install_result == "failure":
detail_message = append_to(
detail_message, prepare_oc_install_fail_comment()
)
gitutils.add_output("pr_passed", "false")
else:

We should consider displaying error messages for each failure that was received rather than only for the first one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions