-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Description
Currently, only the error message related to the first failing step is communicated to the user.
See
development/scripts/src/pullrequest/prepare_pr_comment.py
Lines 233 to 256 in dcce7a5
| if pr_content_result == "failure": | |
| detail_message = append_to( | |
| detail_message, prepare_pr_content_failure_comment() | |
| ) | |
| gitutils.add_output("pr_passed", "false") | |
| elif run_verifier_result == "failure": | |
| detail_message = append_to( | |
| detail_message, prepare_run_verifier_failure_comment() | |
| ) | |
| gitutils.add_output("pr_passed", "false") | |
| elif verify_result == "failure": | |
| if community_manual_review: | |
| outcome = "Pending Manual Review" | |
| detail_message = append_to(detail_message, prepare_community_comment()) | |
| gitutils.add_output("pr_passed", "true") | |
| else: | |
| detail_message = append_to(detail_message, prepare_failure_comment()) | |
| gitutils.add_output("pr_passed", "false") | |
| elif oc_install_result == "failure": | |
| detail_message = append_to( | |
| detail_message, prepare_oc_install_fail_comment() | |
| ) | |
| gitutils.add_output("pr_passed", "false") | |
| else: |
We should consider displaying error messages for each failure that was received rather than only for the first one.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels