Skip to content

Comments

OCPBUGS-60159: add vsphere permissions for checking if users is authorized to see metrics#642

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhrmo:OCPBUGS-60159
Jan 28, 2026
Merged

OCPBUGS-60159: add vsphere permissions for checking if users is authorized to see metrics#642
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhrmo:OCPBUGS-60159

Conversation

@rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Oct 31, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 31, 2025
@openshift-ci-robot
Copy link
Contributor

@rhrmo: This pull request references Jira Issue OCPBUGS-60159, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Contributor Author

rhrmo commented Oct 31, 2025

/test e2e-vsphere-csi

@rhrmo rhrmo marked this pull request as ready for review January 6, 2026 08:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@openshift-ci openshift-ci bot requested review from RomanBednar and dobsonj January 6, 2026 08:19
@rhrmo
Copy link
Contributor Author

rhrmo commented Jan 6, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2026
@openshift-ci-robot
Copy link
Contributor

@rhrmo: This pull request references Jira Issue OCPBUGS-60159, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore January 6, 2026 08:20
@rhrmo
Copy link
Contributor Author

rhrmo commented Jan 6, 2026

I am not sure why we do not need these permissions in other operators but in CSO it causes issues... what I added fixes the bug but there could also be an issue regarding permissions elsewhere (ie this should be inherited but isn't) I was unable to uncover, if you have any input please share it

@rhrmo
Copy link
Contributor Author

rhrmo commented Jan 27, 2026

/retest-required

@jsafrane
Copy link
Contributor

/lgtm
/aprove

@jsafrane
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2026
@radeore
Copy link

radeore commented Jan 27, 2026

Pre-merge verified on cluster-bot generated build,
OCP version:

Server Version: 4.22.0-0-2026-01-27-151912-test-ci-ln-c2n25p2-latest
Kubernetes Version: v1.34.2-dirty

Test results:
Expected http_code: '403' is returned,

$ oc -n openshift-monitoring exec -c prometheus prometheus-k8s-0 -- curl -k -s -o /dev/null -w '%{http_code}' https://10.xxx.0.yy:8445/metrics
403

$ oc -n openshift-monitoring exec -c prometheus prometheus-k8s-0 -- curl -k https://10.xxx.0.yy:8445/metrics
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "forbidden: User \"system:anonymous\" cannot get path \"/metrics\"",
  "reason": "Forbidden",
  "details": {},
  "code": 403

@radeore
Copy link

radeore commented Jan 27, 2026

/verified by @radeore and CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 27, 2026
@openshift-ci-robot
Copy link
Contributor

@radeore: This PR has been marked as verified by @radeore and CI.

Details

In response to this:

/verified by @radeore and CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 00672f3 and 2 for PR HEAD bf561b1 in total

@rhrmo
Copy link
Contributor Author

rhrmo commented Jan 28, 2026

/test e2e-azure-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ecae643 into openshift:main Jan 28, 2026
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@rhrmo: Jira Issue Verification Checks: Jira Issue OCPBUGS-60159
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-60159 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Contributor Author

rhrmo commented Jan 28, 2026

/cherry-pick release-4.21

@openshift-cherrypick-robot

@rhrmo: new pull request created: #660

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-28-225830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants