From 78ab31a3626601fd0545b5856f6587a8d15a7071 Mon Sep 17 00:00:00 2001 From: B77Mills Date: Mon, 20 Oct 2025 15:17:40 -0500 Subject: [PATCH] Revert "Make product id optional" --- services/graphql/src/definitions/customer.js | 2 +- services/graphql/src/resolvers/customer.js | 23 +++++++++----------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/services/graphql/src/definitions/customer.js b/services/graphql/src/definitions/customer.js index aa2e1bd..cd5f0cd 100644 --- a/services/graphql/src/definitions/customer.js +++ b/services/graphql/src/definitions/customer.js @@ -215,7 +215,7 @@ input CustomerExternalIdsInput { input RapidCustomerIdentificationMutationInput { "The product ID to associate with this rapid identification." - productId: Int + productId: Int! "The customer's email address." email: String! "First name of customer, up to 100 characters long" diff --git a/services/graphql/src/resolvers/customer.js b/services/graphql/src/resolvers/customer.js index e933df4..ce03387 100644 --- a/services/graphql/src/resolvers/customer.js +++ b/services/graphql/src/resolvers/customer.js @@ -371,7 +371,7 @@ module.exports = { const promoCode = input.promoCode ? input.promoCode.trim() : null; if (promoCode && promoCode.length > 50) throw new UserInputError('The promo code must be 50 characters or fewer.'); - const productMap = new Map([...(input.productId ? [input.productId, true] : [])]); + const productMap = new Map([[input.productId, true]]); const deploymentTypeIdMap = input.deploymentTypeIds.reduce((map, id) => { map.set(id, true); @@ -433,19 +433,16 @@ module.exports = { if (faxNumber) phones.push({ Number: faxNumber, PhoneContactType: 240 }); const body = { RunProcessor: 1, - ...((productMap && productMap.length) - && { - Products: [...productMap].map(([OmedaProductId, Receive]) => { - const subscription = subscriptions.find((obj) => obj.id === OmedaProductId); - return ({ - OmedaProductId, - Receive: Number(Receive), - ...(subscription && subscription.requestedVersion && { - RequestedVersion: subscription.requestedVersion, - }), - }); + Products: [...productMap].map(([OmedaProductId, Receive]) => { + const subscription = subscriptions.find((obj) => obj.id === OmedaProductId); + return ({ + OmedaProductId, + Receive: Number(Receive), + ...(subscription && subscription.requestedVersion && { + RequestedVersion: subscription.requestedVersion, }), - }), + }); + }), Emails: [{ EmailAddress: email }], ...(phones.length && { Phones: phones }), ...(firstName && { FirstName: firstName }),