Skip to content

FilterToolbar - responsiveness/presentation #2

@jpuzz0

Description

@jpuzz0

Looks like this component is marked as deprecated, so these things might be known already, but the component has certain behavior that might not be desired by users.

  1. With a smaller window size, when the icon is clicked, there ends up being a lot of white-space:
    image
  2. Users might want to use a custom action/button in place of the filter icon or make it more accessible.
  3. The prop showFiltersSideBySide ends up just hiding the "Name" dropdown from the screenshot above. I'm not sure why this is, but the title of the prop indicates otherwise:
    image
  4. There seems to be an issue where the filter dropdown is shown when it shouldn't be as seen in this video:
    https://github.com/patternfly-labs/react-table-batteries/assets/96431149/5c0c6acc-7962-401a-a9c0-b258bcd8eaaf

In general, it seems like component default presentation/behavior should be dictated by design, and there should be an allowance of more composability, whether it be icons, or placement of elements with respect to others.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions