From 41a8e229dbee717fcb2522a3b51e9f723fa742f5 Mon Sep 17 00:00:00 2001
From: Pascal Charbonneau <pcharbon70@gmail.com>
Date: Sat, 28 Feb 2026 03:29:13 -0700
Subject: [PATCH] fix(onboarding): block step 7 imports without validated
 repository access

---
 lib/jido_code/setup/project_import.ex        |  9 +++++
 test/jido_code/setup/project_import_test.exs | 20 +++++++++++
 test/jido_code_web/live/setup_live_test.exs  | 38 ++++++++++++++++++++
 3 files changed, 67 insertions(+)

diff --git a/lib/jido_code/setup/project_import.ex b/lib/jido_code/setup/project_import.ex
index 7456479..f60d8fb 100644
--- a/lib/jido_code/setup/project_import.ex
+++ b/lib/jido_code/setup/project_import.ex
@@ -229,6 +229,15 @@ defmodule JidoCode.Setup.ProjectImport do
       })
       when is_list(available_repositories) and is_map(onboarding_state) do
     cond do
+      available_repositories == [] ->
+        blocked_report(
+          checked_at,
+          selected_repository,
+          "repository_selection_unavailable",
+          "No validated repositories are available for import selection.",
+          @default_selection_remediation
+        )
+
       is_nil(selected_repository) ->
         blocked_report(
           checked_at,
diff --git a/test/jido_code/setup/project_import_test.exs b/test/jido_code/setup/project_import_test.exs
index 291eb81..870ead3 100644
--- a/test/jido_code/setup/project_import_test.exs
+++ b/test/jido_code/setup/project_import_test.exs
@@ -73,6 +73,26 @@ defmodule JidoCode.Setup.ProjectImportTest do
     assert is_binary(project.settings["workspace"]["last_synced_at"])
   end
 
+  test "run/3 blocks manual repository imports when validated repository access is unavailable" do
+    onboarding_state = %{
+      "4" => %{
+        "github_credentials" => %{
+          "paths" => []
+        }
+      }
+    }
+
+    report = ProjectImport.run(nil, "owner/repo-one", onboarding_state)
+
+    assert ProjectImport.blocked?(report)
+    assert report.status == :blocked
+    assert report.error_type == "repository_selection_unavailable"
+    assert report.detail =~ "No validated repositories"
+
+    {:ok, projects} = Project.read(query: [filter: [github_full_name: "owner/repo-one"]])
+    assert projects == []
+  end
+
   test "run/3 does not create duplicate project records for repeat imports" do
     onboarding_state = %{
       "4" => %{
diff --git a/test/jido_code_web/live/setup_live_test.exs b/test/jido_code_web/live/setup_live_test.exs
index c541e7d..993be46 100644
--- a/test/jido_code_web/live/setup_live_test.exs
+++ b/test/jido_code_web/live/setup_live_test.exs
@@ -1663,6 +1663,44 @@ defmodule JidoCodeWeb.SetupLiveTest do
     assert has_element?(view, "#setup-project-repository-option-owner-repo-one", "owner/repo-one")
   end
 
+  test "step 7 blocks manual repository imports when validated repository access is unavailable", %{
+    conn: conn
+  } do
+    onboarding_state =
+      onboarding_state_through_step_6()
+      |> put_in(["4", "github_credentials", "paths"], [])
+
+    Application.put_env(:jido_code, :system_config, %{
+      onboarding_completed: false,
+      onboarding_step: 7,
+      onboarding_state: onboarding_state
+    })
+
+    {:ok, view, _html} = live(conn, ~p"/setup", on_error: :warn)
+
+    assert has_element?(view, "#setup-project-repository-listing-status", "Blocked")
+
+    view
+    |> form("#onboarding-step-form", %{
+      "step" => %{
+        "repository_full_name" => "owner/repo-one",
+        "validated_note" => "Attempting manual import without validated repositories"
+      }
+    })
+    |> render_submit()
+
+    assert has_element?(view, "#resolved-onboarding-step", "Step 7")
+    assert has_element?(view, "#setup-save-error", "repository_selection_unavailable")
+    assert has_element?(view, "#setup-save-error", "No validated repositories are available")
+
+    persisted_config = Application.get_env(:jido_code, :system_config)
+    assert Map.fetch!(persisted_config, :onboarding_step) == 7
+    refute Map.has_key?(Map.fetch!(persisted_config, :onboarding_state), "7")
+
+    {:ok, projects} = Project.read(query: [filter: [github_full_name: "owner/repo-one"]])
+    assert projects == []
+  end
+
   test "step 7 imports the selected repository and step 8 completes onboarding with dashboard next actions",
        %{conn: _conn} do
     register_owner("owner@example.com", "owner-password-123")