Fullstack-project review

[ShootingStar91]

Fullstack practice project review

This is a review for your fullstack practice project. You do not need to implement any suggestions for improvement mentioned here in order to receive your credits.

User experience

• Simple, easy-to-use website
• There are little functionalities, some displaying of data and sorting it. Unfortunately I cannot be sure that the scraping works. I went to star one repository and launched a scraping job for it but the star amount did not change. This may be due to delay. Anyways, I will just have to trust that the scraper actually works.
• Wrong login credentials displays an error notification, good
• If I refresh the page while on the Update Repos -view, the app crashes and an "Unknown endpoint" error is displayed
• The layout seems responsive, working also on a mobile-sized screen

Code

• The code is well-organized.
• Good use of styled components to style the app
• Good use ot Typescript, too
• Utilized playwright for the scraping
• There is a lot of commented code. This makes the code messy and it should not be there according to the requirements for the practice project. When giving a project to be reviewed, you should make the code presentable, formatting the code and removing unnecessary commented things.

Overall

The idea is interesting, using a microservice scraper to read data from websites and displaying it. For review, it was difficult to test the actual functionality, but the frontend itself seems to work well enough. The code is well-organized. Overall, good job!

[pcolt]

I suppose your overall positive review means I successfully passed the course's final project 🎉🎊

Thank you for you helpful review. Let me just try to give a first answer to the critical aspects you pointed out:

• "Unfortunately I cannot be sure that the scraping works."
  Apparently that is because of Fly.io default settings, which automatically stop machines when there is low traffic. The problem is that the microservice uses only a pub/sub messaging system to fire up and so no traffic is detected and therefore it has to be started manually from the Fly.io dashboard.
  POSSIBLE SOLUTION: I can change the fly.toml file so either always one machine is up or Fly does not automatically stops them when traffic goes down. For instance to keep at least one machine always up:

auto_stop_machines = true
auto_start_machines = true
min_machines_running = 1

• "If I refresh the page while on the Update Repos -view, the app crashes and an "Unknown endpoint" error is displayed"
  You are right I missed this bug and I should review the code in order to fix it.
• "There is a lot of commented code."
  You are right my apologizes, I am used to leave commented code when I do big refactoring of code (the last one was because of a major migration to Typescript), but then I usually remove it (the original idea was to continue working on the project).