Box fitting count defaults to 1. Possible enhancement/bug?

[CountZachula]

@marcnicholas

"I believe I've found an actual API (rather than node.js) bug....not sure how best to communicate that?

The abridged issue is passing "count: 0" to the box fitting API for an item seems to result in "count: 1". I've written conditional code to work around this, but it might be worth fixing?

The reason it'd be nice is for shippers like us who have a finite number of products and want to use a JSON template and populate it with the item counts rather than use 'splice' to insert arrays into arrays (which is what I've ended up doing)."

[CountZachula]

@mentat

I don't see "count" as being part of the Box Fitting docs anymore. Could you comment further on this and possibly @marcnicholas' question?

Thanks,
Z

[marcnicholas]

Weird....I could have sworn it was in the docs, but it's in the examples, so I may have just picked up its use from there.

It definitely works with integers >= 1 :)

[CountZachula]

It was in the docs at one point because I have it in both of my libraries (postmaster-csharp, postmaster-nodejs)... or maybe I based this particular entity off the sample request code.

I'm guessing there is an item constraint there for a reason. Unfortunately, that one is out of my control. This issue may in fact belong in here: https://github.com/postmaster/postmaster-api/issues.

[marcnicholas]

Well, it's now been removed from the examples in the documentation too...it's hard to code against a moving target :-/

@mentat No comment?

[mentat]

Hi guys,

The boxfitting API hasn't changed in quite a while. Let me do some digging to see what the difference is.