From 022947396a424e789348132e936591d41d6d1cb9 Mon Sep 17 00:00:00 2001 From: sp-eshu17 Date: Tue, 11 Oct 2022 21:23:02 +0530 Subject: [PATCH 1/3] Comment Made --- myScripts.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/myScripts.js b/myScripts.js index 7ebaaf7..b2f91d6 100644 --- a/myScripts.js +++ b/myScripts.js @@ -1,4 +1,4 @@ - +//TypeScript is more preferred over Javascript now as it defines the type! var playerone,playertwo; var player1color = 'rgb(244, 65, 65)'; var player2color = 'rgb(66, 134, 244)'; @@ -204,4 +204,4 @@ function startTimer() { clearInterval(timer); timer = setInterval(updateTimer, 1000); updateTimer(); -} \ No newline at end of file +} From 7cac84618beb1d4c5696292dfd0c2e36d78a7423 Mon Sep 17 00:00:00 2001 From: sp-eshu17 Date: Tue, 11 Oct 2022 21:32:27 +0530 Subject: [PATCH 2/3] Comment random --- myScripts.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/myScripts.js b/myScripts.js index b2f91d6..78cb9f0 100644 --- a/myScripts.js +++ b/myScripts.js @@ -141,7 +141,7 @@ function horizontalWinCheck() { } } } - +//While deployment the console.log statments ought to be removed! // Check for vertical wins function verticalWinCheck() { From db518d904f13f01f2b342065bc53e07f96a72b3f Mon Sep 17 00:00:00 2001 From: sp-eshu17 Date: Tue, 11 Oct 2022 21:35:15 +0530 Subject: [PATCH 3/3] Use let instead of var --- myScripts.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/myScripts.js b/myScripts.js index 78cb9f0..cd32d9c 100644 --- a/myScripts.js +++ b/myScripts.js @@ -1,15 +1,16 @@ //TypeScript is more preferred over Javascript now as it defines the type! -var playerone,playertwo; -var player1color = 'rgb(244, 65, 65)'; -var player2color = 'rgb(66, 134, 244)'; +//let is preferred than var. So use let more! +let playerone,playertwo; +let player1color = 'rgb(244, 65, 65)'; +let player2color = 'rgb(66, 134, 244)'; const startBtn= document.getElementById("start"); const nameInput= document.getElementById('nameInput') let playtTime = document.getElementById("timeforplay") -var timer; -var timeLeft; +let timer; +let timeLeft; async function inputs(){ startBtn.style.display="none";