From 7f92cbe9910b6c660b669ba2c285fbf47ede8ef9 Mon Sep 17 00:00:00 2001
From: Ghassan Nasr <ghassan.nasr@gmail.com>
Date: Mon, 29 Jun 2020 16:45:15 -0400
Subject: [PATCH 1/3] implemented three functions: getLine, getBox,
 getUpperLeftTriangle

---
 assets/js/shapes.js | 35 +++++++++++++++++++++++++++++------
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/assets/js/shapes.js b/assets/js/shapes.js
index e4351ba..b124351 100644
--- a/assets/js/shapes.js
+++ b/assets/js/shapes.js
@@ -1,31 +1,54 @@
 function getLine(length) {
-    // TODO - write method definition here
+  // TODO - write method definition here
+  var str = "";
+  for(var i=0; i<length; i++) {
+    str+= "*";
+  }
+  return str;
 }
 
 
 
 function getBox(width, height) {
-    // TODO - write method definition here
+  // TODO - write method definition here
+  var str = "";
+  for(var i=0; i<height; i++) {
+    for(var j=0; j<width; j++) {
+     str += "*"; 
+    }
+    str += "\n";
+  }
+  return str;
 }
 
 
 
 function getBottomLeftTriangle(length) {
-    // TODO - write method definition here
+  // TODO - write method definition here
 }
 
 
 function getUpperLeftTriangle(length) {
-    // TODO - write method definition here
+  // TODO - write method definition here
+var str = "";
+for (var i = length; i > 0; i--) {
+  for (var k = 0; k < i; k++) {
+    str += "*";
+  }
+  if(i != 1) {
+    str += "\n";
+  }
+}
+return str;
 }
 
 
 
 function getPyramid(length) {
-    // TODO - write method definition here
+  // TODO - write method definition here
 }
 
 
 function getCheckerboard(width, height) {
-    // TODO - write method definition here
+  // TODO - write method definition here
 }

From e1c9af9b3a30f56ad9a7a993dc9e0ac94d73982c Mon Sep 17 00:00:00 2001
From: Ghassan Nasr <ghassan.nasr@gmail.com>
Date: Mon, 29 Jun 2020 19:20:13 -0400
Subject: [PATCH 2/3] All functions passed the tests, some implementations are
 more elegant than others

---
 assets/js/shapes.js | 64 ++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 55 insertions(+), 9 deletions(-)

diff --git a/assets/js/shapes.js b/assets/js/shapes.js
index b124351..53e249e 100644
--- a/assets/js/shapes.js
+++ b/assets/js/shapes.js
@@ -25,30 +25,76 @@ function getBox(width, height) {
 
 function getBottomLeftTriangle(length) {
   // TODO - write method definition here
+  var str = "";
+  for (var i = 1; i <= length; i++) {
+    for (var j = 0; j < i; j++) {
+      str += "*";
+    }
+    if (i != length) {
+      str += "\n";
+    }
+  }
+
+  return str;
 }
 
 
+
 function getUpperLeftTriangle(length) {
   // TODO - write method definition here
-var str = "";
-for (var i = length; i > 0; i--) {
-  for (var k = 0; k < i; k++) {
-    str += "*";
-  }
-  if(i != 1) {
-    str += "\n";
+  var str = "";
+  for (var i = length; i > 0; i--) {
+    for (var k = 0; k < i; k++) {
+      str += "*";
+    }
+    if (i != 1) {
+      str += "\n";
+    }
   }
-}
-return str;
+  return str;
 }
 
 
 
 function getPyramid(length) {
   // TODO - write method definition here
+  var str = "";
+  for (var layer = 1; layer <= length; layer++) {
+
+    //add leading spaces
+    for (var j = 0; j < length - layer; j++) {
+      str += " ";
+    }
+    //add asterisks
+    for (var j = 0; j < 2 * layer - 1; j++) {
+      str += "*";
+    }
+    //addiing spaces
+    for (var j = 0; j < length - layer; j++) {
+      str += " ";
+    }
+    str += (layer<length ? "\n" : "");
+  }
+  return str;
 }
 
 
 function getCheckerboard(width, height) {
   // TODO - write method definition here
+  var str = "";
+
+  for (var layer = 1; layer <= height; layer++) {
+    var isOddLayer = (layer % 2) == 1;
+    for (var slot = 1; slot <= width; slot++) {
+      var isOddSlot = (slot % 2 == 1);
+      if (isOddLayer) {
+        str += isOddSlot ? " " : "*";
+      }
+      else {
+        str += isOddSlot ? "*" : " ";
+      }
+    }
+    str += "\n";
+  }
+  return str;
 }

From b744a5a2946a11b8981b1341db4f9efc5029a217 Mon Sep 17 00:00:00 2001
From: Ghassan Nasr <ghassan.nasr@gmail.com>
Date: Tue, 30 Jun 2020 07:03:44 -0400
Subject: [PATCH 3/3] made code much more elegant and used ternary operator

---
 assets/js/shapes.js | 105 ++++++++++++++++++++------------------------
 1 file changed, 47 insertions(+), 58 deletions(-)

diff --git a/assets/js/shapes.js b/assets/js/shapes.js
index 53e249e..3ec6d71 100644
--- a/assets/js/shapes.js
+++ b/assets/js/shapes.js
@@ -1,7 +1,7 @@
 function getLine(length) {
-  // TODO - write method definition here
-  var str = "";
-  for(var i=0; i<length; i++) {
+
+  let str = "";
+  for(let spot=1; spot<=length; spot++) {
     str+= "*";
   }
   return str;
@@ -10,30 +10,22 @@ function getLine(length) {
 
 
 function getBox(width, height) {
-  // TODO - write method definition here
-  var str = "";
-  for(var i=0; i<height; i++) {
-    for(var j=0; j<width; j++) {
-     str += "*"; 
-    }
-    str += "\n";
-  }
+
+  let str = "";
+  for(let level=1; level<=height; level++)
+     str += getLine(width) + "\n"; 
   return str;
+
 }
 
 
 
 function getBottomLeftTriangle(length) {
-  // TODO - write method definition here
-  var str = "";
-  for (var i = 1; i <= length; i++) {
-    for (var j = 0; j < i; j++) {
-      str += "*";
-    }
-    if (i != length) {
-      str += "\n";
-    }
-  }
+
+  let str = "";
+  
+  for(let level = 1; level<=length; level++)
+    str += getLine(level) + (level!=length ? "\n" : "");
 
   return str;
 }
@@ -41,60 +33,57 @@ function getBottomLeftTriangle(length) {
 
 
 function getUpperLeftTriangle(length) {
-  // TODO - write method definition here
-  var str = "";
-  for (var i = length; i > 0; i--) {
-    for (var k = 0; k < i; k++) {
-      str += "*";
-    }
-    if (i != 1) {
-      str += "\n";
-    }
-  }
+  
+  let str = "";
+  
+  for(let level=length; level > 0; level--)
+    str += getLine(level) + (level!=1 ? "\n" : "");
+
   return str;
 }
 
 
 
 function getPyramid(length) {
-  // TODO - write method definition here
-  var str = "";
-  for (var layer = 1; layer <= length; layer++) {
 
-    //add leading spaces
-    for (var j = 0; j < length - layer; j++) {
-      str += " ";
-    }
-    //add asterisks
-    for (var j = 0; j < 2 * layer - 1; j++) {
-      str += "*";
-    }
-    //addiing spaces
-    for (var j = 0; j < length - layer; j++) {
-      str += " ";
-    }
-    str += (layer<length ? "\n" : "");
+  let str = "";
+  
+  for(let level=1; level<=length; level++) {
+
+    let spaces = "";
+    for(let i=0; i<length-level; i++)
+      spaces += " ";
+
+    let thisLevelWidth = 2*level - 1;    
+    str += spaces + getLine(thisLevelWidth) + spaces + (level<length ? "\n" : "");
+
   }
+
   return str;
 }
 
 
 function getCheckerboard(width, height) {
-  // TODO - write method definition here
-  var str = "";
-
-  for (var layer = 1; layer <= height; layer++) {
-    var isOddLayer = (layer % 2) == 1;
-    for (var slot = 1; slot <= width; slot++) {
-      var isOddSlot = (slot % 2 == 1);
-      if (isOddLayer) {
+
+  let str = "";
+
+  for(let level=1; level<=height; level++) {
+    
+    let isOddLayer = (level % 2) == 1;
+    
+    for(let slot=1; slot<=width; slot++) {
+      
+      let isOddSlot = (slot % 2 == 1);
+      
+      if (isOddLayer)
         str += isOddSlot ? " " : "*";
-      }
-      else {
+      else
         str += isOddSlot ? "*" : " ";
-      }
+    
     }
+
     str += "\n";
   }
+
   return str;
 }