Config::onProduction fails if using branch name "main"

[mglaman]

The onProduction method fails if you use a branch name of main.

$prodBranch = $this->onDedicated() ? 'production' : 'master';

[pjcdawkins]

Fixing this properly will depend on the rollout of environment types, which is soon (https://platform.sh/blog/2021/environment-types-simpler-user-permissions/) - there would be a PLATFORM_ENVIRONMENT_TYPE=production variable I believe.

Meanwhile, you'd have to use getenv('PLATFORM_BRANCH') === 'main'

[gilzow]

@pjcdawkins do you think we can close this one since environment types have been out for a couple of years now?

[amanire]

Just noting that this is not resolved in 2.4.1.

[ylp-ineris]

Just noting that

• this is not resolved in 3.0.0 :-)
• this bug implies another real and anoying bug in platform.sh Drupal10 template
• a 2022 PR existts and may fix the problem

There may be something to do?

[matthiaz]

The previous PR did not address the backwards incompatibility, but I did propose a new PR that should work for new and old containers.

#31