Merge pull request #47 from plotday/fix/rename-call

Rename call() to callCallback()

Author: KrisBraun

.changeset/twenty-hands-melt.md

@@ -0,0 +1,5 @@
+---
+"@plotday/sdk": minor
+---
+
+Changed: BREAKING: Rename Agent.call() and Tool.call() to callCallback() to avoid confusion with JavaScript's Object.call().

agents/events/package.json

@@ -10,7 +10,8 @@
   "private": true,
   "scripts": {
     "deploy": "plot agent deploy",
-    "lint": "plot agent lint"
+    "lint": "plot agent lint",
+    "logs": "plot agent logs"
   },
   "dependencies": {
     "@plotday/sdk": "workspace:^",

sdk/src/agent.ts

@@ -98,8 +98,8 @@ export abstract class Agent<TSelf = any> {
    * @param args - Optional arguments to pass to the callback
    * @returns Promise resolving to the callback result
    */
-  protected async call(token: Callback, args?: any): Promise<any> {
-    return this._callbackTool.call(token, args);
+  protected async callCallback(token: Callback, args?: any): Promise<any> {
+    return this._callbackTool.callCallback(token, args);
   }
 
   /**
@@ -304,8 +304,8 @@ export abstract class Tool<TSelf = any> implements ITool {
    * @param args - Optional arguments to pass to the callback
    * @returns Promise resolving to the callback result
    */
-  protected async call(token: Callback, args?: any): Promise<any> {
-    return this._callbackTool.call(token, args);
+  protected async callCallback(token: Callback, args?: any): Promise<any> {
+    return this._callbackTool.callCallback(token, args);
   }
 
   /**

sdk/src/tools/auth.ts

@@ -1,4 +1,4 @@
-import { type ActivityLink, type Callback, ITool, type Tools } from "..";
+import { type ActivityLink, type Callback, ITool } from "..";
 
 /**
  * Built-in tool for managing OAuth authentication flows.
@@ -55,7 +55,7 @@ export abstract class Auth extends ITool {
       level: AuthLevel;
       scopes: string[];
     },
-    _callback: Callback,
+    _callback: Callback
   ): Promise<ActivityLink>;
 
   /**

sdk/src/tools/callback.ts

@@ -50,7 +50,7 @@ export type CallbackContext<T, K extends keyof T> = T[K] extends (
  *
  * **Note:** Callback methods are also available directly on Agent and Tool classes
  * via `this.callback()`, `this.deleteCallback()`, `this.deleteAllCallbacks()`, and
- * `this.call()`. This is the recommended approach for most use cases.
+ * `this.callCallback()`. This is the recommended approach for most use cases.
  *
  * **When to use callbacks:**
  * - Webhook handlers that need persistent function references
@@ -120,5 +120,5 @@ export abstract class CallbackTool<TParent = any> extends ITool {
    * @param args - Optional arguments to pass to the callback function
    * @returns Promise resolving to the callback result
    */
-  abstract call(_callback: Callback, _args?: any): Promise<any>;
+  abstract callCallback(_callback: Callback, _args?: any): Promise<any>;
 }