Skip to content

Sample windows #7

@liluxuan1997

Description

@liluxuan1997

Hi,ranjaykrishna:
I think there's one problem in data.py. In line 218, the default setting of argument 'replace' in np.random.choice() is True, which will lead repeated sampling windows. So in my opinion, the correct form should be:
sample = np.random.choice(nWindows, self.max_W, replace=False)
Though I don't how much it will affect the performance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions