-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Description
Hi,ranjaykrishna:
I think there's one problem in data.py. In line 218, the default setting of argument 'replace' in np.random.choice() is True, which will lead repeated sampling windows. So in my opinion, the correct form should be:
sample = np.random.choice(nWindows, self.max_W, replace=False)
Though I don't how much it will affect the performance.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels