Lightning Core > 2.11.0 Unsupported on older browsers

[SemHelevenAndrome]

Hi,
while updating the lng core and sdk to the latest versions (2.13.1 and 5.5.3) We noticed that Lightning crashes on older browsers. We would like to support Samsung 2017 tvs and LG 2017 tvs. These use a chromium browser v47 and v38 respectively. When using lng dev, there seems to be error in the startApp.js file, where:

var url = new URL(document.location.href);
resolve(url.searchParams.has('texture'));

url.searchParams is supported from chrome 51.

When changing this to resolve true (for testing), we get a different error where bundle is undefined.

This seems to be the case even when using core v2.12.0. This did work on core v2.11.0 (currently in use). This would prevent us from updating our lng core. Which is not ideal.
Can these older browser stay supported? Thanks in advance.

Kind regards
Sem

[elsassph]

We do that: https://www.npmjs.com/package/url-polyfill

[SemHelevenAndrome]

I just tried with an minimal app. So only lng create and then lng dist --es5. And it gives some strange errors on chrome 37.

On latest sdk with corresponding core version it does not work. On sdk 5.5.1 with core 2.12.1 it does not work. On lower (sdk 5.5.0 and core 2.11.0) it all works perfectly. Can this backwards compatibility be fixed or will this no longer be supported?

[SemHelevenAndrome]

Any update on this? It seems that the compiled lng core does not support these older browsers. And should be transpiled/ build to support these older browsers. To me it does not seem possible to rebuild this node module when building the lng app, using lng dist.

[SemHelevenAndrome]

Hi, I have narrowed it down to this commit: e52364a from @frank-weindel. From this commit, the es5 build no longer works due to the unexpected strict mode reserved word, on older browser (Chrome 38). Can I get some help because I don't understand why it has stopped working. Many thanks in advance.

[OlaSamuelDev]

I am also experiencing this issue. For some reason the @lightningjs/core/dist/lightning.es5 files include EC2015 "default parameters" in version 2.12.0 and above which are not compatible with Samsung 2017 and LG 2017. As a work around I am going to downgrade to 2.11.0 but could this be looked into please 🙏

[SemHelevenAndrome]

Hi, any update on this?

[SemHelevenAndrome]

Hi, any update on this?

[michielvandergeest]

hey @SemHelevenAndrome and @OlaSamuelDev this PR has been created last week: #586 . But I think this issue hasn't been referenced in it, so there was no update posted here. Would you be able to test with this branch and let us know if this resolves your issue? Then we'll be able to move this PR along and get a new release out.

Thanks

[SemHelevenAndrome]

Hi, I just tested this PR. This does not seem to resolve it on its own. And it looks to me like this is a workaround. This PR fixes an issue where it is not supported on chrome 47 to use a function with a default parameter, like: foo(bar = 0) And rewrites it so there is just a option parameter and gives it a default value in the code ( foo(bar?: number) {var bar2 = bar | 0;} ). The way I see it is that there is some wrong build config that no longer targets a old chrome version, and does not transpile the foo(bar = 0) to something that is es5 or chrome 47 compatible. The changes in this PR might be just enough to make it accidentally work on chrome 47. But we need a bit more and would like to have chrome 38 supported in the es5 build. For example the use of let it is supported partially from chrome 41. And in the newest version of lightning core v2.12.0 and higher, there seem to be let keywords in the es5 builds. In this commit it seems to go wrong e52364a . I lack a bit of knowledge to understand and fix it myself. But maybe if the build configurations are corrected to fix support for chrome 38. The PR request of Drulokia might not even be needed, as the build process would transpile such code.
I might be wrong in everything I say here, I lack knowledge and experience in this topic.

[elsassph]

There seem to be a problem in the build configuration indeed. The ES5 bundle still has let and class code while they should have been transpiled down.

Can you check this branch? #587

[SemHelevenAndrome]

The branch #587 Seems to fix it