From 020802e294bbf9c8c08e4dd8eae652fa4553ed80 Mon Sep 17 00:00:00 2001 From: dkumar798_comcast Date: Wed, 31 Dec 2025 09:00:59 +0000 Subject: [PATCH 1/5] RDKEMW-12054: Fix Coverity identified issues --- ds/audioOutputPort.cpp | 8 +- ds/hdmiIn.cpp | 2 +- ds/include/exception.hpp | 2 +- ds/videoDevice.cpp | 2 +- rpc/cli/dsVideoPort.c | 4 +- rpc/srv/dsAudio.c | 9 ++- sample/testFrontPanel.cpp | 158 +++++++++++++++++++------------------- 7 files changed, 96 insertions(+), 89 deletions(-) diff --git a/ds/audioOutputPort.cpp b/ds/audioOutputPort.cpp index e5c8fabc..2d5fde04 100644 --- a/ds/audioOutputPort.cpp +++ b/ds/audioOutputPort.cpp @@ -131,7 +131,7 @@ AudioOutputPort::AudioOutputPort(const int type, const int index, const int id) out << getType().getName() << _index; _name = out.str(); } - printf ("\nAudioOutputPort init: _type:%d _index:%d _handle:%d\n", _type, _index, _handle); + printf ("\nAudioOutputPort init: _type:%d _index:%d _handle:%ld\n", _type, _index, (long)_handle); if (dsERR_NONE == ret) { //dsGetAudioCompression (_handle, (dsAudioCompression_t *)&_compression); dsGetAudioEncoding (_handle, (dsAudioEncoding_t *)&_encoding); @@ -184,7 +184,7 @@ dsError_t AudioOutputPort::reInitializeAudioOutputPort() _name = out.str(); } - printf ("\nAudioOutputPort init: _type:%d _index:%d _handle:%d\n", _type, _index, _handle); + printf ("\nAudioOutputPort init: _type:%d _index:%d _handle:%ld\n", _type, _index,(long)_handle); if (dsERR_NONE == ret) { //dsGetAudioCompression>(_handle, (dsAudioCompression_t *)&_compression); dsGetAudioEncoding(_handle, (dsAudioEncoding_t *)&_encoding); @@ -1422,11 +1422,11 @@ void AudioOutputPort::setAudioDelay(const uint32_t audioDelayMs) dsError_t ret = dsERR_NONE; uint32_t ms = audioDelayMs; - INT_INFO("AudioOutputPort [%s], setting delay to [%lu] ms\n", _name.c_str(), audioDelayMs); + INT_INFO("AudioOutputPort [%s], setting delay to [%u] ms\n", _name.c_str(), audioDelayMs); if (ms > audioDelayMsMax) { - INT_ERROR("AudioOutputPort [%s], delay [%lu] ms, exceeds max [%lu]. Setting Max \n", + INT_ERROR("AudioOutputPort [%s], delay [%u] ms, exceeds max [%u]. Setting Max \n", _name.c_str(), audioDelayMs, audioDelayMsMax); diff --git a/ds/hdmiIn.cpp b/ds/hdmiIn.cpp index 514cff14..f107bba0 100755 --- a/ds/hdmiIn.cpp +++ b/ds/hdmiIn.cpp @@ -528,7 +528,7 @@ void HdmiInput::getHDMISPDInfo (int iHdmiPort, std::vector &data) { data.clear(); if (ret == dsERR_NONE) { if (sizeof(spdinfo) <= sizeof(struct dsSpd_infoframe_st)) { - printf("HdmiInput::getHDMISPDInfo has %d bytes\r\n", sizeof(spdinfo)); + printf("HdmiInput::getHDMISPDInfo has %zu bytes\r\n", sizeof(spdinfo)); data.insert(data.begin(), spdinfo, spdinfo + sizeof(struct dsSpd_infoframe_st)); } else { ret = dsERR_OPERATION_NOT_SUPPORTED; diff --git a/ds/include/exception.hpp b/ds/include/exception.hpp index 463435c7..bbb9836e 100644 --- a/ds/include/exception.hpp +++ b/ds/include/exception.hpp @@ -64,7 +64,7 @@ class Exception : public std::exception { * * @return None */ - Exception(const char *msg = "No Message for this exception") throw() : _msg(msg) { + Exception(const char *msg = "No Message for this exception") throw() : _err(0), _msg(msg) { } diff --git a/ds/videoDevice.cpp b/ds/videoDevice.cpp index 37452a0c..88726d9d 100644 --- a/ds/videoDevice.cpp +++ b/ds/videoDevice.cpp @@ -101,7 +101,7 @@ VideoDevice & VideoDevice::getInstance(int id) * @param[in] id Port id. * @return None. */ -VideoDevice::VideoDevice(int id) +VideoDevice::VideoDevice(int id): _dfc(0) { dsError_t ret = dsGetVideoDevice(id, &_handle); diff --git a/rpc/cli/dsVideoPort.c b/rpc/cli/dsVideoPort.c index 5ff4c9e4..d8e15541 100644 --- a/rpc/cli/dsVideoPort.c +++ b/rpc/cli/dsVideoPort.c @@ -82,7 +82,7 @@ dsError_t dsGetVideoPort(dsVideoPortType_t type, int index, intptr_t *handle) ¶m, sizeof(param)); - printf("%s..%d-%d\n",__func__,param.type,param.handle); + printf("%s..%d-%ld\n",__func__,param.type,(long)param.handle); if (IARM_RESULT_SUCCESS == rpcRet) { @@ -530,7 +530,7 @@ dsError_t dsEnableHDCP(intptr_t handle, bool contentProtect, char *hdcpKey, siz } } - printf("IARM:CLI:dsEnableHDCP %d, %p, %d\r\n", contentProtect, hdcpKey, keySize); + printf("IARM:CLI:dsEnableHDCP %d, %p, %zu\r\n", contentProtect, hdcpKey, keySize); IARM_Result_t rpcRet = IARM_RESULT_SUCCESS; rpcRet = IARM_Bus_Call(IARM_BUS_DSMGR_NAME, diff --git a/rpc/srv/dsAudio.c b/rpc/srv/dsAudio.c index 7d085ffd..bef08daf 100755 --- a/rpc/srv/dsAudio.c +++ b/rpc/srv/dsAudio.c @@ -1624,7 +1624,7 @@ void AudioConfigInit() m_volumeLeveller.level = atoi(_volLevellerLevel.c_str()); //SPEAKER init handle = 0; - INT_DEBUG("bDolbyVolumeOverrideCheck value: %d\n", bDolbyVolumeOverrideCheck); + INT_DEBUG("bDolbyVolumeOverrideCheck value: %d\n", (int)bDolbyVolumeOverrideCheck); if(bDolbyVolumeOverrideCheck && dsGetAudioPort(dsAUDIOPORT_TYPE_SPEAKER,0,&handle) == dsERR_NONE) { if (dsSetVolumeLevellerFunc(handle, m_volumeLeveller) == dsERR_NONE) { INT_INFO("Port %s: Initialized Volume Leveller : Mode: %d, Level: %d\n","SPEAKER0", m_volumeLeveller.mode, m_volumeLeveller.level); @@ -2357,9 +2357,14 @@ IARM_Result_t dsAudioMgr_init() IARM_Result_t dsAudioMgr_term() { #ifdef DS_AUDIO_SETTINGS_PERSISTENCE - if(persist_audioLevel_timer_threadIsAlive){ + IARM_BUS_Lock(lock); + bool shouldJoin = persist_audioLevel_timer_threadIsAlive; + if(shouldJoin){ persist_audioLevel_timer_threadIsAlive=false; pthread_cond_signal(&audioLevelTimerCV); + } + IARM_BUS_Unlock(lock); + if(shouldJoin){ pthread_join(persist_audioLevel_timer_threadId,NULL); } #endif diff --git a/sample/testFrontPanel.cpp b/sample/testFrontPanel.cpp index b1bddee4..99700b30 100755 --- a/sample/testFrontPanel.cpp +++ b/sample/testFrontPanel.cpp @@ -44,89 +44,91 @@ int main(int argc, char *argv[]) { - - int i = 0; - - IARM_Bus_Init("SampleDSClient"); - IARM_Bus_Connect(); - - - try { - device::Manager::Initialize(); - - if (argc != 2) { - printf("%s : \n", argv[0]); - return 0; - } - char *Message = argv[1]; - - int bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); - - sleep(20); - - device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("Message").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("Record").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("RfByPass").setBrightness(i); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); - - sleep(20); - - bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); - printf("Sample Application: set text display------- %s\n",Message); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setText(Message); - - for (i=10;i < 100 ; ) - { - printf("Sample Application: set text brightness------- %d\n",i); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); - i = i+ 10; - sleep(10); - } - - bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); - } - catch (...) { - printf("Exception Caught during [%s]\r\n", argv[0]); - } + try { + int i = 0; - device::Manager::DeInitialize(); + IARM_Bus_Init("SampleDSClient"); + IARM_Bus_Connect(); + device::Manager::Initialize(); - IARM_Bus_Disconnect(); - IARM_Bus_Term(); + if (argc != 2) { + printf("%s : \n", argv[0]); + device::Manager::DeInitialize(); + IARM_Bus_Disconnect(); + IARM_Bus_Term(); + return 0; + } + char *Message = argv[1]; + + int bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); - return 0; -} + sleep(20); + + device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("Message").setBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("Record").setBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("RfByPass").setBrightness(i); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); + + sleep(20); + + bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); + printf("Sample Application: set text display------- %s\n",Message); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setText(Message); + + for (i=10;i < 100 ; ) + { + printf("Sample Application: set text brightness------- %d\n",i); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); + i = i+ 10; + sleep(10); + } + bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); + + device::Manager::DeInitialize(); + IARM_Bus_Disconnect(); + IARM_Bus_Term(); + } + catch (const std::exception& e) { + fprintf(stderr, "Exception in %s: %s\n", argv[0], e.what()); + return 1; + } + catch (...) { + fprintf(stderr, "Unknown exception in %s\n", argv[0]); + return 1; + } + return 0; +} /** @} */ /** @} */ From ecd8908c60c111213e8808f8958f2389cd7b417c Mon Sep 17 00:00:00 2001 From: dkumar798 Date: Thu, 1 Jan 2026 09:12:03 +0530 Subject: [PATCH 2/5] RDKEMW-12054: Fix Coverity identified issues Added initialization flag to manage resource cleanup on exceptions. --- sample/testFrontPanel.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sample/testFrontPanel.cpp b/sample/testFrontPanel.cpp index 99700b30..db5ff9f7 100755 --- a/sample/testFrontPanel.cpp +++ b/sample/testFrontPanel.cpp @@ -44,6 +44,7 @@ int main(int argc, char *argv[]) { + bool initialized = false; try { int i = 0; @@ -51,6 +52,7 @@ int main(int argc, char *argv[]) IARM_Bus_Connect(); device::Manager::Initialize(); + initialized = true; if (argc != 2) { printf("%s : \n", argv[0]); @@ -121,10 +123,20 @@ int main(int argc, char *argv[]) } catch (const std::exception& e) { fprintf(stderr, "Exception in %s: %s\n", argv[0], e.what()); + if (initialized) { + device::Manager::DeInitialize(); + IARM_Bus_Disconnect(); + IARM_Bus_Term(); + } return 1; } catch (...) { fprintf(stderr, "Unknown exception in %s\n", argv[0]); + if (initialized) { + device::Manager::DeInitialize(); + IARM_Bus_Disconnect(); + IARM_Bus_Term(); + } return 1; } return 0; From d35aa749904264703beadc5b377c880afbb1f88f Mon Sep 17 00:00:00 2001 From: dkumar798_comcast Date: Tue, 6 Jan 2026 04:59:41 +0000 Subject: [PATCH 3/5] RDKEMW-12054: Fix Coverity identified issues --- ds/manager.cpp | 18 ++-- rpc/srv/dsAudio.c | 7 +- sample/testFrontPanel.cpp | 175 ++++++++++++++++++-------------------- 3 files changed, 101 insertions(+), 99 deletions(-) mode change 100755 => 100644 sample/testFrontPanel.cpp diff --git a/ds/manager.cpp b/ds/manager.cpp index eedcd8b2..bd18233e 100644 --- a/ds/manager.cpp +++ b/ds/manager.cpp @@ -105,11 +105,18 @@ Manager::~Manager() { */ void Manager::Initialize() { + bool needInit = false; + {std::lock_guard lock(gManagerInitMutex); - printf("Entering %s count %d with thread id %lu\n",__FUNCTION__,IsInitialized,pthread_self()); + printf("Entering %s count %d with thread id %lu\n",__FUNCTION__,IsInitialized,pthread_self()); + if (IsInitialized == 0) { + needInit = true; + } + IsInitialized++; + } try { - if (0 == IsInitialized) { + if (needInit) { dsError_t err = dsERR_GENERAL; unsigned int retryCount = 0; @@ -134,14 +141,15 @@ void Manager::Initialize() AudioOutputPortConfig::getInstance().load(); VideoOutputPortConfig::getInstance().load(); VideoDeviceConfig::getInstance().load(); - } - IsInitialized++; + } } catch(const Exception &e) { cout << "Caught exception during Initialization" << e.what() << endl; + std::lock_guard lock(gManagerInitMutex); + IsInitialized--; throw e; } - } + printf("Exiting %s with thread %lu\n",__FUNCTION__,pthread_self()); } diff --git a/rpc/srv/dsAudio.c b/rpc/srv/dsAudio.c index bef08daf..efb79d61 100755 --- a/rpc/srv/dsAudio.c +++ b/rpc/srv/dsAudio.c @@ -2357,15 +2357,18 @@ IARM_Result_t dsAudioMgr_init() IARM_Result_t dsAudioMgr_term() { #ifdef DS_AUDIO_SETTINGS_PERSISTENCE + bool shouldJoin = false; + pthread_t threadId; IARM_BUS_Lock(lock); - bool shouldJoin = persist_audioLevel_timer_threadIsAlive; + shouldJoin = persist_audioLevel_timer_threadIsAlive; if(shouldJoin){ persist_audioLevel_timer_threadIsAlive=false; + threadId = persist_audioLevel_timer_threadId; pthread_cond_signal(&audioLevelTimerCV); } IARM_BUS_Unlock(lock); if(shouldJoin){ - pthread_join(persist_audioLevel_timer_threadId,NULL); + pthread_join(threadId,NULL); } #endif return IARM_RESULT_SUCCESS; diff --git a/sample/testFrontPanel.cpp b/sample/testFrontPanel.cpp old mode 100755 new mode 100644 index db5ff9f7..fec714bf --- a/sample/testFrontPanel.cpp +++ b/sample/testFrontPanel.cpp @@ -44,103 +44,94 @@ int main(int argc, char *argv[]) { - bool initialized = false; - try { - int i = 0; - - IARM_Bus_Init("SampleDSClient"); - IARM_Bus_Connect(); - - device::Manager::Initialize(); - initialized = true; - - if (argc != 2) { - printf("%s : \n", argv[0]); - device::Manager::DeInitialize(); - IARM_Bus_Disconnect(); - IARM_Bus_Term(); - return 0; - } - char *Message = argv[1]; - - int bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); + + int i = 0; - sleep(20); - - device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("Message").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("Record").setBrightness(i); - device::FrontPanelConfig::getInstance().getIndicator("RfByPass").setBrightness(i); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); - - sleep(20); - - bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); - printf("Sample Application: set text display------- %s\n",Message); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setText(Message); - - for (i=10;i < 100 ; ) - { - printf("Sample Application: set text brightness------- %d\n",i); - device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); + IARM_Bus_Init("SampleDSClient"); + IARM_Bus_Connect(); + + + try { + device::Manager::Initialize(); + + if (argc != 2) { + printf("%s : \n", argv[0]); + return 0; + } + char *Message = argv[1]; + + int bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); + + sleep(20); + device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); - i = i+ 10; - sleep(10); + device::FrontPanelConfig::getInstance().getIndicator("Message").setBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("Record").setBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("RfByPass").setBrightness(i); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); + + sleep(20); + + bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); + printf("Sample Application: set text display------- %s\n",Message); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setText(Message); + + for (i=10;i < 100 ; ) + { + printf("Sample Application: set text brightness------- %d\n",i); + device::FrontPanelConfig::getInstance().getTextDisplay("Text").setTextBrightness(i); + device::FrontPanelConfig::getInstance().getIndicator("Power").setBrightness(i); + i = i+ 10; + sleep(10); + } + + bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); + printf("Power : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); + printf("Message : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); + printf("Record : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); + printf("RfByPass : brightness is %d\n",bright); + bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); + printf("Text : brightness is %d\n",bright); } + catch (...) { + printf("Exception Caught during [%s]\r\n", argv[0]); + } - bright = device::FrontPanelConfig::getInstance().getIndicator("Power").getBrightness(); - printf("Power : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Message").getBrightness(); - printf("Message : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("Record").getBrightness(); - printf("Record : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getIndicator("RfByPass").getBrightness(); - printf("RfByPass : brightness is %d\n",bright); - bright = device::FrontPanelConfig::getInstance().getTextDisplay("Text").getTextBrightness(); - printf("Text : brightness is %d\n",bright); - - device::Manager::DeInitialize(); - IARM_Bus_Disconnect(); - IARM_Bus_Term(); - } - catch (const std::exception& e) { - fprintf(stderr, "Exception in %s: %s\n", argv[0], e.what()); - if (initialized) { - device::Manager::DeInitialize(); - IARM_Bus_Disconnect(); - IARM_Bus_Term(); - } - return 1; - } - catch (...) { - fprintf(stderr, "Unknown exception in %s\n", argv[0]); - if (initialized) { - device::Manager::DeInitialize(); - IARM_Bus_Disconnect(); - IARM_Bus_Term(); - } - return 1; - } - return 0; + try { + device::Manager::DeInitialize(); + } + catch (...) { + printf("Unknown exception during DeInitialize\n"); + } + + + IARM_Bus_Disconnect(); + IARM_Bus_Term(); + + return 0; } + /** @} */ /** @} */ From 04507814fd96f399e71ca3ead86e675416554e53 Mon Sep 17 00:00:00 2001 From: dkumar798 Date: Tue, 6 Jan 2026 11:22:24 +0530 Subject: [PATCH 4/5] RDKEMW-12054: Fix Coverity identified issues --- rpc/srv/dsAudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/rpc/srv/dsAudio.c b/rpc/srv/dsAudio.c index efb79d61..70fdef1e 100755 --- a/rpc/srv/dsAudio.c +++ b/rpc/srv/dsAudio.c @@ -7230,6 +7230,7 @@ static void* persist_audioLevel_timer_threadFunc(void* arg) { break; } // wait for 3 sec, then update the latest audio level from cache variable + /* coverity[sleep : FALSE] */ if(audioLevel_timer_set){ sleep(3); From fa09f9d80a43088641a3e6ddbb38f2969b42fabb Mon Sep 17 00:00:00 2001 From: dkumar798 Date: Wed, 7 Jan 2026 11:36:12 +0530 Subject: [PATCH 5/5] RDKEMW-12054: Fix Coverity identified issues Removed default case handling for switch statements in EDID parser. --- ds/edid-parser.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/ds/edid-parser.cpp b/ds/edid-parser.cpp index 728a735c..9d51077c 100644 --- a/ds/edid-parser.cpp +++ b/ds/edid-parser.cpp @@ -55,7 +55,6 @@ static void parse_std_timing(unsigned char* bytes, edid_data_t* data_ptr) { case 1: v = (h * 3) / 4; break; case 2: v = (h * 4) / 5; break; case 3: v = (h * 9) / 16; break; - default: return; } int r = (bytes[idx + 1] & 0x3F) + 60; INT_DEBUG("STD %dx%d@%d\n", h, v, r); @@ -381,8 +380,6 @@ static void parse_ext_timing(unsigned char* bytes, edid_data_t* data_ptr) { case 6: break; // 'Use Extended Tag' case 7: parse_extended_db(&bytes[idx], data_ptr); break; - // default - unsupported - default: INT_DEBUG("Unsupported extension tag: 0x%X\n", tag); } idx += len + 1; }