From 42cf623978582d4c4e84684eeee6c790206e8301 Mon Sep 17 00:00:00 2001 From: Lasse Boisen Andersen Date: Wed, 18 Jun 2025 14:38:55 +0200 Subject: [PATCH] typescast to number, add test --- packages/flag-evaluation/src/index.ts | 4 ++-- packages/flag-evaluation/test/index.test.ts | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/flag-evaluation/src/index.ts b/packages/flag-evaluation/src/index.ts index 49c7e9af..e87ae2c1 100644 --- a/packages/flag-evaluation/src/index.ts +++ b/packages/flag-evaluation/src/index.ts @@ -304,7 +304,7 @@ export function evaluate( ); return false; } - return fieldValue > value; + return Number(fieldValue) > Number(value); case "LT": if (isNaN(Number(fieldValue)) || isNaN(Number(value))) { console.error( @@ -312,7 +312,7 @@ export function evaluate( ); return false; } - return fieldValue < value; + return Number(fieldValue) < Number(value); case "AFTER": case "BEFORE": { // more/less than `value` days ago diff --git a/packages/flag-evaluation/test/index.test.ts b/packages/flag-evaluation/test/index.test.ts index cb87eca5..66ffa1e2 100644 --- a/packages/flag-evaluation/test/index.test.ts +++ b/packages/flag-evaluation/test/index.test.ts @@ -381,10 +381,14 @@ describe("operator evaluation", () => { ["value", "GT", "value", false], ["value", "GT", "0", false], ["1", "GT", "0", true], + ["2", "GT", "10", false], + ["10", "GT", "2", true], ["value", "LT", "value", false], ["value", "LT", "0", false], ["0", "LT", "1", true], + ["2", "LT", "10", true], + ["10", "LT", "2", false], ["start VALUE end", "CONTAINS", "value", true], ["alue", "CONTAINS", "value", false],