From 0e4d60a765949965c37a77655a5df536d755d1e6 Mon Sep 17 00:00:00 2001 From: Joseph Kavanagh Date: Tue, 6 Jan 2026 15:19:33 +0000 Subject: [PATCH 1/5] feat(ui): error toast for failed service deletion --- web/ui/react-app/src/modals/delete-confirm.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/web/ui/react-app/src/modals/delete-confirm.tsx b/web/ui/react-app/src/modals/delete-confirm.tsx index 9f572090..f093c987 100644 --- a/web/ui/react-app/src/modals/delete-confirm.tsx +++ b/web/ui/react-app/src/modals/delete-confirm.tsx @@ -1,5 +1,6 @@ import { LoaderCircle } from 'lucide-react'; import { type FC, useCallback, useState } from 'react'; +import { toast } from 'sonner'; import { AlertDialog, AlertDialogAction, @@ -36,6 +37,12 @@ export const DeleteModal: FC = ({ disabled }) => { setOpen(false); hideModal(); }, + onError: (error) => { + console.error('Failed to delete service:', error); + toast.error('Failed to delete service.', { + description: `Error: ${error instanceof Error ? error.message : String(error)}`, + }); + }, }); // biome-ignore lint/correctness/useExhaustiveDependencies: mutate stable. From 6fb9781f91263410227b31ffc1c05c1489944b6d Mon Sep 17 00:00:00 2001 From: Joseph Kavanagh Date: Tue, 6 Jan 2026 14:59:58 -0800 Subject: [PATCH 2/5] Remove duplicate error log --- web/ui/react-app/src/modals/delete-confirm.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/web/ui/react-app/src/modals/delete-confirm.tsx b/web/ui/react-app/src/modals/delete-confirm.tsx index f093c987..a3c7b07e 100644 --- a/web/ui/react-app/src/modals/delete-confirm.tsx +++ b/web/ui/react-app/src/modals/delete-confirm.tsx @@ -38,7 +38,6 @@ export const DeleteModal: FC = ({ disabled }) => { hideModal(); }, onError: (error) => { - console.error('Failed to delete service:', error); toast.error('Failed to delete service.', { description: `Error: ${error instanceof Error ? error.message : String(error)}`, }); From 5b5a484a6d4109634289d8e80eb3ff217f843d9e Mon Sep 17 00:00:00 2001 From: Joseph Kavanagh Date: Tue, 6 Jan 2026 15:01:44 -0800 Subject: [PATCH 3/5] Remove duplicate console error logging on save failure --- web/ui/react-app/src/hooks/use-sortable-services.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/web/ui/react-app/src/hooks/use-sortable-services.ts b/web/ui/react-app/src/hooks/use-sortable-services.ts index c28823c2..b41e4a04 100644 --- a/web/ui/react-app/src/hooks/use-sortable-services.ts +++ b/web/ui/react-app/src/hooks/use-sortable-services.ts @@ -109,7 +109,6 @@ export const useSortableServices = () => { })); }) .catch((error: unknown) => { - console.error('Failed to save order:', error); toast.error('Failed to save order.', { description: `Error: ${error instanceof Error ? error.message : String(error)}`, }); From aa56d3ee2e19dafb59d85191e76ea5ed2d04e0be Mon Sep 17 00:00:00 2001 From: Joseph Kavanagh Date: Tue, 6 Jan 2026 15:02:30 -0800 Subject: [PATCH 4/5] Remove duplicate console error logging on save failure --- .../components/modals/service-edit/deployed-version-manual.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/web/ui/react-app/src/components/modals/service-edit/deployed-version-manual.tsx b/web/ui/react-app/src/components/modals/service-edit/deployed-version-manual.tsx index dc784e4c..8f971243 100644 --- a/web/ui/react-app/src/components/modals/service-edit/deployed-version-manual.tsx +++ b/web/ui/react-app/src/components/modals/service-edit/deployed-version-manual.tsx @@ -81,7 +81,6 @@ const DeployedVersionManual = () => { }, ); } catch (error) { - console.error('Failed to save version', error); toast.error('Failed to save version:', { description: mutationError?.message, }); From fc8d4594297a2d3666a6a57333fa833c20bbdbb5 Mon Sep 17 00:00:00 2001 From: Joseph Kavanagh Date: Tue, 6 Jan 2026 15:07:52 -0800 Subject: [PATCH 5/5] Remove duplicate console error logging on notify send failure --- .../src/components/modals/service-edit/test-notify.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/web/ui/react-app/src/components/modals/service-edit/test-notify.tsx b/web/ui/react-app/src/components/modals/service-edit/test-notify.tsx index 143bf09c..7f7e50d6 100644 --- a/web/ui/react-app/src/components/modals/service-edit/test-notify.tsx +++ b/web/ui/react-app/src/components/modals/service-edit/test-notify.tsx @@ -108,9 +108,7 @@ const TestNotify: FC = ({ path, original, extras }) => { setLastFetched(currentTime); await testRefetch(); } - } catch (error) { - console.error('Failed to send notify:', error); - } + } catch (error) {} }; // Icon for the test result.