More File Checking

[George-D-S]

Some other bits which could be added.

If repo is a "library" then there must not be a poetry.lock file.

If repo is a "library" there should be a py.typed file - and (and this seems to have regressed in a few packages) - there needs to be a reference in the pypoetry, manifest or somesuch so the file is bundled with the package. Without this MyPy doesn't work across repos.

While I write, https://github.com/regebro/pyroma seems quite useful for checking other issues with the packaging.

Oh and also...

https://deptry.com/

[OliveraReeves]

I feel like mypy cause more issues then it solves, but another package that is interesting is https://docs.astral.sh/[ty](https://docs.astral.sh/ty/)/ although it is much newer.

[andyatterton]

My suggestion would be duplicate the python file check and add whatever you think it is worth checking for. The reason I deliberately hardcode the files types rather than pass them as an input is so that we can enforce lists of files for all coding languages and situations that we want. I expect there to be several file checking files eventually.

[andyatterton]

Thinking about this might be an idea to wait till Monday, and we can use it as an example of how to create these workflows as there are a couple of moving parts

[George-D-S]

Re: MyPy

The bit I think is very helpful, when it works, is when it picks up assumptions that a value can never be None.

There's also been a few times it's picked up "1234567890" != 123456789 type errors when working with NHS/RR Numbers and numeric Disease/Modality codes.

Perhaps there's a case for a restricted mypy.ini so you disable the worst of it, like where it wants you to define a "struct" parameter.

The other thing to keep in mind is looking at some of the PEP submissions there is a drive to use the type hints for optimisation - though if you do that is it still Python...

[andyatterton]

The range of astral tools have, to my mind at least, been an improvement over what we were using before. It might be worth a look