Emails sent out with 0 pending updates

[rfjakob]

I am getting emails like this when there are no updates pending:

[updian] 4 servers with updates pending!

Updian has detected that the following servers have pending updates:

root@aaa:22: 0 pending updates
root@bbb:22: 0 pending updates
root@cccc:22: 0 pending updates
root@ddd:22: 0 pending updates

You can manage these updates at https://eeee/updian/

Regards,
updian on base

[dirkd]

While this was always the case with Updian's mail notifications I agree that this is somewhat spammy when there isn't a single pending update.

I'll look into it to find a sensible solution.

[geckoeffect]

I know its almost a year since the last comment but if you're still looking for a fix here is a modification to updian/cron/collect.py
starting at line 128 (https://github.com/robhost/UPDIAN/blob/master/updian/cron/collect.py#L128)
Patch can be found here -> https://github.com/geckoeffect/UPDIAN/blob/patch-1/updian/cron/collect.py

                       (host, updates[host]) for host in updates if updates[host] > 0] # only add servers with updates
#                       (host, updates[host]) for host in updates ]

        count_updates=len(update_list) # Count Number of servers to Update

        mailtext = update_mail_text.format(
#            count=len(updates),
            count=count_updates, # Pass update count to mail text
            update_list='\n'.join(update_list),
            updian_uri=config.updian_uri)

        mail = email.mime.text.MIMEText(mailtext)
#        mail['Subject'] = update_mail_subject.format(count=len(updates))
        mail['Subject'] = update_mail_subject.format(count=count_updates) #pass update count to mail subject
        mail['From'] = 'updian <%s>' % (config.mail_from)
        mail['To'] = config.mail_to

        smtp_server = smtplib.SMTP('localhost')
        if count_updates > 0: # only send mail if there are updates
                smtp_server.sendmail(config.mail_from, [config.mail_to],
                             mail.as_string())
                smtp_server.quit()

                print('Mail sent to', config.mail_to)