dhw hygiene duplicate channels

[rtuck99]

Seen here:
https://community.openhab.org/t/viessmann-api-binding-for-openhab-4-0-4-0-0-5-0-0/148259/71

Also here:
https://community.openhab.org/t/viessmann-api-binding-for-openhab-4-0-4-0-0-5-0-0/148259/82

[erikschitterer]

since yesterday I got this error message after restart OH 4.3.0 Snapshot:

2024-11-19 09:25:24.021 [WARN ] [re.internal.VicareDeviceThingHandler] - Unexpected error initializing Thing

java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Duplicate channels vicare:heating:8011cbcc17:3719b0fd-a6b6-3095-8ff5-85cfc43e35ee:heating_dhw_hygiene_enabled

Caused by: java.lang.IllegalArgumentException: Duplicate channels vicare:heating:8011cbcc17:3719b0fd-a6b6-3095-8ff5-85cfc43e35ee:heating_dhw_hygiene_enabled

	at com.qubular.openhab.binding.vicare.internal.VicareDeviceThingHandler.lambda$initialize$1(VicareDeviceThingHandler.java:124) ~[?:?]

openhab> bundle:list | grep vicare
341 │ Active  │  80 │ 4.0.3                 │ com.qubular.openhab-binding-vicare-bundle
342 │ Active  │  80 │ 4.0.3                 │ com.qubular.vicare-osgi

openhab> feature:list | grep vicare
com.qubular.openhab-binding-vicare                │ 4.0.3            │ x        │ Started     │ com.qubular.openhab-binding-vicare-4.0.3       │ Viessmann Vicare Binding

There is a double entry in the responseCapture.json file:

    {
      "feature": "heating.dhw.hygiene",
      "gatewayId": "***",
      "deviceId": "0",
      "timestamp": "2024-11-18T23:05:22.153Z",
      "isEnabled": true,
      "isReady": true,
      "apiVersion": 1,
      "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene",
      "properties": {
        "enabled": {
          "type": "boolean",
          "value": false
        }
      },
      "commands": {
        "activate": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/activate",
          "name": "activate",
          "isExecutable": false,
          "params": {}
        },
        "enable": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/enable",
          "name": "enable",
          "isExecutable": true,
          "params": {}
        },
        "disable": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/disable",
          "name": "disable",
          "isExecutable": false,
          "params": {}
        }
      }
    },
    {
      "feature": "heating.dhw.hygiene",
      "gatewayId": "***",
      "deviceId": "0",
      "timestamp": "2024-11-18T23:05:22.153Z",
      "isEnabled": true,
      "isReady": true,
      "apiVersion": 1,
      "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene",
      "properties": {
        "enabled": {
          "type": "boolean",
          "value": false
        }
      },
      "commands": {
        "activate": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/activate",
          "name": "activate",
          "isExecutable": false,
          "params": {}
        },
        "enable": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/enable",
          "name": "enable",
          "isExecutable": true,
          "params": {}
        },
        "disable": {
          "uri": "https://api.viessmann.com/iot/v2/features/installations/***/gateways/***/devices/0/features/heating.dhw.hygiene/commands/disable",
          "name": "disable",
          "isExecutable": false,
          "params": {}
        }
      }
    },

[svnsssd]

I had the problem of duplicate channels, too: In my case heating_dhw_temperature_hygiene apeared twice and the binding was not able to initialize. I traced this back to two identical entries in the JSON of the Viessmann API query. My boiler is a Vitodens 200W.
Following modification of get() in VicareChannelBuilder.java worked for me (function consolidate removes just the dublicated entries):

private List<Feature> consolidate(List<Feature> features) {

    List<String> keys = new ArrayList<String>();
    List<Feature> objects = new ArrayList<Feature>();

    for (Feature feature : features) {
        if (keys.contains(feature.getName())) {
            objects.add(feature);
        } else {
            keys.add(feature.getName());
        }
    }
    for (Feature f : objects) {
        features.remove(f);
    }

    return features;
}

@Override
public Memo get() {
    Result result = new Result(thing.getProperties());
    try {
        List<Feature> features = consolidate(vicareServiceProvider.getVicareService()
                .getFeatures(igd.installationId(), igd.gatewaySerial(), igd.deviceId()));
        for (Feature feature : features) {
            buildChannelsForFeature(feature, result);
        }

    } catch (AuthenticationException | IOException e) {
        return (() -> {
            throw e;
        });
    }
    return () -> result;
}