From a4d24f328480afaed61cf9799a34189f1ab19054 Mon Sep 17 00:00:00 2001 From: Yifan Sun Date: Thu, 12 Feb 2026 19:48:55 -0500 Subject: [PATCH] [Athena] Fix CI timeout: add testing.Short() skip to accuracy tests The accuracy tests (TestAccuracyAgainstBaseline, TestAccuracyDependencyChain, TestAccuracyArithmetic, TestAccuracyBranch, TestGenerateAccuracyReport) run full pipeline simulations that take >5 minutes. CI passes -short flag but these tests didn't check it, causing the Acceptance Tests job to timeout on every push. medium_test.go and polybench_test.go already had this pattern. Co-Authored-By: Claude Opus 4.6 --- benchmarks/accuracy_test.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/benchmarks/accuracy_test.go b/benchmarks/accuracy_test.go index 4e37ac9..98d07bd 100644 --- a/benchmarks/accuracy_test.go +++ b/benchmarks/accuracy_test.go @@ -137,6 +137,10 @@ func calculateError(simCPI, baselineCPI float64) float64 { // TestAccuracyAgainstBaseline compares simulator results against M2 baseline. // This is the main accuracy validation test for M2Sim. func TestAccuracyAgainstBaseline(t *testing.T) { + if testing.Short() { + t.Skip("skipping long-running accuracy test in short mode") + } + // Load baseline data baseline := loadBaseline(t) @@ -212,6 +216,10 @@ func TestAccuracyAgainstBaseline(t *testing.T) { // TestAccuracyDependencyChain specifically tests the dependency chain accuracy. // This is critical because it measures the simulator's handling of RAW hazards. func TestAccuracyDependencyChain(t *testing.T) { + if testing.Short() { + t.Skip("skipping long-running accuracy test in short mode") + } + baseline := loadBaseline(t) baselineEntry := findBaseline(baseline, "dependency") if baselineEntry == nil { @@ -249,6 +257,10 @@ func TestAccuracyDependencyChain(t *testing.T) { // TestAccuracyArithmetic tests ALU throughput accuracy. func TestAccuracyArithmetic(t *testing.T) { + if testing.Short() { + t.Skip("skipping long-running accuracy test in short mode") + } + baseline := loadBaseline(t) baselineEntry := findBaseline(baseline, "arithmetic") if baselineEntry == nil { @@ -280,6 +292,10 @@ func TestAccuracyArithmetic(t *testing.T) { // TestAccuracyBranch tests branch handling accuracy using conditional branches. // Uses branchTakenConditional to match native benchmark pattern (CMP + B.GE). func TestAccuracyBranch(t *testing.T) { + if testing.Short() { + t.Skip("skipping long-running accuracy test in short mode") + } + baseline := loadBaseline(t) baselineEntry := findBaseline(baseline, "branch") if baselineEntry == nil { @@ -373,6 +389,10 @@ func GenerateAccuracyReport(t *testing.T) AccuracyReport { // TestGenerateAccuracyReport tests the report generation and outputs JSON. func TestGenerateAccuracyReport(t *testing.T) { + if testing.Short() { + t.Skip("skipping long-running accuracy report generation in short mode") + } + report := GenerateAccuracyReport(t) reportJSON, err := json.MarshalIndent(report, "", " ")