From a467f509e5dd892a29983e8000921b4347872b2e Mon Sep 17 00:00:00 2001 From: Steve Greenwood Date: Tue, 1 Mar 2016 10:30:36 +0000 Subject: [PATCH 1/2] Allow for a custom placeholder fallback image --- src/angular-fallback-image.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/angular-fallback-image.js b/src/angular-fallback-image.js index f165a62..6fc8954 100644 --- a/src/angular-fallback-image.js +++ b/src/angular-fallback-image.js @@ -6,11 +6,19 @@ var elem = element; var attrs = attributes; var width, height; - + element.on('error', function() { - if(elem.attr('src') === attrs.srFallback) { + + if(elem.attr('src') === attrs.srFallback && !attrs.srcPlaceHolder) { throw new Error('The supplied fallback image doesn\'t exist'); + } else { + attrs.srFallback = attrs.srcPlaceHolder; } + + if(elem.attr('src') === attrs.srcPlaceHolder) { + throw new Error('The supplied fallback image doesn\'t exist'); + } + if(!attrs.srFallback) { width = elem[0].offsetWidth; height = elem[0].offsetHeight; From cc4b08cfff96343b051b025474221b25a4da8990 Mon Sep 17 00:00:00 2001 From: Steve Greenwood Date: Tue, 1 Mar 2016 12:11:48 +0000 Subject: [PATCH 2/2] Allow for a custom placeholder fallback image --- src/angular-fallback-image.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/angular-fallback-image.js b/src/angular-fallback-image.js index 6fc8954..12faad1 100644 --- a/src/angular-fallback-image.js +++ b/src/angular-fallback-image.js @@ -9,13 +9,13 @@ element.on('error', function() { - if(elem.attr('src') === attrs.srFallback && !attrs.srcPlaceHolder) { - throw new Error('The supplied fallback image doesn\'t exist'); - } else { - attrs.srFallback = attrs.srcPlaceHolder; - } - - if(elem.attr('src') === attrs.srcPlaceHolder) { + if(elem.attr('src') === attrs.srFallback) { + if(attrs.srcPlacHolder) { + attrs.srFallback = attrs.srcPlaceHolder; + } else { + throw new Error('The supplied fallback image doesn\'t exist'); + } + } else if(elem.attr('src') === attrs.srcPlaceHolder) { throw new Error('The supplied fallback image doesn\'t exist'); }