From 65b3ebbc83f08b27f1a3ab260092ca53aebb9705 Mon Sep 17 00:00:00 2001 From: Thomas Ghysels Date: Mon, 18 Mar 2019 10:01:45 +0100 Subject: [PATCH 1/2] Allow to pass empty string as files Fixes #4 --- signaturit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/signaturit.js b/signaturit.js index 6bca60f..0725111 100644 --- a/signaturit.js +++ b/signaturit.js @@ -68,7 +68,7 @@ function fillArray(formArray, values, parent) function extractPostParameters (form, files, recipients, parameters) { - files = [].concat(files); + files = files ? [].concat(files) : []; files.forEach(function(filePath, i) { form.append( @@ -77,7 +77,7 @@ function extractPostParameters (form, files, recipients, parameters) ); }); - recipients = [].concat(recipients); + recipients = recipients ? [].concat(recipients) : []; recipients.forEach(function(recipient, i) { fillArray(form, recipient, 'recipients['+i+']'); From 469b409e1d78c473457cb4b10352e3fb1eec7c77 Mon Sep 17 00:00:00 2001 From: Thomas Ghysels Date: Fri, 21 Jun 2019 17:34:14 +0200 Subject: [PATCH 2/2] Require recipients parameter --- signaturit.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/signaturit.js b/signaturit.js index 0725111..27c9a04 100644 --- a/signaturit.js +++ b/signaturit.js @@ -68,6 +68,10 @@ function fillArray(formArray, values, parent) function extractPostParameters (form, files, recipients, parameters) { + if (!recipients || Array.isArray(recipients) && !recipients.length) { + throw new Error('Missing required parameter: recipients') + } + files = files ? [].concat(files) : []; files.forEach(function(filePath, i) { @@ -77,7 +81,7 @@ function extractPostParameters (form, files, recipients, parameters) ); }); - recipients = recipients ? [].concat(recipients) : []; + recipients = [].concat(recipients); recipients.forEach(function(recipient, i) { fillArray(form, recipient, 'recipients['+i+']');