-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Is your feature request related to a problem? Please describe.
Currently Liquid tests are run in isolation. When you change something for template A, only tests for template A are updated and run. However, it could easily be that template B relies on results from template A so it is important to check that as well. Currently, there is no clear dependency graph/view that makes sure the template author is aware of template dependencies.
Describe the solution you'd like
Ideally, whenever a PR is created a Github Action should run and list all dependencies for the templates touched in the PR and provide it as comment in the PR to inform the preparer and reviewer. To retrieve the dependencies, instead of looking at the Liquid code we could start looking at the YAML code instead (we have tried doing it based on Liquid code in the past, but since things can be created dynamically in Liquid it's hard to retrieve).
As suggested by Rufo, we should probably first build this in the CLI and let the Github Action rely on the CLI. Having this feature available in the CLI will help for template authors to check template dependencies while doing fixes.
Other considerations
The biggest 'issue' with this approach is that we want to rely on YAML files. That also means that we need a high test coverage before this feature gets relevant.