Tests for Journal

[skorphil]

Tests for journal entity methods and helpers

[skorphil]

During this task I came up to conclusion, that current Journal and JournalDraft implementation must be changed.
i was influenced by OOP and tried to implement Journal and JournalDraft as a classes. However, since there is only a single instance of each possible in the app, I ended up making singletote. I do believe this significantly increased complexity of an app, introducing JournalManager to manage lifecycle of a Journal Singletone. Class itself adds complexities with this and implicit dependencies.

I think, It's better to not trying to implement OOP here, but use React conventions and provide setters and getters to the JournalState via series of customs hooks, for example New record form can use useRecord hook to get state and methods to manage record:

function useRecordDraft (timestamp) {
  return {
    // consuming values
    institutions // list of institutions within record
    date 
    quotes // list of qoutes within records
    // setting state
    createInstitution()  // add institution to given record
    createQuote() // add quote to given record
  }
}

So, for RecordDraft i guess it should look like this (i used class diagram to somehow illustrate hooks connections):
For Journal the same architecture might be used

classDiagram
direction LR
 InstitutionContainer <-- useInstitutionDraft
 NewRecord <-- useRecordDraft
 AssetContainer <-- useAssetDraft
 useInstitutionDraft <-- tinyBaseHooks
 useRecordDraft <-- tinyBaseHooks
 useAssetDraft <-- tinyBaseHooks
 tinyBaseHooks <-- tinyBaseIDB


class useRecordDraft{
	institutions
	date
	quotes
	createInstitution()
	createQuote()
	saveRecord()
}

class useInstitutionDraft{
	name
	country
	assets
	createAsset()
	deleteInstitution()
	restoreInstitution()
}

class useAssetDraft{
	name
	value
	currency
	comment
	deleteAsset()
	restoreAsset()
}

Loading