Record current cursor

[stephenmathieson]

Sophia gets confused when there's more than one cursor open on the same db.

Thoughts on sphia_t->cursor?

The following fails to remove "mykey" (assuming it's there).

void test_case() {
  void *c = sp_cursor(self->db, SPGT, NULL, 0);
  int count = sphia_count(self);
  sp_destroy(c);

  assert(0 == sphia_rm(self, "mykey"));
}

[jwerle]

I love it!

[stephenmathieson]

OK, cool. Should sphia_free destroy it if it's open?

EDIT: is there a way to check if a cursor is open?

[jwerle]

I think it should. We should consider sphia_cursor which can handle closing and opening new cursors, etc. I'm not sure how to check if one is open but I can dive into the source and check it out

[stephenmathieson]

I meant if (check_if_cursor_is_open(self->cursor)) sp_destroy(self->cursor);. I'm just not sure how to implement check_if_cursor_is_open.

Instead of sphia_cursor, I think we should just fail if there's an open cursor attached to self. For example:

int whatever(sphia_t *self) {
  if (magic(self->cursor)) {
    self->error = "Cursor already open, dummy!";
    return -1;
  }
  // . . . 
  return 0;
}

[jwerle]

Hmm, yeah I like this too. We just have to experiment !