From 0d5dc1cabe774ca84cf83c6885edb8c7c37e2e11 Mon Sep 17 00:00:00 2001 From: Thorsten Hans Date: Wed, 18 Feb 2026 15:47:40 +0100 Subject: [PATCH 1/2] fix: Disable OpenTelemetry SDK during installation Systems like GitHub Actions have env vars set to configure OpenTelemetry on the fly. The Spin CLI (telemetry crate) picks those up and tries to initialize the OTEL exporter, which fails. This commit disables OTEL SDK by setting OTEL_SDK_DISABLED=true Once all spin commands have been invoked the env var is unset again fixes: #175 Signed-off-by: Thorsten Hans --- .github/workflows/test-installer.yaml | 15 +++++++++++++++ downloads/install.sh | 5 +++++ 2 files changed, 20 insertions(+) create mode 100644 .github/workflows/test-installer.yaml diff --git a/.github/workflows/test-installer.yaml b/.github/workflows/test-installer.yaml new file mode 100644 index 00000000..9ba2ecb0 --- /dev/null +++ b/.github/workflows/test-installer.yaml @@ -0,0 +1,15 @@ +name: Test Installer Script +on: + pull_request: + branches: [main] + paths: + - downloads/install.sh + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout Code + uses: actions/checkout@v4 + - name: Run installer + run: bash downloads/install.sh diff --git a/downloads/install.sh b/downloads/install.sh index 468907c5..4f575c85 100755 --- a/downloads/install.sh +++ b/downloads/install.sh @@ -134,6 +134,9 @@ current_dir=$(pwd) # Define Spin directory name spin_directory_name="/spin" +# Disable OpenTelemetry SDK +export OTEL_SDK_DISABLED=true + if [ -d "${current_dir}$spin_directory_name" ]; then fancy_print 1 "Error: .$spin_directory_name already exists, please delete ${current_dir}$spin_directory_name and run the installer again." exit 1 @@ -180,6 +183,8 @@ if [[ $STATIC = "false" ]]; then else fancy_print 0 "Step 5: Skipping plugin installation for OS with musl" fi +# Re-Enable OpenTelemetry SDK +export OTEL_SDK_DISABLED= # Direct to quicks-start doc fancy_print 0 "You're good to go. Check here for the next steps: https://spinframework.dev/quickstart" fancy_print 0 "Run './spin' to get started" From b4ca60dbad4a30660af93f538f84a0e8a7f2ed34 Mon Sep 17 00:00:00 2001 From: Thorsten Hans Date: Thu, 19 Feb 2026 09:33:20 +0100 Subject: [PATCH 2/2] style: add blank line to separate re-enablement of OTEL SDKs Signed-off-by: Thorsten Hans --- downloads/install.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/downloads/install.sh b/downloads/install.sh index 4f575c85..3066bfd1 100755 --- a/downloads/install.sh +++ b/downloads/install.sh @@ -183,8 +183,10 @@ if [[ $STATIC = "false" ]]; then else fancy_print 0 "Step 5: Skipping plugin installation for OS with musl" fi + # Re-Enable OpenTelemetry SDK export OTEL_SDK_DISABLED= + # Direct to quicks-start doc fancy_print 0 "You're good to go. Check here for the next steps: https://spinframework.dev/quickstart" fancy_print 0 "Run './spin' to get started"