From cb57c50a2fc6ea8f21d026b4d778fac67aa55f3c Mon Sep 17 00:00:00 2001
From: Trefor Southwell <tdlj@tdlj.net>
Date: Sun, 8 Feb 2026 14:52:55 +0000
Subject: [PATCH 1/6] New savings chart in web UI Update Axle event sensor
 every minute - https://github.com/springfall2008/batpred/issues/3318

---
 apps/predbat/axle.py |  2 ++
 apps/predbat/web.py  | 81 +++++++++++++++++++++++---------------------
 2 files changed, 44 insertions(+), 39 deletions(-)

diff --git a/apps/predbat/axle.py b/apps/predbat/axle.py
index 25bc83c50..e24da25b8 100644
--- a/apps/predbat/axle.py
+++ b/apps/predbat/axle.py
@@ -307,6 +307,8 @@ async def run(self, seconds, first):
             except Exception as e:
                 self.log(f"Warn: Axle API: Exception during fetch: {e}")
                 self.failures_total += 1
+        elif (seconds % 60) == 0:  # Every minute, update state to reflect if event is active or not
+            self.publish_axle_event()
 
         return True
 
diff --git a/apps/predbat/web.py b/apps/predbat/web.py
index 155c00e71..6d0d9016d 100644
--- a/apps/predbat/web.py
+++ b/apps/predbat/web.py
@@ -2679,6 +2679,38 @@ def get_chart(self, chart):
             ]
 
             text += self.render_chart(series_data, "kW", "ML Load & PV Power with Temperature", now_str, extra_yaxis=secondary_axis)
+        elif chart == "Savings":
+            # Get daily savings data (historical)
+            savings_predbat_hist = history_attribute(self.get_history_wrapper(self.prefix + ".savings_yesterday_predbat", 28, required=False), daily=True, offset_days=-1, pounds=True)
+            savings_pvbat_hist = history_attribute(self.get_history_wrapper(self.prefix + ".savings_yesterday_pvbat", 28, required=False), daily=True, offset_days=-1, pounds=True)
+            cost_yesterday_hist = history_attribute(self.get_history_wrapper(self.prefix + ".cost_yesterday", 28, required=False), daily=True, offset_days=-1, pounds=True)
+
+            # Get cumulative/total savings over time (historical)
+            savings_total_predbat_hist = history_attribute(self.get_history_wrapper(self.prefix + ".savings_total_predbat", 28, required=False), daily=True, pounds=True)
+            savings_total_pvbat_hist = history_attribute(self.get_history_wrapper(self.prefix + ".savings_total_pvbat", 28, required=False), daily=True, pounds=True)
+
+            series_data = [
+                # Daily savings (bars) on primary axis
+                {"name": "Daily Predbat Saving", "data": savings_predbat_hist, "opacity": "1.0", "stroke_width": "2", "chart_type": "bar", "color": "#f5a442", "unit": self.currency_symbols[0]},
+                {"name": "Daily PV/Battery Saving", "data": savings_pvbat_hist, "opacity": "1.0", "stroke_width": "2", "chart_type": "bar", "color": "#3291a8", "unit": self.currency_symbols[0]},
+                {"name": "Daily Actual Cost", "data": cost_yesterday_hist, "opacity": "1.0", "stroke_width": "2", "chart_type": "bar", "color": "#eb2323", "unit": self.currency_symbols[0]},
+                # Cumulative savings (lines) on secondary axis
+                {"name": "Total Predbat Saving", "data": savings_total_predbat_hist, "opacity": "1.0", "stroke_width": "3", "stroke_curve": "smooth", "color": "#f5c43d", "unit": self.currency_symbols[0]},
+                {"name": "Total PV/Battery Saving", "data": savings_total_pvbat_hist, "opacity": "1.0", "stroke_width": "3", "stroke_curve": "smooth", "color": "#15eb8b", "unit": self.currency_symbols[0]},
+            ]
+
+            # Configure secondary axis for cumulative totals
+            secondary_axis = [
+                {
+                    "title": f"Total Savings ({self.currency_symbols[0]})",
+                    "series_names": ["Total Predbat Saving", "Total PV/Battery Saving"],
+                    "decimals": 0,
+                    "opposite": True,
+                    "labels_formatter": f"return val.toFixed(0);",
+                }
+            ]
+
+            text += self.render_chart(series_data, f"Daily Savings ({self.currency_symbols[0]})", "Cost Savings Analysis", now_str, daily_chart=False, extra_yaxis=secondary_axis)
         else:
             text += "<br><h2>Unknown chart type</h2>"
 
@@ -2695,49 +2727,20 @@ async def html_charts(self, request):
         text += "<body>\n"
         text += get_charts_css()
 
-        # Define which chart is active
-        active_battery = ""
-        active_power = ""
-        active_cost = ""
-        active_rates = ""
-        active_inday = ""
-        active_pv = ""
-        active_pv7 = ""
-        active_loadml = ""
-        active_loadmlpower = ""
-
-        if chart == "Battery":
-            active_battery = "active"
-        elif chart == "Power":
-            active_power = "active"
-        elif chart == "Cost":
-            active_cost = "active"
-        elif chart == "Rates":
-            active_rates = "active"
-        elif chart == "InDay":
-            active_inday = "active"
-        elif chart == "PV":
-            active_pv = "active"
-        elif chart == "PV7":
-            active_pv7 = "active"
-        elif chart == "LoadML":
-            active_loadml = "active"
-        elif chart == "LoadMLPower":
-            active_loadmlpower = "active"
-
         text += '<div class="charts-menu">'
         text += "<h3>Charts</h3> "
-        text += f'<a href="./charts?chart=Battery" class="{active_battery}">Battery</a>'
-        text += f'<a href="./charts?chart=Power" class="{active_power}">Power</a>'
-        text += f'<a href="./charts?chart=Cost" class="{active_cost}">Cost</a>'
-        text += f'<a href="./charts?chart=Rates" class="{active_rates}">Rates</a>'
-        text += f'<a href="./charts?chart=InDay" class="{active_inday}">InDay</a>'
-        text += f'<a href="./charts?chart=PV" class="{active_pv}">PV</a>'
-        text += f'<a href="./charts?chart=PV7" class="{active_pv7}">PV7</a>'
+        text += f'<a href="./charts?chart=Battery" class="{"active" if chart == "Battery" else ""}">Battery</a>'
+        text += f'<a href="./charts?chart=Power" class="{"active" if chart == "Power" else ""}">Power</a>'
+        text += f'<a href="./charts?chart=Cost" class="{"active" if chart == "Cost" else ""}">Cost</a>'
+        text += f'<a href="./charts?chart=Rates" class="{"active" if chart == "Rates" else ""}">Rates</a>'
+        text += f'<a href="./charts?chart=InDay" class="{"active" if chart == "InDay" else ""}">InDay</a>'
+        text += f'<a href="./charts?chart=PV" class="{"active" if chart == "PV" else ""}">PV</a>'
+        text += f'<a href="./charts?chart=PV7" class="{"active" if chart == "PV7" else ""}">PV7</a>'
+        text += f'<a href="./charts?chart=Savings" class="{"active" if chart == "Savings" else ""}">Savings</a>'
         # Only show LoadML chart if ML is enabled
         if self.base.get_arg("load_ml_enable", False):
-            text += f'<a href="./charts?chart=LoadML" class="{active_loadml}">LoadML</a>'
-            text += f'<a href="./charts?chart=LoadMLPower" class="{active_loadmlpower}">LoadMLPower</a>'
+            text += f'<a href="./charts?chart=LoadML" class="{"active" if chart == "LoadML" else ""}">LoadML</a>'
+            text += f'<a href="./charts?chart=LoadMLPower" class="{"active" if chart == "LoadMLPower" else ""}">LoadMLPower</a>'
         text += "</div>"
 
         text += '<div id="chart"></div>'

From bc985baaf3bba8b68ba289c0a4fa680e555aa346 Mon Sep 17 00:00:00 2001
From: Trefor Southwell <tdlj@tdlj.net>
Date: Sun, 8 Feb 2026 15:35:57 +0000
Subject: [PATCH 2/6] Component sorting, editor detect changes

---
 apps/predbat/web.py        | 100 ++++++++++++++++++++++++++++++++++---
 apps/predbat/web_helper.py |  52 +++++++++++++++++++
 2 files changed, 146 insertions(+), 6 deletions(-)

diff --git a/apps/predbat/web.py b/apps/predbat/web.py
index 6d0d9016d..f691f1335 100644
--- a/apps/predbat/web.py
+++ b/apps/predbat/web.py
@@ -25,6 +25,7 @@
 import threading
 import io
 from io import StringIO
+import hashlib
 from ruamel.yaml import YAML
 from ruamel.yaml.scalarstring import DoubleQuotedScalarString
 
@@ -127,6 +128,7 @@ async def start(self):
         app.router.add_post("/compare", self.html_compare_post)
         app.router.add_get("/apps_editor", self.html_apps_editor)
         app.router.add_post("/apps_editor", self.html_apps_editor_post)
+        app.router.add_get("/apps_editor_checksum", self.html_apps_editor_checksum)
         app.router.add_post("/plan_override", self.html_plan_override)
         app.router.add_post("/rate_override", self.html_rate_override)
         app.router.add_post("/restart", self.html_restart)
@@ -3338,6 +3340,9 @@ async def html_apps_editor(self, request):
         except Exception as e:
             file_error = f"Error reading apps.yaml: {str(e)}"
 
+        # Calculate MD5 checksum of the content for external change detection
+        file_checksum = hashlib.md5(apps_yaml_content.encode("utf-8")).hexdigest() if apps_yaml_content else ""
+
         text += get_editor_css()
         text += """
 
@@ -3347,10 +3352,10 @@ async def html_apps_editor(self, request):
         <div id="lintStatus" style="margin-top: 8px;"></div>
 """
 
-        text += """
+        text += f"""
     </div>
 
-    <form id="editorForm" class="editor-form" method="post" action="./apps_editor">
+    <form id="editorForm" class="editor-form" method="post" action="./apps_editor" data-file-checksum="{file_checksum}">
         <!-- We use a regular textarea that CodeMirror will replace -->
         <textarea class="editor-textarea" name="apps_content" id="appsContent" placeholder="Loading apps.yaml content...">"""
 
@@ -3387,6 +3392,19 @@ async def html_apps_editor(self, request):
 
         return web.Response(content_type="text/html", text=text)
 
+    async def html_apps_editor_checksum(self, request):
+        """
+        Return the current checksum and content of apps.yaml for external change detection
+        """
+        try:
+            apps_yaml_path = "apps.yaml"
+            with open(apps_yaml_path, "r") as f:
+                content = f.read()
+            checksum = hashlib.md5(content.encode("utf-8")).hexdigest()
+            return web.json_response({"checksum": checksum, "content": content})
+        except Exception as e:
+            return web.json_response({"error": str(e)}, status=500)
+
     async def html_apps_editor_post(self, request):
         """
         Handle POST request for apps.yaml editor - save the file
@@ -3746,14 +3764,46 @@ async def html_components(self, request):
         text += get_entity_modal_js()
         text += get_component_edit_modal_js()
 
-        text += "<h2>Component Status</h2>\n"
-        text += "<div class='components-grid'>\n"
-
         # Get all component information
         all_components = self.base.components.get_all()
         active_components = self.base.components.get_active()
 
+        # Count components by status
+        error_components = []
+        active_healthy_components = []
+        disabled_components = []
+
         for component_name in all_components:
+            is_alive = self.base.components.is_alive(component_name)
+            is_active = component_name in active_components
+
+            if is_active and not is_alive:
+                error_components.append(component_name)
+            elif is_active and is_alive:
+                active_healthy_components.append(component_name)
+            else:
+                disabled_components.append(component_name)
+
+        # Add heading with checkbox and totals on the same line
+        text += "<div style='display: flex; align-items: center; margin-bottom: 15px;'>\n"
+        text += "<h2 style='margin: 0; margin-right: 20px;'>Component Status</h2>\n"
+        text += "<label style='cursor: pointer; margin-right: 20px; white-space: nowrap;'>\n"
+        text += "<input type='checkbox' id='showDisabledCheckbox' onclick='toggleDisabledComponents()' style='margin-right: 8px;'>\n"
+        text += "Show disabled components\n"
+        text += "</label>\n"
+        text += "<div style='white-space: nowrap;'>\n"
+        text += f"<span style='color: #d32f2f; font-weight: bold;'>{len(error_components)} Error</span> | \n"
+        text += f"<span style='color: #4CAF50; font-weight: bold;'>{len(active_healthy_components)} Active</span> | \n"
+        text += f"<span style='color: #666; font-weight: bold;'>{len(disabled_components)} Disabled</span>\n"
+        text += "</div>\n"
+        text += "</div>\n"
+
+        text += "<div class='components-grid'>\n"
+
+        # Sort components: errors first, then active, then disabled
+        sorted_components = error_components + active_healthy_components + disabled_components
+
+        for component_name in sorted_components:
             from components import COMPONENT_LIST
 
             component_info = COMPONENT_LIST.get(component_name, {})
@@ -3770,7 +3820,11 @@ async def html_components(self, request):
             card_class = "active" if is_active else "inactive"
             if is_active and not is_alive:
                 card_class += " error"
-            text += f'<div class="component-card {card_class}">\n'
+
+            # Add data-disabled attribute for filtering
+            disabled_attr = 'data-disabled="true"' if not is_active else 'data-disabled="false"'
+
+            text += f'<div class="component-card {card_class}" {disabled_attr}>\n'
             text += f'<div class="component-header">\n'
             text += f'<h3>{component_info.get("name", component_name)}</h3>\n'
 
@@ -3908,6 +3962,40 @@ async def html_components(self, request):
 
         text += get_restart_button_js()
 
+        # Add JavaScript for toggling disabled components
+        text += """
+<script>
+function toggleDisabledComponents() {
+    const checkbox = document.getElementById('showDisabledCheckbox');
+    const showDisabled = checkbox.checked;
+
+    // Save preference to sessionStorage
+    sessionStorage.setItem('showDisabledComponents', showDisabled);
+
+    // Get all component cards
+    const cards = document.querySelectorAll('.component-card[data-disabled="true"]');
+
+    // Show or hide disabled components
+    cards.forEach(card => {
+        card.style.display = showDisabled ? '' : 'none';
+    });
+}
+
+// On page load, restore checkbox state from sessionStorage
+document.addEventListener('DOMContentLoaded', function() {
+    const checkbox = document.getElementById('showDisabledCheckbox');
+    const savedState = sessionStorage.getItem('showDisabledComponents');
+
+    // Default to false (unchecked) if no saved state
+    const showDisabled = savedState === 'true';
+    checkbox.checked = showDisabled;
+
+    // Apply the initial state
+    toggleDisabledComponents();
+});
+</script>
+"""
+
         text += "</body></html>\n"
         return web.Response(content_type="text/html", text=text)
 
diff --git a/apps/predbat/web_helper.py b/apps/predbat/web_helper.py
index b01052f6d..29c93b112 100644
--- a/apps/predbat/web_helper.py
+++ b/apps/predbat/web_helper.py
@@ -5293,6 +5293,58 @@ def get_editor_js():
             }
         });
 
+        // Set up external change detection
+        const form = document.getElementById('editorForm');
+        let originalChecksum = form.getAttribute('data-file-checksum');
+        let externalChangeWarningShown = false;
+
+        console.log('Initial checksum:', originalChecksum);
+
+        function checkForExternalChanges() {
+            fetch('./apps_editor_checksum')
+                .then(response => response.json())
+                .then(data => {
+                    console.log('Current file checksum:', data.checksum, 'Original:', originalChecksum);
+                    if (data.checksum && data.checksum !== originalChecksum && !externalChangeWarningShown) {
+                        const currentContent = editor.getValue();
+                        const hasLocalChanges = currentContent !== window.originalContent;
+
+                        console.log('External change detected! Has local changes:', hasLocalChanges);
+
+                        if (!hasLocalChanges) {
+                            // No local edits - auto-reload
+                            console.log('File changed externally, auto-reloading...');
+                            editor.setValue(data.content);
+                            window.originalContent = data.content;
+                            originalChecksum = data.checksum;  // Update the variable
+                            form.setAttribute('data-file-checksum', data.checksum);
+                            showMessage('File was changed externally and has been reloaded.', 'success');
+                            externalChangeWarningShown = false;  // Reset so we can detect future changes
+                        } else {
+                            // Has local edits - show warning
+                            externalChangeWarningShown = true;
+                            const warningDiv = document.createElement('div');
+                            warningDiv.className = 'message warning';
+                            warningDiv.style.display = 'block';
+                            warningDiv.style.backgroundColor = '#fff3cd';
+                            warningDiv.style.color = '#856404';
+                            warningDiv.style.border = '1px solid #ffeeba';
+                            warningDiv.innerHTML = `
+                                <strong>⚠️ Warning:</strong> The apps.yaml file has been changed externally. You have unsaved local changes.<br>
+                                <button onclick="location.reload()" style="margin-top: 10px; padding: 5px 10px; background: #856404; color: white; border: none; border-radius: 4px; cursor: pointer;">Reload and discard local changes</button>
+                            `;
+                            const messageContainer = document.getElementById('messageContainer');
+                            messageContainer.innerHTML = '';
+                            messageContainer.appendChild(warningDiv);
+                        }
+                    }
+                })
+                .catch(err => console.error('Error checking for external changes:', err));
+        }
+
+        // Check every 2 seconds for external changes
+        setInterval(checkForExternalChanges, 2000);
+
         // Initial lint after a short delay to ensure editor is fully loaded
         setTimeout(() => {
             // Perform the lint

From dc07419f9d6adcc910c111dc94ac9849ac255a89 Mon Sep 17 00:00:00 2001
From: Trefor Southwell <tdlj@tdlj.net>
Date: Sun, 8 Feb 2026 15:54:06 +0000
Subject: [PATCH 3/6] Web UI tests

---
 apps/predbat/ha.py                |   8 +-
 apps/predbat/tests/test_web_if.py | 350 ++++++++++++++++++++++++++----
 apps/predbat/web.py               |   2 +-
 3 files changed, 317 insertions(+), 43 deletions(-)

diff --git a/apps/predbat/ha.py b/apps/predbat/ha.py
index 79968c817..b31cb5c74 100644
--- a/apps/predbat/ha.py
+++ b/apps/predbat/ha.py
@@ -808,7 +808,13 @@ def call_service(self, service, **kwargs):
         data = {}
         for key in kwargs:
             data[key] = kwargs[key]
-        domain, service = service.split("/")
+        if "/" in service:
+            domain, service = service.split("/")
+        elif "." in service:
+            domain, service = service.split(".")
+        else:
+            domain = ""
+
         if self.websocket_active:
             return self.call_service_websocket_command(domain, service, data)
         else:
diff --git a/apps/predbat/tests/test_web_if.py b/apps/predbat/tests/test_web_if.py
index 4b6a396ea..78fb76109 100644
--- a/apps/predbat/tests/test_web_if.py
+++ b/apps/predbat/tests/test_web_if.py
@@ -10,6 +10,9 @@
 # fmt on
 import time
 import requests
+import os
+import shutil
+import tempfile
 from components import Components
 
 
@@ -19,46 +22,311 @@ def run_test_web_if(my_predbat):
     """
     failed = 0
     print("**** Running web interface test ****\n")
-    orig_ha_if = my_predbat.ha_interface
-    my_predbat.components = Components(my_predbat)
-    my_predbat.components.initialize()
-    my_predbat.components.start("ha_interface")
-    my_predbat.components.start("db")
-    my_predbat.components.start("web")
-    ha = my_predbat.ha_interface
-
-    # Fetch page from 127.0.0.1:5052
-    for page in ["/", "/dash", "/plan", "/config", "/apps", "/charts", "/compare", "/log", "/entity", "/components", "/browse"]:
-        print("Fetch page {}".format(page))
-        address = "http://127.0.0.1:5052" + page
-        res = requests.get(address)
+
+    # Create temp directory and copy apps.yaml
+    original_dir = os.getcwd()
+    temp_dir = tempfile.mkdtemp(prefix="predbat_test_")
+    print(f"Using temporary directory: {temp_dir}")
+
+    try:
+        # Copy apps.yaml to temp directory
+        if os.path.exists("apps.yaml"):
+            shutil.copy("apps.yaml", os.path.join(temp_dir, "apps.yaml"))
+
+        # Change to temp directory
+        os.chdir(temp_dir)
+
+        orig_ha_if = my_predbat.ha_interface
+        my_predbat.components = Components(my_predbat)
+        my_predbat.components.initialize()
+        my_predbat.components.start("ha_interface")
+        my_predbat.components.start("db")
+        my_predbat.components.start("web")
+        ha = my_predbat.ha_interface
+
+        # Define all registered endpoints from web.py
+        # Format: (method, path)
+        all_endpoints = [
+            ("GET", "/"),
+            ("GET", "/plan"),
+            ("GET", "/log"),
+            ("GET", "/apps"),
+            ("POST", "/apps"),
+            ("GET", "/charts"),
+            ("GET", "/config"),
+            ("GET", "/entity"),
+            ("POST", "/entity"),
+            ("POST", "/config"),
+            ("GET", "/dash"),
+            ("POST", "/dash"),
+            ("GET", "/components"),
+            ("GET", "/component_entities"),
+            ("POST", "/component_restart"),
+            ("GET", "/component_config"),
+            ("POST", "/component_config_save"),
+            ("GET", "/debug_yaml"),
+            ("GET", "/debug_log"),
+            ("GET", "/debug_apps"),
+            ("GET", "/debug_plan"),
+            ("GET", "/compare"),
+            ("POST", "/compare"),
+            ("GET", "/apps_editor"),
+            ("POST", "/apps_editor"),
+            ("GET", "/apps_editor_checksum"),
+            ("POST", "/plan_override"),
+            ("POST", "/rate_override"),
+            ("POST", "/restart"),
+            ("GET", "/api/state"),
+            ("GET", "/api/ping"),
+            ("POST", "/api/state"),
+            ("POST", "/api/service"),
+            ("GET", "/api/log"),
+            ("GET", "/api/entities"),
+            ("POST", "/api/login"),
+            ("GET", "/browse"),
+            ("GET", "/download"),
+            ("GET", "/internals"),
+            ("GET", "/api/internals"),
+            ("GET", "/api/internals/download"),
+            ("GET", "/api/status"),
+        ]
+
+        # Track accessed endpoints
+        accessed_endpoints = set()
+
+        # Fetch all GET pages from 127.0.0.1:5052
+        for method, page in all_endpoints:
+            if method != "GET":
+                continue
+            print("Fetch page {}".format(page))
+            address = "http://127.0.0.1:5052" + page
+
+            # Add required parameters for endpoints that need them
+            params = {}
+            if page == "/component_config":
+                params = {"component_name": "web"}
+            elif page == "/download":
+                params = {"file": "apps.yaml"}
+
+            if params:
+                res = requests.get(address, params=params)
+            else:
+                res = requests.get(address)
+
+            # /api/ping returns 500 when Predbat isn't fully initialized (expected in test)
+            # Other endpoints may return 400 for missing optional params, which is fine
+            if res.status_code in [200, 400, 404, 500]:
+                accessed_endpoints.add(("GET", page))
+            else:
+                print("ERROR: Unexpected status from {} got {} value {}".format(address, res.status_code, res.text))
+                failed = 1
+
+        # Test POST endpoints
+        print("\n**** Testing POST endpoints ****")
+
+        # Test /compare POST
+        print("Test POST /compare")
+        address = "http://127.0.0.1:5052/compare"
+        data = {"run": "run"}
+        res = requests.post(address, data=data)
         if res.status_code != 200:
-            print("ERROR: Failed to fetch from page {} got status {} value {}".format(address, res.status_code, res.text))
-            failed = 1
-
-    # Perform a post to /compare page with data for form 'compareform' value 'run'
-    print("**** Running test: Fetch page /compare with post")
-
-    address = "http://127.0.0.1:5052/compare"
-    data = {"run": "run"}
-    res = requests.post(address, data=data)
-    if res.status_code != 200:
-        print("ERROR: Failed to post to pagepage {} got status {} value {}".format(address, res.status_code, res.text))
-        failed = 1
-    time.sleep(0.1)
-    # Get service data
-    entity_id = "switch.predbat_compare_active"
-    result = ha.get_state(entity_id)
-
-    if result != "on":
-        print("ERROR: Compare tariffs not triggered - expected {} got {}".format("on", result))
-        failed = 1
-
-    # Run stop as task as we need to await it
-    my_predbat.create_task(my_predbat.components.stop("ha_interface"))
-    my_predbat.create_task(my_predbat.components.stop("web"))
-    my_predbat.create_task(my_predbat.components.stop("db"))
-    time.sleep(0.1)
-    my_predbat.components = Components(my_predbat)
-    my_predbat.ha_interface = orig_ha_if
+            print("ERROR: Failed to post to /compare got status {} value {}".format(res.status_code, res.text))
+            failed = 1
+        else:
+            accessed_endpoints.add(("POST", "/compare"))
+
+        time.sleep(0.1)
+
+        # Test /api/state POST
+        print("Test POST /api/state")
+        address = "http://127.0.0.1:5052/api/state"
+        data = {"entity_id": "sensor.predbat_status", "state": "Idle"}
+        res = requests.post(address, json=data)
+        # Accept 200 (success) or 500 (entity doesn't exist in test)
+        if res.status_code in [200, 500]:
+            accessed_endpoints.add(("POST", "/api/state"))
+        else:
+            print("ERROR: Unexpected response from /api/state: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /api/service POST
+        print("Test POST /api/service")
+        address = "http://127.0.0.1:5052/api/service"
+        # Correct format: service field should be full service name like "switch.turn_on"
+        data = {"service": "switch/turn_on", "data": {"entity_id": "switch.predbat_active"}}
+        res = requests.post(address, json=data)
+        if res.status_code in [200]:  # May fail if service doesn't exist in test
+            accessed_endpoints.add(("POST", "/api/service"))
+        else:
+            print("ERROR: Unexpected response from /api/service: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /config POST
+        print("Test POST /config")
+        address = "http://127.0.0.1:5052/config"
+        data = {"set_read_only": "true"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303]:  # Redirects are OK
+            accessed_endpoints.add(("POST", "/config"))
+        else:
+            print("ERROR: Unexpected response from /config: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /dash POST
+        print("Test POST /dash")
+        address = "http://127.0.0.1:5052/dash"
+        data = {"mode": "Monitor"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303]:
+            accessed_endpoints.add(("POST", "/dash"))
+        else:
+            print("ERROR: Unexpected response from /dash: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /entity POST
+        print("Test POST /entity")
+        address = "http://127.0.0.1:5052/entity"
+        data = {"entity_id": "switch.predbat_active", "value": "on"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303]:
+            accessed_endpoints.add(("POST", "/entity"))
+        else:
+            print("ERROR: Unexpected response from /entity: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /apps POST
+        print("Test POST /apps")
+        address = "http://127.0.0.1:5052/apps"
+        data = {"apps_content": "test: value"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303, 400]:
+            accessed_endpoints.add(("POST", "/apps"))
+        else:
+            print("ERROR: Unexpected response from /apps: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /apps_editor POST
+        print("Test POST /apps_editor")
+        address = "http://127.0.0.1:5052/apps_editor"
+        data = {"apps_content": "test: value"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303, 400]:
+            accessed_endpoints.add(("POST", "/apps_editor"))
+        else:
+            print("ERROR: Unexpected response from /apps_editor: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /plan_override POST
+        print("Test POST /plan_override")
+        address = "http://127.0.0.1:5052/plan_override"
+        data = {"soc": "50"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303, 400]:
+            accessed_endpoints.add(("POST", "/plan_override"))
+        else:
+            print("ERROR: Unexpected response from /plan_override: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /rate_override POST
+        print("Test POST /rate_override")
+        address = "http://127.0.0.1:5052/rate_override"
+        data = {"rate": "15"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303, 400]:
+            accessed_endpoints.add(("POST", "/rate_override"))
+        else:
+            print("ERROR: Unexpected response from /rate_override: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /restart POST
+        print("Test POST /restart")
+        address = "http://127.0.0.1:5052/restart"
+        res = requests.post(address, data={})
+        if res.status_code in [200, 400]:
+            accessed_endpoints.add(("POST", "/restart"))
+        else:
+            print("ERROR: Unexpected response from /restart: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /component_restart POST
+        print("Test POST /component_restart")
+        address = "http://127.0.0.1:5052/component_restart"
+        data = {"component_name": "web"}
+        res = requests.post(address, data=data)
+        if res.status_code in [200, 302, 303, 400]:
+            accessed_endpoints.add(("POST", "/component_restart"))
+        else:
+            print("ERROR: Unexpected response from /component_restart: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /component_config_save POST
+        print("Test POST /component_config_save")
+        address = "http://127.0.0.1:5052/component_config_save"
+        # Correct format: JSON with component_name, changes, deletions
+        data = {"component_name": "web", "changes": {}, "deletions": []}
+        res = requests.post(address, json=data)
+        if res.status_code in [200, 400, 500]:  # May fail if component doesn't support config changes
+            accessed_endpoints.add(("POST", "/component_config_save"))
+        else:
+            print("ERROR: Unexpected response from /component_config_save: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        # Test /api/login POST
+        print("Test POST /api/login")
+        address = "http://127.0.0.1:5052/api/login"
+        data = {"username": "test", "password": "test"}
+        res = requests.post(address, json=data)
+        if res.status_code in [200, 401, 400]:  # Expect auth failure
+            accessed_endpoints.add(("POST", "/api/login"))
+        else:
+            print("ERROR: Unexpected response from /api/login: {} - {}".format(res.status_code, res.text))
+            failed = 1
+
+        print("\n**** Verifying compare tariffs functionality ****")
+        time.sleep(0.1)
+        # Get service data
+        entity_id = "switch.predbat_compare_active"
+        result = ha.get_state(entity_id)
+
+        if result != "on":
+            print("ERROR: Compare tariffs not triggered - expected {} got {}".format("on", result))
+            failed = 1
+
+        # Check endpoint coverage
+        print("\n**** Checking endpoint coverage ****")
+        untested_endpoints = []
+        for endpoint in all_endpoints:
+            if endpoint not in accessed_endpoints:
+                untested_endpoints.append(endpoint)
+
+        if untested_endpoints:
+            print("\nWARNING: The following endpoints were not tested:")
+            for method, path in sorted(untested_endpoints):
+                print(f"  {method:6s} {path}")
+            print(f"\nTotal: {len(untested_endpoints)} untested endpoints out of {len(all_endpoints)}")
+            print(f"Coverage: {len(accessed_endpoints)}/{len(all_endpoints)} ({100*len(accessed_endpoints)//len(all_endpoints)}%)")
+            failed = 1
+        else:
+            if failed == 0:
+                print("\nSUCCESS: All endpoints were tested successfully!")
+            else:
+                print("\nFAILED: All endpoints were accessed but some tests failed. Please review the errors above.")
+
+        # Run stop as task as we need to await it
+        my_predbat.create_task(my_predbat.components.stop("ha_interface"))
+        my_predbat.create_task(my_predbat.components.stop("web"))
+        my_predbat.create_task(my_predbat.components.stop("db"))
+        time.sleep(0.1)
+        my_predbat.components = Components(my_predbat)
+        my_predbat.ha_interface = orig_ha_if
+
+    finally:
+        # Clean up: return to original directory and remove temp dir
+        os.chdir(original_dir)
+        try:
+            shutil.rmtree(temp_dir)
+            print(f"\nCleaned up temporary directory: {temp_dir}")
+        except Exception as e:
+            print(f"\nWarning: Failed to clean up temp directory {temp_dir}: {e}")
+
     return failed
diff --git a/apps/predbat/web.py b/apps/predbat/web.py
index f691f1335..6ee7a256a 100644
--- a/apps/predbat/web.py
+++ b/apps/predbat/web.py
@@ -1788,7 +1788,7 @@ async def html_api_post_state(self, request):
         JSON API
         """
         json_data = await request.json()
-        entity_id = json.get("entity_id", None)
+        entity_id = json_data.get("entity_id", None)
         state = json_data.get("state", None)
         attributes = json_data.get("attributes", {})
         if entity_id:

From 81873e6cd0955f202de9b24954f6c0b9461cda17 Mon Sep 17 00:00:00 2001
From: Trefor Southwell <tdlj@tdlj.net>
Date: Sun, 8 Feb 2026 16:53:35 +0000
Subject: [PATCH 4/6] Test updates

---
 apps/predbat/tests/test_web_if.py | 40 ++++++++++++++++++-------------
 apps/predbat/web.py               |  9 +++++--
 2 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/apps/predbat/tests/test_web_if.py b/apps/predbat/tests/test_web_if.py
index 78fb76109..6ace1c43c 100644
--- a/apps/predbat/tests/test_web_if.py
+++ b/apps/predbat/tests/test_web_if.py
@@ -32,6 +32,9 @@ def run_test_web_if(my_predbat):
         # Copy apps.yaml to temp directory
         if os.path.exists("apps.yaml"):
             shutil.copy("apps.yaml", os.path.join(temp_dir, "apps.yaml"))
+        # Create dummy predbat.log
+        with open(os.path.join(temp_dir, "predbat.log"), "w") as f:
+            f.write("Predbat debug log\n")
 
         # Change to temp directory
         os.chdir(temp_dir)
@@ -115,7 +118,10 @@ def run_test_web_if(my_predbat):
 
             # /api/ping returns 500 when Predbat isn't fully initialized (expected in test)
             # Other endpoints may return 400 for missing optional params, which is fine
-            if res.status_code in [200, 400, 404, 500]:
+            acceptable_statuses = [200]
+            if page == "/api/ping":
+                acceptable_statuses.append(500)
+            if res.status_code in acceptable_statuses:
                 accessed_endpoints.add(("GET", page))
             else:
                 print("ERROR: Unexpected status from {} got {} value {}".format(address, res.status_code, res.text))
@@ -166,7 +172,7 @@ def run_test_web_if(my_predbat):
         address = "http://127.0.0.1:5052/config"
         data = {"set_read_only": "true"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303]:  # Redirects are OK
+        if res.status_code in [200]:  # Redirects are OK
             accessed_endpoints.add(("POST", "/config"))
         else:
             print("ERROR: Unexpected response from /config: {} - {}".format(res.status_code, res.text))
@@ -177,7 +183,7 @@ def run_test_web_if(my_predbat):
         address = "http://127.0.0.1:5052/dash"
         data = {"mode": "Monitor"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/dash"))
         else:
             print("ERROR: Unexpected response from /dash: {} - {}".format(res.status_code, res.text))
@@ -188,7 +194,7 @@ def run_test_web_if(my_predbat):
         address = "http://127.0.0.1:5052/entity"
         data = {"entity_id": "switch.predbat_active", "value": "on"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/entity"))
         else:
             print("ERROR: Unexpected response from /entity: {} - {}".format(res.status_code, res.text))
@@ -199,7 +205,7 @@ def run_test_web_if(my_predbat):
         address = "http://127.0.0.1:5052/apps"
         data = {"apps_content": "test: value"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/apps"))
         else:
             print("ERROR: Unexpected response from /apps: {} - {}".format(res.status_code, res.text))
@@ -208,9 +214,9 @@ def run_test_web_if(my_predbat):
         # Test /apps_editor POST
         print("Test POST /apps_editor")
         address = "http://127.0.0.1:5052/apps_editor"
-        data = {"apps_content": "test: value"}
+        data = {"dummy": "data"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/apps_editor"))
         else:
             print("ERROR: Unexpected response from /apps_editor: {} - {}".format(res.status_code, res.text))
@@ -219,9 +225,9 @@ def run_test_web_if(my_predbat):
         # Test /plan_override POST
         print("Test POST /plan_override")
         address = "http://127.0.0.1:5052/plan_override"
-        data = {"soc": "50"}
+        data = {"time": "00:00", "action": "Clear"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/plan_override"))
         else:
             print("ERROR: Unexpected response from /plan_override: {} - {}".format(res.status_code, res.text))
@@ -230,9 +236,9 @@ def run_test_web_if(my_predbat):
         # Test /rate_override POST
         print("Test POST /rate_override")
         address = "http://127.0.0.1:5052/rate_override"
-        data = {"rate": "15"}
+        data = {"time": "00:00", "rate": "15", "action": "Clear SOC"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/rate_override"))
         else:
             print("ERROR: Unexpected response from /rate_override: {} - {}".format(res.status_code, res.text))
@@ -242,7 +248,7 @@ def run_test_web_if(my_predbat):
         print("Test POST /restart")
         address = "http://127.0.0.1:5052/restart"
         res = requests.post(address, data={})
-        if res.status_code in [200, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/restart"))
         else:
             print("ERROR: Unexpected response from /restart: {} - {}".format(res.status_code, res.text))
@@ -251,9 +257,9 @@ def run_test_web_if(my_predbat):
         # Test /component_restart POST
         print("Test POST /component_restart")
         address = "http://127.0.0.1:5052/component_restart"
-        data = {"component_name": "web"}
+        data = {"component": "db"}
         res = requests.post(address, data=data)
-        if res.status_code in [200, 302, 303, 400]:
+        if res.status_code in [200]:
             accessed_endpoints.add(("POST", "/component_restart"))
         else:
             print("ERROR: Unexpected response from /component_restart: {} - {}".format(res.status_code, res.text))
@@ -265,7 +271,7 @@ def run_test_web_if(my_predbat):
         # Correct format: JSON with component_name, changes, deletions
         data = {"component_name": "web", "changes": {}, "deletions": []}
         res = requests.post(address, json=data)
-        if res.status_code in [200, 400, 500]:  # May fail if component doesn't support config changes
+        if res.status_code in [200]:  # May fail if component doesn't support config changes
             accessed_endpoints.add(("POST", "/component_config_save"))
         else:
             print("ERROR: Unexpected response from /component_config_save: {} - {}".format(res.status_code, res.text))
@@ -274,9 +280,9 @@ def run_test_web_if(my_predbat):
         # Test /api/login POST
         print("Test POST /api/login")
         address = "http://127.0.0.1:5052/api/login"
-        data = {"username": "test", "password": "test"}
+        data = {"token": "invalid_token"}
         res = requests.post(address, json=data)
-        if res.status_code in [200, 401, 400]:  # Expect auth failure
+        if res.status_code in [200]:  # Expect auth failure
             accessed_endpoints.add(("POST", "/api/login"))
         else:
             print("ERROR: Unexpected response from /api/login: {} - {}".format(res.status_code, res.text))
diff --git a/apps/predbat/web.py b/apps/predbat/web.py
index 6ee7a256a..fb9ff650d 100644
--- a/apps/predbat/web.py
+++ b/apps/predbat/web.py
@@ -2960,7 +2960,7 @@ async def html_apps_post(self, request):
                     data = yaml.load(f)
             except Exception as e:
                 return web.json_response({"success": False, "message": f"Error reading apps.yaml: {str(e)}"})
-
+            
             # Navigate to the predbat section
             if ROOT_YAML_KEY not in data:
                 return web.json_response({"success": False, "message": "pred_bat section not found in apps.yaml"})
@@ -3411,7 +3411,9 @@ async def html_apps_editor_post(self, request):
         """
         try:
             postdata = await request.post()
-            apps_content = postdata.get("apps_content", "")
+            apps_content = postdata.get("apps_content", None)
+            if apps_content is None:
+                raise web.HTTPFound("./apps_editor?error=" + urllib.parse.quote("No content provided to save"))
 
             # Remove dos line endings
             apps_content = apps_content.replace("\r\n", "\n").replace("\r", "\n")
@@ -4147,6 +4149,9 @@ async def html_component_config_save(self, request):
                     data = yaml.load(f)
             except Exception as e:
                 return web.json_response({"success": False, "message": f"Error reading apps.yaml: {str(e)}"}, status=500)
+            
+            if not data:
+                data = {}
 
             if ROOT_YAML_KEY not in data:
                 return web.json_response({"success": False, "message": f"{ROOT_YAML_KEY} section not found in apps.yaml"}, status=500)

From 7427ec8fc7d8edc679abe9bb6539c215db0eba9e Mon Sep 17 00:00:00 2001
From: "pre-commit-ci-lite[bot]"
 <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Date: Sun, 8 Feb 2026 16:55:12 +0000
Subject: [PATCH 5/6] [pre-commit.ci lite] apply automatic fixes

---
 apps/predbat/web.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/predbat/web.py b/apps/predbat/web.py
index fb9ff650d..911438a41 100644
--- a/apps/predbat/web.py
+++ b/apps/predbat/web.py
@@ -2960,7 +2960,7 @@ async def html_apps_post(self, request):
                     data = yaml.load(f)
             except Exception as e:
                 return web.json_response({"success": False, "message": f"Error reading apps.yaml: {str(e)}"})
-            
+
             # Navigate to the predbat section
             if ROOT_YAML_KEY not in data:
                 return web.json_response({"success": False, "message": "pred_bat section not found in apps.yaml"})
@@ -4149,7 +4149,7 @@ async def html_component_config_save(self, request):
                     data = yaml.load(f)
             except Exception as e:
                 return web.json_response({"success": False, "message": f"Error reading apps.yaml: {str(e)}"}, status=500)
-            
+
             if not data:
                 data = {}
 

From 7b90f1e480e3dd609f6f8d297ca6b78783e45517 Mon Sep 17 00:00:00 2001
From: Trefor Southwell <48591903+springfall2008@users.noreply.github.com>
Date: Sun, 8 Feb 2026 17:05:32 +0000
Subject: [PATCH 6/6] Change external changes check interval to 5 seconds

---
 apps/predbat/web_helper.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/predbat/web_helper.py b/apps/predbat/web_helper.py
index 29c93b112..c75c7b096 100644
--- a/apps/predbat/web_helper.py
+++ b/apps/predbat/web_helper.py
@@ -5342,8 +5342,8 @@ def get_editor_js():
                 .catch(err => console.error('Error checking for external changes:', err));
         }
 
-        // Check every 2 seconds for external changes
-        setInterval(checkForExternalChanges, 2000);
+        // Check every 5 seconds for external changes
+        setInterval(checkForExternalChanges, 5000);
 
         // Initial lint after a short delay to ensure editor is fully loaded
         setTimeout(() => {