`cabal build` does not copy `install-includes` into the build directory

[hasufell]

In the installed wasm cross compiler:

$ _build/bindist/bin/wasm32-unknown-wasi-ghc-pkg field rts include-dirs
include-dirs: /home/hasufell/git/ghc/_build/bindist/lib/targets/wasm32-unknown-wasi/lib/../lib/wasm32-unknown-wasi/rts-1.0.3/include
$ ls /home/hasufell/git/ghc/_build/bindist/lib/targets/wasm32-unknown-wasi/lib/../lib/wasm32-unknown-wasi/rts-1.0.3/include
 DerivedConstants.h   ghcautoconf.h   ghcplatform.h   rts
$ ls /home/hasufell/git/ghc/_build/bindist/lib/targets/wasm32-unknown-wasi/lib/../lib/wasm32-unknown-wasi/rts-1.0.3/include/rts
 EventLogConstants.h   EventTypes.h

Snippet from rts.cabal:

library
    ghc-options: -this-unit-id rts -ghcversion-file=include/ghcversion.h -optc-DFS_NAMESPACE=rts
    cmm-options: -this-unit-id rts

    autogen-includes:
      ghcautoconf.h
      ghcplatform.h
      DerivedConstants.h
      rts/EventLogConstants.h
      rts/EventTypes.h

    install-includes:
      ghcautoconf.h
      ghcplatform.h
      DerivedConstants.h
      rts/EventLogConstants.h
      rts/EventTypes.h

    install-includes:
      -- Common headers for non-JS builds
      Cmm.h HsFFI.h MachDeps.h Jumps.h Rts.h RtsAPI.h RtsSymbols.h Stg.h
      ghcconfig.h ghcversion.h
      rts/ghc_ffi.h
      rts/Adjustor.h
      rts/ExecPage.h
      rts/BlockSignals.h
      rts/Config.h
      rts/Constants.h
      rts/EventLogFormat.h
      rts/EventLogWriter.h
      rts/FileLock.h
      rts/Flags.h
      rts/ForeignExports.h
      rts/GetTime.h
      rts/Globals.h
      rts/Hpc.h
      rts/IOInterface.h
      rts/Libdw.h
      rts/LibdwPool.h
      rts/Linker.h
      rts/Main.h
      rts/Messages.h
      rts/NonMoving.h
      rts/OSThreads.h
      rts/Parallel.h
      rts/PrimFloat.h
      rts/Profiling.h
      rts/IPE.h
      rts/PosixSource.h
      rts/Signals.h
      rts/SpinLock.h
      rts/StableName.h
      rts/StablePtr.h
      rts/StaticPtrTable.h
      rts/TTY.h
      rts/Threads.h
      rts/Ticky.h
      rts/Time.h
      rts/Timer.h
      rts/TSANUtils.h
      rts/Types.h
      rts/Utils.h
      rts/prof/CCS.h
      rts/prof/Heap.h
      rts/prof/LDV.h
      rts/storage/Block.h
      rts/storage/ClosureMacros.h
      rts/storage/Closures.h
      rts/storage/Heap.h
      rts/storage/HeapAlloc.h
      rts/storage/GC.h
      rts/storage/InfoTables.h
      rts/storage/MBlock.h
      rts/storage/TSO.h
      stg/DLL.h
      stg/MiscClosures.h
      stg/Prim.h
      stg/Regs.h
      stg/SMP.h
      stg/Ticky.h
      stg/Types.h

---

This causes issues when creating a bindist, because we're missing headers. We can't really use cabal install, because it's not made for that purpose and will cause many other issues.

[hasufell]

I think it should be safe to always copy the install-includes to the build directory during the build, e.g. somewhere here:

cabal/Cabal/src/Distribution/Simple/Build.hs

Lines 531 to 581 in 0a74ea1

	CLib lib -> do
	let libbi = libBuildInfo lib
	lib' =
	lib
	{ libBuildInfo =
	flip addExtraAsmSources extras $
	flip addExtraCmmSources extras $
	flip addExtraCxxSources extras $
	flip addExtraCSources extras $
	flip addExtraJsSources extras $
	libbi
	}
	buildLib flags numJobs pkg_descr lbi lib' clbi
	let oneComponentRequested (OneComponentRequestedSpec _) = True
	oneComponentRequested _ = False
	-- Don't register inplace if we're only building a single component;
	-- it's not necessary because there won't be any subsequent builds
	-- that need to tag us
	if (not (oneComponentRequested (componentEnabledSpec lbi)))
	then do
	-- Register the library in-place, so exes can depend
	-- on internally defined libraries.
	inplaceDir <- absoluteWorkingDirLBI lbi
	let
	-- The in place registration uses the "-inplace" suffix, not an ABI hash
	installedPkgInfo =
	inplaceInstalledPackageInfo
	inplaceDir
	distPref
	pkg_descr
	-- NB: Use a fake ABI hash to avoid
	-- needing to recompute it every build.
	(mkAbiHash "inplace")
	lib'
	lbi
	clbi
	debug verbosity $ "Registering inplace:\n" ++ (IPI.showInstalledPackageInfo installedPkgInfo)
	registerPackage
	verbosity
	(compiler lbi)
	(withPrograms lbi)
	(flagToMaybe $ buildWorkingDir flags)
	(withPackageDB lbi)
	installedPkgInfo
	HcPkg.defaultRegisterOptions
	{ HcPkg.registerMultiInstance = True
	}
	return (Just installedPkgInfo)
	else return Nothing

[hasufell]

Reported upstream: haskell#11172