From dfb7e2bb1a2cda82f4cb0b64629aab391ffb6b68 Mon Sep 17 00:00:00 2001 From: Glupo X <97174448+GlupoX@users.noreply.github.com> Date: Mon, 10 Jan 2022 09:20:22 +0000 Subject: [PATCH 1/3] Update README.md --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 25d4819..702f5f0 100644 --- a/README.md +++ b/README.md @@ -6,12 +6,12 @@ * ERC-721 smart contract * Adheres to strict [NFT provenance best-practices](https://link.medium.com/LJjFKB999lb) * SEO optimised responsive site -* Allows "lazy minting" (offer NFTs without pre-minting them; buyer pays gas to mint) +* Allows "lazy minting" (offer NFTs without pre-minting, buyer pays gas) * Shows links to Opensea & Rarible for secondary sales -* Re-assignable role for catalog management +* Re-assignable role for catalog management / minting * Configurable revenue shares -* Configurable royalty -* Deployable on any EVM blockchain (Ethereum, Polygon, Arbitrum, etc) +* Configurable royalty rate +* Deployable on any EVM blockchain (Ethereum, Polygon, Arbitrum, ...) See example deployments on these testnets: - [Ethereum (Rinkeby testnet)](https://nft-surface.vercel.app/) @@ -51,7 +51,7 @@ The repo currently has the details for these chains: * Polygon Testnet * Arbitrum Rinkeby Testnet -To add other chains, add their details in the following files, following the pattern for the already-implemented chains: +To support other chains, add their details in the following files, following the pattern for the already-implemented chains: ``` client/utils/chain-spec.js smart-contract/hardhat.config.js From 3e3f59fb15fd042f20cfffca69525af7de64c54f Mon Sep 17 00:00:00 2001 From: GlupoX Date: Mon, 10 Jan 2022 11:09:46 +0000 Subject: [PATCH 2/3] Config vars and comments --- smart-contract/README.md | 13 +++++++++---- smart-contract/hardhat.config.js | 8 +++++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/smart-contract/README.md b/smart-contract/README.md index 68fd496..771cda1 100644 --- a/smart-contract/README.md +++ b/smart-contract/README.md @@ -24,16 +24,21 @@ Expects the below `.env` file in the directory `smart-contract`. IMPORTANT: this ``` # For the "deploy" task, private key of the contract deployer, who is ideally also the creator (see below). For "catalog" or "sign" tasks following a deploy, private key of "agent" role. -SIGNER_PRIVATE_KEY = "... +SIGNER_PRIVATE_KEY = "..." # The address of the creator/artist/maker/brand. This is added to the catalog and the metadata files on IPFS. CREATOR_ADDRESS = "..." -# For Rinkeby network deployments +# Rinkeby network deployments RINKEBY_API_URL = "..." -# For Mainnet network deployments -MAINNET_API_URL = "..." +# Mumbai network deployments +MUMBAI_API_URL = "..." + +# Rinkeby network deployments +ARB_RINKEBY_API_URL = "..." + +# OTHER deployments: add variables here and modify hardhat.config.js to pick them up. # For verifying contracts on Etherscan (mainnets and testnets on Etherem/Polygon/...) ETHERSCAN_API_KEY = "..." diff --git a/smart-contract/hardhat.config.js b/smart-contract/hardhat.config.js index 2883518..68f52f6 100644 --- a/smart-contract/hardhat.config.js +++ b/smart-contract/hardhat.config.js @@ -7,9 +7,9 @@ require('@openzeppelin/hardhat-upgrades'); const { CREATOR_ADDRESS, SIGNER_PRIVATE_KEY, - RINKEBY_API_URL, - MUMBAI_API_URL, - ARB_RINKEBY_API_URL, + //RINKEBY_API_URL, + //MUMBAI_API_URL, + //ARB_RINKEBY_API_URL, ETHERSCAN_API_KEY, POLYGONSCAN_API_KEY, PINATA_API_KEY, @@ -23,6 +23,7 @@ module.exports = { defaultNetwork: "hardhat", networks: { hardhat: {}, + /* rinkeby: { url: RINKEBY_API_URL, accounts: [`0x${SIGNER_PRIVATE_KEY}`] @@ -37,6 +38,7 @@ module.exports = { url: ARB_RINKEBY_API_URL, accounts: [`0x${SIGNER_PRIVATE_KEY}`] } + */ }, etherscan: { apiKey: ETHERSCAN_API_KEY From 68d7f14bb840ebf53246c8016c39700f6dbab70a Mon Sep 17 00:00:00 2001 From: GlupoX Date: Mon, 10 Jan 2022 11:14:37 +0000 Subject: [PATCH 3/3] Config vars and comments --- smart-contract/README.md | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/smart-contract/README.md b/smart-contract/README.md index 771cda1..e76775e 100644 --- a/smart-contract/README.md +++ b/smart-contract/README.md @@ -27,18 +27,19 @@ Expects the below `.env` file in the directory `smart-contract`. IMPORTANT: this SIGNER_PRIVATE_KEY = "..." # The address of the creator/artist/maker/brand. This is added to the catalog and the metadata files on IPFS. -CREATOR_ADDRESS = "..." - -# Rinkeby network deployments -RINKEBY_API_URL = "..." - -# Mumbai network deployments -MUMBAI_API_URL = "..." - -# Rinkeby network deployments -ARB_RINKEBY_API_URL = "..." - -# OTHER deployments: add variables here and modify hardhat.config.js to pick them up. +CREATOR_ADDRESS = "..." + +# NETWORKS +# Be sure to uncomment (or add) relevant lines in hardhat.config.js +# depending on which network you are deploying to. +# Rinkeby deployments +RINKEBY_API_URL = "..." +# Mumbai deployments +MUMBAI_API_URL = "..." +# Rinkeby deployments +ARB_RINKEBY_API_URL = "..." +# OTHER deployments: +# add variables here and modify hardhat.config.js to pick them up. # For verifying contracts on Etherscan (mainnets and testnets on Etherem/Polygon/...) ETHERSCAN_API_KEY = "..."