Skip to content

eliminate sbem.interface by moving entities to more suitable locations #8

@szvsw

Description

@szvsw

sbem.interface currently is solely responsible for excel ingestion, and a stale library class.

I recommend we delete sbem.interface entirely, and relocate the excel ingestion methods to either (a) be colocated in sbem.prisma.connectors.py or (b) in a new sbem.connectors folder within a file called (something like) sbem/connectors/excel.py

The ComponentLibrary class can either be safely deleted after verifying that nothing is using it currently, or moved into its own module in the sbem.components folder called library. It's currently unused, but there's a world where we do use a global cache of namedobjects (soon to be NamedComponents! #6 ). See #9 for more discussion of a global cache/deduping

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions