From 304a057395010b69cf6f3c505940c5432e36ba99 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 4 Feb 2026 17:05:19 +0000 Subject: [PATCH 1/2] chore(deps): update dependency getsentry/sentry-cocoa to v9.4.0 --- Flinky.xcodeproj/project.pbxproj | 2 +- .../project.xcworkspace/xcshareddata/swiftpm/Package.resolved | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Flinky.xcodeproj/project.pbxproj b/Flinky.xcodeproj/project.pbxproj index 3680bb3..f253a62 100644 --- a/Flinky.xcodeproj/project.pbxproj +++ b/Flinky.xcodeproj/project.pbxproj @@ -1885,7 +1885,7 @@ repositoryURL = "https://github.com/getsentry/sentry-cocoa"; requirement = { kind = exactVersion; - version = 9.3.0; + version = 9.4.0; }; }; D4CFD1772E1E38F2001447E9 /* XCRemoteSwiftPackageReference "SFSafeSymbols" */ = { diff --git a/Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index c86c01e..8b3c3cd 100644 --- a/Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -15,8 +15,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/getsentry/sentry-cocoa", "state" : { - "revision" : "a24b98028b0b6e81bfd0526967468ba4ba60303c", - "version" : "9.3.0" + "revision" : "f1eefffd88cd6dfe5751159a3b32ff3c8e5b3b32", + "version" : "9.4.0" } }, { From 54418a60ddc3acb7f29ed4ef46210fa7b408dbda Mon Sep 17 00:00:00 2001 From: Philip Niedertscheider Date: Thu, 5 Feb 2026 10:55:22 +0100 Subject: [PATCH 2/2] remove unit for counter metrics --- .../Licenses.latest_result.txt | 4 +- .../Resources/Settings.bundle/Licenses.plist | 2 +- .../Sources/Utils/SentryMetricsHelper.swift | 56 +++---------------- .../Sources/ShareViewController.swift | 7 +-- 4 files changed, 13 insertions(+), 56 deletions(-) diff --git a/Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt b/Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt index 7871aaf..9855260 100644 --- a/Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt +++ b/Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt @@ -1,12 +1,12 @@ name: OnLaunch-iOS-Client, nameSpecified: OnLaunch-iOS-Client, owner: kula-app, version: 0.0.6, source: https://github.com/kula-app/OnLaunch-iOS-Client -name: sentry-cocoa, nameSpecified: Sentry, owner: getsentry, version: 9.3.0, source: https://github.com/getsentry/sentry-cocoa +name: sentry-cocoa, nameSpecified: Sentry, owner: getsentry, version: 9.4.0, source: https://github.com/getsentry/sentry-cocoa name: SFSafeSymbols, nameSpecified: SFSafeSymbols, owner: SFSafeSymbols, version: 7.0.0, source: https://github.com/SFSafeSymbols/SFSafeSymbols name: OnLaunch-iOS-Client, nameSpecified: OnLaunch-iOS-Client, owner: kula-app, version: 0.0.6, source: https://github.com/kula-app/OnLaunch-iOS-Client -name: sentry-cocoa, nameSpecified: Sentry, owner: getsentry, version: 9.3.0, source: https://github.com/getsentry/sentry-cocoa +name: sentry-cocoa, nameSpecified: Sentry, owner: getsentry, version: 9.4.0, source: https://github.com/getsentry/sentry-cocoa name: SFSafeSymbols, nameSpecified: SFSafeSymbols, owner: SFSafeSymbols, version: 7.0.0, source: https://github.com/SFSafeSymbols/SFSafeSymbols diff --git a/Targets/App/Sources/Resources/Settings.bundle/Licenses.plist b/Targets/App/Sources/Resources/Settings.bundle/Licenses.plist index 0a23c85..a050676 100644 --- a/Targets/App/Sources/Resources/Settings.bundle/Licenses.plist +++ b/Targets/App/Sources/Resources/Settings.bundle/Licenses.plist @@ -22,7 +22,7 @@ File Licenses/sentry-cocoa Title - Sentry (9.3.0) + Sentry (9.4.0) Type PSChildPaneSpecifier diff --git a/Targets/App/Sources/Utils/SentryMetricsHelper.swift b/Targets/App/Sources/Utils/SentryMetricsHelper.swift index 1475b00..5272f89 100644 --- a/Targets/App/Sources/Utils/SentryMetricsHelper.swift +++ b/Targets/App/Sources/Utils/SentryMetricsHelper.swift @@ -33,7 +33,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "memory.warning.received", value: 1, - unit: .generic("warning"), attributes: [ "cache_size_at_warning": String(cacheSizeAtWarning), "app_state": appState @@ -59,7 +58,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "device.thermal.transition", value: 1, - unit: .generic("transition"), attributes: [ "from_state": fromState, "to_state": toState, @@ -92,7 +90,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "network.reachability.changed", value: 1, - unit: .generic("transition"), attributes: [ "status": status, "interface": interfaceType, @@ -118,7 +115,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "app.state.transition", value: 1, - unit: .generic("transition"), attributes: [ "to_state": toState, "from_state": fromState @@ -138,7 +134,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "background.task.completed", value: 1, - unit: .generic("task"), attributes: [ "task_type": taskType, "task_identifier": taskIdentifier @@ -154,7 +149,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "background.task.expired", value: 1, - unit: .generic("task"), attributes: [ "task_type": taskType, "time_remaining": String(format: "%.1f", timeRemaining) @@ -190,7 +184,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.created", value: 1, - unit: .generic("link"), attributes: [ "creation_flow": creationFlow, "entity_type": "link", @@ -209,7 +202,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "list.created", value: 1, - unit: .generic("list"), attributes: [ "creation_flow": creationFlow, "entity_type": "list", @@ -228,7 +220,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.shared", value: 1, - unit: .generic("share"), attributes: [ "sharing_method": sharingMethod, "link_id": linkId @@ -242,7 +233,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.shared.nfc", value: 1, - unit: .generic("share"), attributes: [ "sharing_method": "nfc", "link_id": linkId @@ -261,7 +251,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: metricKey, value: 1, - unit: .generic("selection"), attributes: [ "color": color, "entity_type": entityType @@ -278,7 +267,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: metricKey, value: 1, - unit: .generic("selection"), attributes: [ "symbol": symbol, "entity_type": entityType @@ -293,7 +281,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "feedback.form.opened", value: 1, - unit: .generic("interaction") ) } @@ -301,8 +288,7 @@ enum SentryMetricsHelper { static func trackFeedbackFormClosed() { SentrySDK.metrics.count( key: "feedback.form.closed", - value: 1, - unit: .generic("interaction") + value: 1 ) } @@ -312,8 +298,7 @@ enum SentryMetricsHelper { static func trackDatabaseSeedingStarted() { SentrySDK.metrics.count( key: "database.seeding.started", - value: 1, - unit: .generic("operation") + value: 1 ) } @@ -321,8 +306,7 @@ enum SentryMetricsHelper { static func trackDatabaseSeedingCompleted() { SentrySDK.metrics.count( key: "database.seeding.completed", - value: 1, - unit: .generic("operation") + value: 1 ) } @@ -352,8 +336,7 @@ enum SentryMetricsHelper { static func trackQRCodeCacheHit() { SentrySDK.metrics.count( key: "qr_code.cache.hit", - value: 1, - unit: .generic("hit") + value: 1 ) } @@ -361,8 +344,7 @@ enum SentryMetricsHelper { static func trackQRCodeCacheMiss() { SentrySDK.metrics.count( key: "qr_code.cache.miss", - value: 1, - unit: .generic("miss") + value: 1 ) } @@ -372,7 +354,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "qr_code.cache.eviction", value: 1, - unit: .generic("eviction"), attributes: [ "reason": reason ] @@ -397,7 +378,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.metadata.fetched", value: 1, - unit: .generic("fetch"), attributes: [ "outcome": outcome, "has_image": String(hasImage), @@ -430,7 +410,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "error.rate", value: 1, - unit: .generic("error"), attributes: [ "error_type": errorType ] @@ -488,7 +467,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "search.performed", value: 1, - unit: .generic("search"), attributes: [ "search_context": searchContext, "result_count": String(resultCount) @@ -517,8 +495,7 @@ enum SentryMetricsHelper { static func trackListPinned() { SentrySDK.metrics.count( key: "list.pinned", - value: 1, - unit: .generic("action") + value: 1 ) } @@ -526,8 +503,7 @@ enum SentryMetricsHelper { static func trackListUnpinned() { SentrySDK.metrics.count( key: "list.unpinned", - value: 1, - unit: .generic("action") + value: 1 ) } @@ -537,7 +513,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "list.deleted", value: 1, - unit: .generic("deletion"), attributes: [ "link_count": String(linkCount) ] @@ -550,7 +525,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "list.deleted.bulk", value: 1, - unit: .generic("deletion"), attributes: [ "count": String(count) ] @@ -565,7 +539,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.deleted", value: 1, - unit: .generic("deletion"), attributes: [ "list_link_count": String(listLinkCount) ] @@ -580,7 +553,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.deleted.bulk", value: 1, - unit: .generic("deletion"), attributes: [ "count": String(count), "list_id": listId @@ -602,7 +574,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "link.opened", value: 1, - unit: .generic("interaction"), attributes: attributes ) } @@ -619,7 +590,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "share_extension.opened", value: 1, - unit: .generic("interaction"), attributes: attributes ) } @@ -632,7 +602,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "share_extension.completed", value: 1, - unit: .generic("completion"), attributes: [ "list_selected": String(listSelected), "name_edited": String(nameEdited) @@ -646,7 +615,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "share_extension.cancelled", value: 1, - unit: .generic("cancellation"), attributes: [ "step": step ] @@ -660,8 +628,7 @@ enum SentryMetricsHelper { static func trackNFCShareInitiated() { SentrySDK.metrics.count( key: "nfc.share.initiated", - value: 1, - unit: .generic("share") + value: 1 ) } @@ -669,8 +636,7 @@ enum SentryMetricsHelper { static func trackNFCShareSuccess() { SentrySDK.metrics.count( key: "nfc.share.success", - value: 1, - unit: .generic("share") + value: 1 ) } @@ -684,7 +650,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "nfc.share.failed", value: 1, - unit: .generic("share"), attributes: attributes ) } @@ -698,7 +663,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "nfc.operation.performed", value: 1, - unit: .generic("operation"), attributes: [ "operation": operation, "tag_type": tagType, @@ -754,7 +718,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "spotlight.item.indexed", value: UInt(count), - unit: .generic("item"), attributes: [ "content_type": contentType ] @@ -769,7 +732,6 @@ enum SentryMetricsHelper { SentrySDK.metrics.count( key: "spotlight.search.performed", value: 1, - unit: .generic("search"), attributes: [ "result_count_bucket": resultCountBucket, "query_source": querySource diff --git a/Targets/ShareExtension/Sources/ShareViewController.swift b/Targets/ShareExtension/Sources/ShareViewController.swift index af62809..a18e41f 100644 --- a/Targets/ShareExtension/Sources/ShareViewController.swift +++ b/Targets/ShareExtension/Sources/ShareViewController.swift @@ -72,8 +72,7 @@ class ShareViewController: SLComposeServiceViewController { // swiftlint:disable // Track share extension opened SentrySDK.metrics.count( key: "share_extension.opened", - value: 1, - unit: .generic("interaction") + value: 1 ) setupUI() @@ -247,7 +246,6 @@ class ShareViewController: SLComposeServiceViewController { // swiftlint:disable SentrySDK.metrics.count( key: "list.created", value: 1, - unit: .generic("list"), attributes: [ "list_id": defaultList.id.uuidString, "entity_type": "list", @@ -498,7 +496,6 @@ class ShareViewController: SLComposeServiceViewController { // swiftlint:disable SentrySDK.metrics.count( key: "link.created", value: 1, - unit: .generic("link"), attributes: [ "link_id": newLink.id.uuidString, "list_id": list.id.uuidString, @@ -511,7 +508,6 @@ class ShareViewController: SLComposeServiceViewController { // swiftlint:disable SentrySDK.metrics.count( key: "share_extension.completed", value: 1, - unit: .generic("completion"), attributes: [ "list_selected": wasListSelected, "name_edited": wasNameEdited @@ -564,7 +560,6 @@ class ShareViewController: SLComposeServiceViewController { // swiftlint:disable SentrySDK.metrics.count( key: "share_extension.cancelled", value: 1, - unit: .generic("cancellation"), attributes: [ "step": step ]