[Feature] Add a progress bar with ETA

[xkill]

Hi,

it will be great if it can display a progress with the ETA, so when scanning networks with several communities, we can know how long it will take to finish.

Thanks in advance

[woodruffw]

Hi @xkill!

Thanks for raising this feature request. We'd happily merge support for this from an external contributor.

[dguido]

Minimal Progress Bar Implementation Guide

I've analyzed the codebase and designed a progress bar implementation that matches onesixtyone's extremely tight, minimal coding style. Here's how to add this feature with ~40 lines of code.

Design Philosophy

• No external dependencies - just standard C libraries
• Carriage return based - simple terminal overwriting, no ncurses
• Respects existing modes - works with quiet/debug/log modes
• Minimal memory footprint - just a few extra variables

Implementation Plan

1. Add Progress Variables to Options Struct (onesixtyone.c:62)

struct {
  int debug;
  int log;
  int port;
  int print_ip;
  int quiet;
  long wait;
  FILE* log_fd;
  int progress;       // Add: enable progress bar (default 1)
} o;

2. Add Command Line Option (onesixtyone.c:281)

while ((arg = getopt(argc, argv, "c:di:o:p:s:w:qP")) != EOF) {
  // ... existing cases ...
  case 'P': o.progress = 0;  // -P disables progress bar
    break;

Update usage() at line 86:

printf("  -P                 disable progress bar\n");

Initialize in init_options() at line 274:

o.progress = 1;  // Enable by default

3. Add Progress Display Function (before main() at line 899)

void show_progress(int current, int total, struct timeval* start_time)
{
  struct timeval now;
  float percent, elapsed, rate, eta;
  int bar_width = 40;
  int filled;
  
  if (o.quiet || !o.progress || o.debug > 0)
    return;  // Don't show progress in quiet/debug modes
  
  gettimeofday(&now, NULL);
  elapsed = (now.tv_sec - start_time->tv_sec) + 
            (now.tv_usec - start_time->tv_usec) / 1000000.0;
  
  percent = (float)current / total * 100;
  rate = current / elapsed;  // packets per second
  eta = (total - current) / rate;
  
  filled = (int)(percent * bar_width / 100);
  
  printf("\r[");
  int i;
  for (i = 0; i < bar_width; i++) {
    if (i < filled) printf("=");
    else if (i == filled) printf(">");
    else printf(" ");
  }
  printf("] %.1f%% (%d/%d) ETA: %02d:%02d ", 
         percent, current, total, 
         (int)(eta/60), (int)eta%60);
  fflush(stdout);
  
  if (current == total) printf("\n");
}

4. Integrate Progress into Main Loop (onesixtyone.c:932)

if (!o.quiet) printf("Scanning %d hosts, %d communities\n", host_count, community_count);

struct timeval scan_start;
int total_packets = host_count * community_count;
int packets_sent = 0;
gettimeofday(&scan_start, NULL);

for (c = 0; c < community_count; c++) {
  if (o.debug > 0) printf("Trying community %s\n", community[c]);
  
  sendbuf_size = build_snmp_req((char*)&sendbuf, sizeof(sendbuf), community[c]);
  
  for (i = 0; i < host_count; i++) {
    remote_addr.sin_addr.s_addr = host[i].addr;
    if (o.debug > 1) printf("Sending to ip %s\n", inet_ntoa(*(struct in_addr*)&remote_addr.sin_addr.s_addr));
    
    ret = sendto(sock, &sendbuf, sendbuf_size, 0, (struct sockaddr*)&remote_addr, sizeof(remote_addr));
    if (ret < 0) {
      if (!o.quiet) printf("Error in sendto: %s\n", strerror(errno));
    }
    
    packets_sent++;
    show_progress(packets_sent, total_packets, &scan_start);  // ADD THIS
    
    receive_snmp(sock, o.wait, &remote_addr);
  }
}

Key Features

1. Smart Display Logic: Progress bar automatically disables when:

   • In quiet mode (-q)
   • In debug mode (-d)
   • Writing to log only
   • User explicitly disables with -P

2. Accurate ETA: Calculates based on actual packet rate, not theoretical

3. Clean Output: Uses carriage return to update in place, prints newline when done

4. No Terminal Detection: Works on any terminal that supports \r (virtually all)

Example Output

Scanning 254 hosts, 10 communities
[===================>                    ] 48.8% (1240/2540) ETA: 00:13

Why This Design?

• Matches onesixtyone's philosophy: Fast, minimal, no dependencies
• Non-intrusive: Doesn't interfere with core scanning logic
• Backward compatible: Can be disabled, respects all existing modes
• Clean integration: ~40 lines total, follows existing code patterns
• Performance neutral: Minimal overhead (one gettimeofday per packet)

Alternative: Even More Minimal (15 lines)

If you want ultra-minimal, just add percentage without ETA:

// In main loop after packets_sent++:
if (!o.quiet && !o.debug) {
  printf("\rProgress: %d/%d (%.1f%%)", packets_sent, total_packets, 
         (float)packets_sent/total_packets*100);
  fflush(stdout);
}
// After loop:
if (!o.quiet && !o.debug) printf("\n");

This implementation stays true to onesixtyone's ethos: do one thing well, with minimal code and maximum efficiency.