From 26460979555b45d88cb0238166b41f294639db77 Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 14:49:54 -0500 Subject: [PATCH 1/9] workflows: WIP lint Signed-off-by: William Woodruff --- .github/workflows/lint.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/workflows/lint.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 0000000..fc56e68 --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,13 @@ +name: Lint + +on: + push: + branches: + - master + pull_request: + +jobs: + lint: + uses: trailofbits/.github/.github/workflows/lint.yml@ww/reusable-demo + with: + type: rust From 539e9b81cdeb696a425917245cdd8ad2cc1ac23f Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 14:59:50 -0500 Subject: [PATCH 2/9] lint: fix check perms, add cargo-sort Signed-off-by: William Woodruff --- .github/workflows/lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index fc56e68..71dc44d 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,5 +9,8 @@ on: jobs: lint: uses: trailofbits/.github/.github/workflows/lint.yml@ww/reusable-demo + permissions: + checks: write with: type: rust + cargo-sort: true From 345d2c761c7fe024d96f5265382f04dba05ab820 Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:08:57 -0500 Subject: [PATCH 3/9] bump From 9a2f791ef2d776df74314cd05aecb6091e64ebd0 Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:14:25 -0500 Subject: [PATCH 4/9] bump From eaa05aa6b17d332a2b325629e1c0f38df524905b Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:22:55 -0500 Subject: [PATCH 5/9] bump From 6eaf1f0374c7cb9c60e659ef9cd6f6ad3a10ec2a Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:26:16 -0500 Subject: [PATCH 6/9] lint: doc ci: remove old lint Signed-off-by: William Woodruff --- .github/workflows/ci.yml | 10 +--------- .github/workflows/lint.yml | 1 + 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 616a462..511b554 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,15 +25,7 @@ jobs: - uses: actions/checkout@v2 - name: Format run: cargo fmt && git diff --exit-code - - name: Lint - run: | - rustup update - rustup component add clippy - cargo clippy -- -D warnings -D clippy::pedantic -D clippy::nursery -D clippy::expect_used -D clippy::panic -D clippy::unwrap_used - - name: Cargo sort - run: | - cargo install cargo-sort - cargo sort -c + test: runs-on: ubuntu-latest steps: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 71dc44d..3024bb1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -10,6 +10,7 @@ jobs: lint: uses: trailofbits/.github/.github/workflows/lint.yml@ww/reusable-demo permissions: + # Needed to render checks on the associated pull request. checks: write with: type: rust From 145bb697ac4e9905f2efd77e6d4f1cb47d4c334e Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:33:20 -0500 Subject: [PATCH 7/9] ci: remove remaining vestigial lint Signed-off-by: William Woodruff --- .github/workflows/ci.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 511b554..5a77b2b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,18 +14,6 @@ concurrency: cancel-in-progress: true jobs: - lint: - runs-on: ubuntu-latest - steps: - - name: Install LLVM - run: | - wget https://apt.llvm.org/llvm.sh - chmod +x llvm.sh - sudo ./llvm.sh 14 - - uses: actions/checkout@v2 - - name: Format - run: cargo fmt && git diff --exit-code - test: runs-on: ubuntu-latest steps: From eca43b63a673e1062ed76867022a3c1cf90321f6 Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Wed, 18 Jan 2023 15:34:02 -0500 Subject: [PATCH 8/9] workflows: rename ci -> tests Signed-off-by: William Woodruff --- .github/workflows/{ci.yml => tests.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{ci.yml => tests.yml} (100%) diff --git a/.github/workflows/ci.yml b/.github/workflows/tests.yml similarity index 100% rename from .github/workflows/ci.yml rename to .github/workflows/tests.yml From b8f9329cf8553e64083b7d88de48f55ed561d8ce Mon Sep 17 00:00:00 2001 From: William Woodruff Date: Thu, 19 Jan 2023 17:04:29 -0500 Subject: [PATCH 9/9] workflows/lint: drop permissions, bump No longer necessary? Signed-off-by: William Woodruff --- .github/workflows/lint.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3024bb1..fe4b307 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -8,10 +8,7 @@ on: jobs: lint: - uses: trailofbits/.github/.github/workflows/lint.yml@ww/reusable-demo - permissions: - # Needed to render checks on the associated pull request. - checks: write + uses: trailofbits/.github/.github/workflows/lint.yml@v0.0.2 with: type: rust cargo-sort: true