Skip to content

Commit 06322fd

Browse files
Cover additional unicode whitespace baseURL rejections
Co-authored-by: Eric Allam <eric@trigger.dev>
1 parent 2c7f40c commit 06322fd

File tree

3 files changed

+48
-0
lines changed

3 files changed

+48
-0
lines changed

docs/tasks/streams.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,9 @@ Examples:
687687
-`https://api.trigger.dev/\u200Binternal`
688688
-`https://api.trigger.dev/\u200Cinternal`
689689
-`https://api.trigger.dev/\u200Dinternal`
690+
-`https://api.trigger.dev/\u1680internal`
690691
-`https://api.trigger.dev/\u202Finternal`
692+
-`https://api.trigger.dev/\u3000internal`
691693
-`https://api.trigger.dev/\u2028internal`
692694
-`https://api.trigger.dev/\u2029internal`
693695
-`https://api.trigger.dev/\u2060internal`

packages/ai/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ Examples:
194194
-`https://api.trigger.dev/\u200Binternal` (internal zero-width-space characters)
195195
-`https://api.trigger.dev/\u200Cinternal` (internal zero-width-non-joiner characters)
196196
-`https://api.trigger.dev/\u200Dinternal` (internal zero-width-joiner characters)
197+
-`https://api.trigger.dev/\u1680internal` (internal ogham-space-mark characters)
197198
-`https://api.trigger.dev/\u202Finternal` (internal narrow no-break space characters)
199+
-`https://api.trigger.dev/\u3000internal` (internal ideographic-space characters)
198200
-`https://api.trigger.dev/\u2028internal` (internal line-separator characters)
199201
-`https://api.trigger.dev/\u2029internal` (internal paragraph-separator characters)
200202
-`https://api.trigger.dev/\u2060internal` (internal word-joiner characters)

packages/ai/src/chatTransport.test.ts

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,28 @@ describe("TriggerChatTransport", function () {
797797
}).toThrowError("baseURL must not contain internal whitespace characters");
798798
});
799799

800+
it("throws when baseURL contains internal ogham-space-mark characters", function () {
801+
expect(function () {
802+
new TriggerChatTransport({
803+
task: "chat-task",
804+
accessToken: "pk_trigger",
805+
baseURL: "https://api.trigger.dev/\u1680internal",
806+
stream: "chat-stream",
807+
});
808+
}).toThrowError("baseURL must not contain internal whitespace characters");
809+
});
810+
811+
it("throws when baseURL contains internal ideographic-space characters", function () {
812+
expect(function () {
813+
new TriggerChatTransport({
814+
task: "chat-task",
815+
accessToken: "pk_trigger",
816+
baseURL: "https://api.trigger.dev/\u3000internal",
817+
stream: "chat-stream",
818+
});
819+
}).toThrowError("baseURL must not contain internal whitespace characters");
820+
});
821+
800822
it("throws when baseURL contains internal line-separator characters", function () {
801823
expect(function () {
802824
new TriggerChatTransport({
@@ -3624,6 +3646,28 @@ describe("TriggerChatTransport", function () {
36243646
}).toThrowError("baseURL must not contain internal whitespace characters");
36253647
});
36263648

3649+
it("throws from factory when baseURL contains internal ogham-space-mark characters", function () {
3650+
expect(function () {
3651+
createTriggerChatTransport({
3652+
task: "chat-task",
3653+
accessToken: "pk_trigger",
3654+
baseURL: "https://api.trigger.dev/\u1680internal",
3655+
stream: "chat-stream",
3656+
});
3657+
}).toThrowError("baseURL must not contain internal whitespace characters");
3658+
});
3659+
3660+
it("throws from factory when baseURL contains internal ideographic-space characters", function () {
3661+
expect(function () {
3662+
createTriggerChatTransport({
3663+
task: "chat-task",
3664+
accessToken: "pk_trigger",
3665+
baseURL: "https://api.trigger.dev/\u3000internal",
3666+
stream: "chat-stream",
3667+
});
3668+
}).toThrowError("baseURL must not contain internal whitespace characters");
3669+
});
3670+
36273671
it("throws from factory when baseURL contains internal line-separator characters", function () {
36283672
expect(function () {
36293673
createTriggerChatTransport({

0 commit comments

Comments
 (0)