fix(webapp): remove deleted accounts from Loops marketing list (#3010)

When a user deletes their last organization, remove their contact from Loops
to prevent future marketing emails.

- Add deleteContact() using the correct Loops v1 endpoint (POST /api/v1/contacts/delete)
- Extract LoopsClient into a testable class (separate env singleton)
- Wire Loops deletion into the organization deletion flow
- Only trigger Loops removal when the user has no remaining organizations

Author: JosephDoUrden

apps/webapp/app/services/deleteOrganization.server.ts

@@ -3,7 +3,7 @@ import { PrismaClient } from "@trigger.dev/database";
 import { prisma } from "~/db.server";
 import { featuresForRequest } from "~/features.server";
 import { DeleteProjectService } from "./deleteProject.server";
-import { loopsClient } from "./loops.server";
+import { loopsClient } from "./loopsGlobal.server";
 import { getCurrentPlan } from "./platform.v3.server";
 
 export class DeleteOrganizationService {

apps/webapp/app/services/loops.server.ts

@@ -1,8 +1,16 @@
-import { env } from "~/env.server";
-import { logger } from "./logger.server";
+import { logger as defaultLogger } from "./logger.server";
 
-class LoopsClient {
-  constructor(private readonly apiKey: string) {}
+type Logger = Pick<typeof defaultLogger, "info" | "error">;
+
+export class LoopsClient {
+  #logger: Logger;
+
+  constructor(
+    private readonly apiKey: string,
+    logger: Logger = defaultLogger
+  ) {
+    this.#logger = logger;
+  }
 
   async userCreated({
     userId,
@@ -13,7 +21,7 @@ class LoopsClient {
     email: string;
     name: string | null;
   }) {
-    logger.info(`Loops send "sign-up" event`, { userId, email, name });
+    this.#logger.info(`Loops send "sign-up" event`, { userId, email, name });
     return this.#sendEvent({
       email,
       userId,
@@ -23,30 +31,41 @@ class LoopsClient {
   }
 
   async deleteContact({ email }: { email: string }): Promise<boolean> {
-    logger.info(`Loops deleting contact`, { email });
+    this.#logger.info(`Loops deleting contact`, { email });
 
     try {
-      const response = await fetch(
-        `https://app.loops.so/api/v1/contacts/${encodeURIComponent(email)}`,
-        {
-          method: "DELETE",
-          headers: { Authorization: `Bearer ${this.apiKey}` },
-        }
-      );
+      const response = await fetch("https://app.loops.so/api/v1/contacts/delete", {
+        method: "POST",
+        headers: {
+          Authorization: `Bearer ${this.apiKey}`,
+          "Content-Type": "application/json",
+        },
+        body: JSON.stringify({ email }),
+      });
 
       if (!response.ok) {
-        // 404 is okay - contact already deleted
-        if (response.status === 404) {
-          logger.info(`Loops contact already deleted`, { email });
+        this.#logger.error(`Loops deleteContact bad status`, { status: response.status, email });
+        return false;
+      }
+
+      const responseBody = (await response.json()) as { success: boolean; message?: string };
+
+      if (!responseBody.success) {
+        // "Contact not found" means already deleted - treat as success
+        if (responseBody.message === "Contact not found.") {
+          this.#logger.info(`Loops contact already deleted`, { email });
           return true;
         }
-        logger.error(`Loops deleteContact bad status`, { status: response.status, email });
+        this.#logger.error(`Loops deleteContact failed response`, {
+          message: responseBody.message,
+          email,
+        });
         return false;
       }
 
       return true;
     } catch (error) {
-      logger.error(`Loops deleteContact failed`, { error, email });
+      this.#logger.error(`Loops deleteContact failed`, { error, email });
       return false;
     }
   }
@@ -80,7 +99,7 @@ class LoopsClient {
       const response = await fetch("https://app.loops.so/api/v1/events/send", options);
 
       if (!response.ok) {
-        logger.error(`Loops sendEvent ${eventName} bad status`, {
+        this.#logger.error(`Loops sendEvent ${eventName} bad status`, {
           status: response.status,
           email,
           userId,
@@ -94,18 +113,16 @@ class LoopsClient {
       const responseBody = (await response.json()) as any;
 
       if (!responseBody.success) {
-        logger.error(`Loops sendEvent ${eventName} failed response`, {
+        this.#logger.error(`Loops sendEvent ${eventName} failed response`, {
           message: responseBody.message,
         });
         return false;
       }
 
       return true;
     } catch (error) {
-      logger.error(`Loops sendEvent ${eventName} failed`, { error });
+      this.#logger.error(`Loops sendEvent ${eventName} failed`, { error });
       return false;
     }
   }
 }
-
-export const loopsClient = env.LOOPS_API_KEY ? new LoopsClient(env.LOOPS_API_KEY) : null;

apps/webapp/app/services/loopsGlobal.server.ts

@@ -0,0 +1,4 @@
+import { env } from "~/env.server";
+import { LoopsClient } from "./loops.server";
+
+export const loopsClient = env.LOOPS_API_KEY ? new LoopsClient(env.LOOPS_API_KEY) : null;

apps/webapp/app/services/telemetry.server.ts

@@ -5,7 +5,7 @@ import type { Organization } from "~/models/organization.server";
 import type { Project } from "~/models/project.server";
 import type { User } from "~/models/user.server";
 import { singleton } from "~/utils/singleton";
-import { loopsClient } from "./loops.server";
+import { loopsClient } from "./loopsGlobal.server";
 
 type Options = {
   postHogApiKey?: string;

apps/webapp/test/loopsClient.test.ts

@@ -1,35 +1,11 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { LoopsClient } from "../app/services/loops.server";
 
-// We need to test the LoopsClient class directly, so we'll create a test instance
-// rather than importing the singleton (which depends on env vars)
-
-class LoopsClient {
-  constructor(private readonly apiKey: string) {}
-
-  async deleteContact({ email }: { email: string }): Promise<boolean> {
-    try {
-      const response = await fetch(
-        `https://app.loops.so/api/v1/contacts/${encodeURIComponent(email)}`,
-        {
-          method: "DELETE",
-          headers: { Authorization: `Bearer ${this.apiKey}` },
-        }
-      );
-
-      if (!response.ok) {
-        // 404 is okay - contact already deleted
-        if (response.status === 404) {
-          return true;
-        }
-        return false;
-      }
-
-      return true;
-    } catch (error) {
-      return false;
-    }
-  }
-}
+// No-op logger for tests
+const noopLogger = {
+  info: () => {},
+  error: () => {},
+};
 
 describe("LoopsClient", () => {
   const originalFetch = global.fetch;
@@ -45,32 +21,38 @@ describe("LoopsClient", () => {
   });
 
   describe("deleteContact", () => {
-    it("should return true on successful deletion (200)", async () => {
+    it("should return true on successful deletion", async () => {
       mockFetch.mockResolvedValueOnce({
         ok: true,
         status: 200,
+        json: async () => ({ success: true, message: "Contact deleted." }),
       });
 
-      const client = new LoopsClient("test-api-key");
+      const client = new LoopsClient("test-api-key", noopLogger);
       const result = await client.deleteContact({ email: "test@example.com" });
 
       expect(result).toBe(true);
       expect(mockFetch).toHaveBeenCalledWith(
-        "https://app.loops.so/api/v1/contacts/test%40example.com",
+        "https://app.loops.so/api/v1/contacts/delete",
         {
-          method: "DELETE",
-          headers: { Authorization: "Bearer test-api-key" },
+          method: "POST",
+          headers: {
+            Authorization: "Bearer test-api-key",
+            "Content-Type": "application/json",
+          },
+          body: JSON.stringify({ email: "test@example.com" }),
         }
       );
     });
 
-    it("should return true when contact already deleted (404)", async () => {
+    it("should return true when contact not found (already deleted)", async () => {
       mockFetch.mockResolvedValueOnce({
-        ok: false,
-        status: 404,
+        ok: true,
+        status: 200,
+        json: async () => ({ success: false, message: "Contact not found." }),
       });
 
-      const client = new LoopsClient("test-api-key");
+      const client = new LoopsClient("test-api-key", noopLogger);
       const result = await client.deleteContact({ email: "test@example.com" });
 
       expect(result).toBe(true);
@@ -82,7 +64,7 @@ describe("LoopsClient", () => {
         status: 500,
       });
 
-      const client = new LoopsClient("test-api-key");
+      const client = new LoopsClient("test-api-key", noopLogger);
       const result = await client.deleteContact({ email: "test@example.com" });
 
       expect(result).toBe(false);
@@ -94,7 +76,7 @@ describe("LoopsClient", () => {
         status: 401,
       });
 
-      const client = new LoopsClient("test-api-key");
+      const client = new LoopsClient("test-api-key", noopLogger);
       const result = await client.deleteContact({ email: "test@example.com" });
 
       expect(result).toBe(false);
@@ -103,25 +85,23 @@ describe("LoopsClient", () => {
     it("should return false on network error", async () => {
       mockFetch.mockRejectedValueOnce(new Error("Network error"));
 
-      const client = new LoopsClient("test-api-key");
+      const client = new LoopsClient("test-api-key", noopLogger);
       const result = await client.deleteContact({ email: "test@example.com" });
 
       expect(result).toBe(false);
     });
 
-    it("should properly encode email addresses with special characters", async () => {
+    it("should return false on other failure responses", async () => {
       mockFetch.mockResolvedValueOnce({
         ok: true,
         status: 200,
+        json: async () => ({ success: false, message: "Some other error" }),
       });
 
-      const client = new LoopsClient("test-api-key");
-      await client.deleteContact({ email: "test+alias@example.com" });
+      const client = new LoopsClient("test-api-key", noopLogger);
+      const result = await client.deleteContact({ email: "test@example.com" });
 
-      expect(mockFetch).toHaveBeenCalledWith(
-        "https://app.loops.so/api/v1/contacts/test%2Balias%40example.com",
-        expect.any(Object)
-      );
+      expect(result).toBe(false);
     });
   });
 });