Skip to content

Commit 79f8cde

Browse files
authored
Fix(webapp): logs button + logs table row link fix (#3107)
Small fixes and improvements to the logs page: - Clicking the Run ID didn't open inspector - Swapped the "open link in tab" icon with Runs icon - Prevent tooltip hovering on Level info <img width="350" height="206" alt="CleanShot 2026-02-20 at 10 00 37@2x" src="https://github.com/user-attachments/assets/3e82f24a-c0a1-4c01-a8e9-9e06a8af982a" />
1 parent 98bf706 commit 79f8cde

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

apps/webapp/app/components/logs/LogDetailView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ function DetailsTab({
186186
<CopyableText value={log.runId} copyValue={log.runId} asChild />
187187
<LinkButton
188188
to={runPath}
189-
variant="tertiary/small"
189+
variant="secondary/small"
190190
shortcut={{ key: "v" }}
191191
className="mt-2"
192192
>

apps/webapp/app/components/logs/LogsTable.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
TableRow,
2727
type TableVariant,
2828
} from "../primitives/Table";
29+
import { RunsIcon } from "~/assets/icons/RunsIcon";
2930

3031
type LogsTableProps = {
3132
logs: LogEntry[];
@@ -124,6 +125,7 @@ export function LogsTable({
124125
<TableHeaderCell
125126
className="min-w-24 whitespace-nowrap"
126127
tooltip={<LogLevelTooltipInfo />}
128+
disableTooltipHoverableContent
127129
>
128130
Level
129131
</TableHeaderCell>
@@ -165,7 +167,7 @@ export function LogsTable({
165167
>
166168
<DateTimeAccurate date={log.triggeredTimestamp} hour12={false} />
167169
</TableCell>
168-
<TableCell className="min-w-24">
170+
<TableCell className="min-w-24" onClick={handleRowClick} hasAction>
169171
<TruncatedCopyableValue value={log.runId} />
170172
</TableCell>
171173
<TableCell className="min-w-32" onClick={handleRowClick} hasAction>
@@ -185,9 +187,11 @@ export function LogsTable({
185187
<LinkButton
186188
to={runPath}
187189
variant="minimal/small"
188-
TrailingIcon={ArrowTopRightOnSquareIcon}
190+
TrailingIcon={RunsIcon}
191+
trailingIconClassName="text-text-bright"
192+
className="h-[1.375rem] pl-1.5 pr-2"
189193
>
190-
View run
194+
<span className="text-[0.6875rem] text-text-bright">View run</span>
191195
</LinkButton>
192196
}
193197
/>

apps/webapp/app/components/primitives/Table.tsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,22 @@ type TableCellBasicProps = {
176176
type TableHeaderCellProps = TableCellBasicProps & {
177177
hiddenLabel?: boolean;
178178
tooltip?: ReactNode;
179+
disableTooltipHoverableContent?: boolean;
179180
};
180181

181182
export const TableHeaderCell = forwardRef<HTMLTableCellElement, TableHeaderCellProps>(
182-
({ className, alignment = "left", children, colSpan, hiddenLabel = false, tooltip }, ref) => {
183+
(
184+
{
185+
className,
186+
alignment = "left",
187+
children,
188+
colSpan,
189+
hiddenLabel = false,
190+
tooltip,
191+
disableTooltipHoverableContent = false,
192+
},
193+
ref
194+
) => {
183195
const { variant } = useContext(TableContext);
184196
let alignmentClassName = "text-left";
185197
switch (alignment) {
@@ -222,6 +234,7 @@ export const TableHeaderCell = forwardRef<HTMLTableCellElement, TableHeaderCellP
222234
content={tooltip}
223235
contentClassName="normal-case tracking-normal"
224236
enabled={isHovered}
237+
disableHoverableContent={disableTooltipHoverableContent}
225238
/>
226239
</div>
227240
) : (

0 commit comments

Comments
 (0)