Skip to content

Commit a9fd293

Browse files
Cover additional empty-after-trim unicode wrapper baseURLs
Co-authored-by: Eric Allam <eric@trigger.dev>
1 parent ae87637 commit a9fd293

File tree

3 files changed

+48
-0
lines changed

3 files changed

+48
-0
lines changed

docs/tasks/streams.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -685,6 +685,8 @@ Examples:
685685
-`ftp://api.trigger.dev`
686686
-`ws://api.trigger.dev` / `wss://api.trigger.dev`
687687
-`\u1680///\u1680` (empty after trimming wrapper whitespace)
688+
-`\u2007///\u2007` (empty after trimming wrapper whitespace)
689+
-`\u205F///\u205F` (empty after trimming wrapper whitespace)
688690
-`\u3000///\u3000` (empty after trimming wrapper whitespace)
689691
-`https://api.trigger.dev/\ninternal`
690692
-`https://api.trigger.dev/in valid`

packages/ai/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,8 @@ Examples:
192192
-`ftp://api.trigger.dev` (non-http protocol)
193193
-`ws://api.trigger.dev` / `wss://api.trigger.dev` (websocket protocols are rejected)
194194
-`\u1680///\u1680` (empty after trimming wrapper whitespace)
195+
-`\u2007///\u2007` (empty after trimming wrapper whitespace)
196+
-`\u205F///\u205F` (empty after trimming wrapper whitespace)
195197
-`\u3000///\u3000` (empty after trimming wrapper whitespace)
196198
-`https://api.trigger.dev/\ninternal` (internal whitespace characters)
197199
-`https://api.trigger.dev/in valid` (internal space characters)

packages/ai/src/chatTransport.test.ts

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,28 @@ describe("TriggerChatTransport", function () {
721721
}).toThrowError("baseURL must not be empty");
722722
});
723723

724+
it("throws when baseURL is empty after trimming figure-space wrappers", function () {
725+
expect(function () {
726+
new TriggerChatTransport({
727+
task: "chat-task",
728+
accessToken: "pk_trigger",
729+
baseURL: "\u2007///\u2007",
730+
stream: "chat-stream",
731+
});
732+
}).toThrowError("baseURL must not be empty");
733+
});
734+
735+
it("throws when baseURL is empty after trimming medium-mathematical-space wrappers", function () {
736+
expect(function () {
737+
new TriggerChatTransport({
738+
task: "chat-task",
739+
accessToken: "pk_trigger",
740+
baseURL: "\u205F///\u205F",
741+
stream: "chat-stream",
742+
});
743+
}).toThrowError("baseURL must not be empty");
744+
});
745+
724746
it("uses default baseURL when omitted", function () {
725747
expect(function () {
726748
new TriggerChatTransport({
@@ -3669,6 +3691,28 @@ describe("TriggerChatTransport", function () {
36693691
}).toThrowError("baseURL must not be empty");
36703692
});
36713693

3694+
it("throws from factory when baseURL is empty after trimming figure-space wrappers", function () {
3695+
expect(function () {
3696+
createTriggerChatTransport({
3697+
task: "chat-task",
3698+
accessToken: "pk_trigger",
3699+
baseURL: "\u2007///\u2007",
3700+
stream: "chat-stream",
3701+
});
3702+
}).toThrowError("baseURL must not be empty");
3703+
});
3704+
3705+
it("throws from factory when baseURL is empty after trimming medium-mathematical-space wrappers", function () {
3706+
expect(function () {
3707+
createTriggerChatTransport({
3708+
task: "chat-task",
3709+
accessToken: "pk_trigger",
3710+
baseURL: "\u205F///\u205F",
3711+
stream: "chat-stream",
3712+
});
3713+
}).toThrowError("baseURL must not be empty");
3714+
});
3715+
36723716
it("uses default baseURL in factory when omitted", function () {
36733717
expect(function () {
36743718
createTriggerChatTransport({

0 commit comments

Comments
 (0)