Skip to content

Commit b3bd45c

Browse files
Cover vertical-tab baseURL whitespace validation
Co-authored-by: Eric Allam <eric@trigger.dev>
1 parent dec91eb commit b3bd45c

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

docs/tasks/streams.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,7 @@ Examples:
676676
-`ws://api.trigger.dev` / `wss://api.trigger.dev`
677677
-`https://api.trigger.dev/\ninternal`
678678
-`https://api.trigger.dev/\tinternal`
679+
-`https://api.trigger.dev/\vinternal`
679680
-`https://api.trigger.dev/\rinternal`
680681
-`https://api.trigger.dev/\u200Binternal`
681682
-`https://api.trigger.dev/\uFEFFinternal`

packages/ai/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ Examples:
183183
-`ws://api.trigger.dev` / `wss://api.trigger.dev` (websocket protocols are rejected)
184184
-`https://api.trigger.dev/\ninternal` (internal whitespace characters)
185185
-`https://api.trigger.dev/\tinternal` (internal tab characters)
186+
-`https://api.trigger.dev/\vinternal` (internal vertical-tab characters)
186187
-`https://api.trigger.dev/\rinternal` (internal carriage-return characters)
187188
-`https://api.trigger.dev/\u200Binternal` (internal zero-width-space characters)
188189
-`https://api.trigger.dev/\uFEFFinternal` (internal BOM characters)

packages/ai/src/chatTransport.test.ts

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,17 @@ describe("TriggerChatTransport", function () {
742742
}).toThrowError("baseURL must not contain internal whitespace characters");
743743
});
744744

745+
it("throws when baseURL contains internal vertical-tab characters", function () {
746+
expect(function () {
747+
new TriggerChatTransport({
748+
task: "chat-task",
749+
accessToken: "pk_trigger",
750+
baseURL: "https://api.trigger.dev/\vinternal",
751+
stream: "chat-stream",
752+
});
753+
}).toThrowError("baseURL must not contain internal whitespace characters");
754+
});
755+
745756
it("throws when baseURL contains internal carriage-return characters", function () {
746757
expect(function () {
747758
new TriggerChatTransport({
@@ -3393,6 +3404,17 @@ describe("TriggerChatTransport", function () {
33933404
}).toThrowError("baseURL must not contain internal whitespace characters");
33943405
});
33953406

3407+
it("throws from factory when baseURL contains internal vertical-tab characters", function () {
3408+
expect(function () {
3409+
createTriggerChatTransport({
3410+
task: "chat-task",
3411+
accessToken: "pk_trigger",
3412+
baseURL: "https://api.trigger.dev/\vinternal",
3413+
stream: "chat-stream",
3414+
});
3415+
}).toThrowError("baseURL must not contain internal whitespace characters");
3416+
});
3417+
33963418
it("throws from factory when baseURL contains internal carriage-return characters", function () {
33973419
expect(function () {
33983420
createTriggerChatTransport({

0 commit comments

Comments
 (0)