refactor(tests): consolidate wizard tests into modular structure#33
Merged
refactor(tests): consolidate wizard tests into modular structure#33
Conversation
Moved all tests from tests/unit/test_config_wizard.py into tests/unit/wizard/test_wizard.py to maintain a cleaner, more modular test structure. Changes: - Deleted tests/unit/test_config_wizard.py (262 lines, 5 tests) - Added to tests/unit/wizard/test_wizard.py (290 lines, 5 tests) - TestConfigModelWithLLMProviders (3 tests) - TestConfigureOllamaEndpointModelPairing (2 tests) - Updated specs/003-setup-wizard/tasks.md to reflect new test location Test Coverage Preserved: - All 5 tests from test_config_wizard.py successfully migrated - All 197 wizard-related tests pass (57 unit + 140 integration) - No test coverage lost in consolidation Rationale: - Reduces test file fragmentation - Maintains clean separation: unit tests in wizard/, integration in integration/ - Groups related wizard orchestration tests together - Keeps modular structure for validators, prompts, providers Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 48 48
Lines 5083 5083
=======================================
Hits 4301 4301
Misses 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all tests from tests/unit/test_config_wizard.py into tests/unit/wizard/test_wizard.py to maintain a cleaner, more modular test structure.
Changes:
Test Coverage Preserved:
Rationale:
Assisted-by: Claude Code