Skip to content

Fix stop/0 functions calling gen_server:call on supervisors #46

@oubiwann

Description

@oubiwann

Problem

The stop/0 functions in underack.supervisor and underack.busboard call gen_server:call on supervisor processes. Supervisors are not gen_servers, so these calls will fail.

Current Code

In src/underack/supervisor.lfe:

(defun stop ()
  (gen_server:call (SERVER) 'stop))

In src/underack/busboard.lfe:

(defun stop ()
  (gen_server:call (SERVER) 'stop))

Suggested Fix

Either:

  1. Remove these functions and let application shutdown handle supervisor termination
  2. Use appropriate supervisor API calls
  3. If explicit stop is needed, consider supervisor:terminate_child/2 or sending a shutdown signal

Files

  • src/underack/supervisor.lfe
  • src/underack/busboard.lfe

Priority

P0 - These functions will crash when called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions