Incorrect file selection for tarball of PART1

[cbassa]

The tarball containing the filterbank file for PART1 also includes partial filterbank files for PART10 to PART19. see the contents of this tarball.

[bassa@lexar004 /data/projects/TMSS-validation/L2002361/pulp/cs]$ tar -tvf L2002361_SAP000_B000_P001_bf.tar
-rw-rw-r-- lofarsys/lofarsys 983427 2022-04-28 10:41 rawvoltages/SAP0/BEAM0/L2002360_SAP000_B000_S3_P001_bf.h5
-rw-rw-r-- lofarsys/lofarsys 983427 2022-04-28 10:41 rawvoltages/SAP0/BEAM0/L2002360_SAP000_B000_S1_P001_bf.h5
-rw-rw-r-- lofarsys/lofarsys 983427 2022-04-28 10:41 rawvoltages/SAP0/BEAM0/L2002360_SAP000_B000_S2_P001_bf.h5
-rw-rw-r-- lofarsys/lofarsys 983427 2022-04-28 10:41 rawvoltages/SAP0/BEAM0/L2002360_SAP000_B000_S0_P001_bf.h5
-rw-rw---- lofarsys/lofarsys 184549793 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART19.fil
-rw-rw---- lofarsys/lofarsys 209715553 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART10.fil
-rw-rw---- lofarsys/lofarsys 276824673 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART15.fil
-rw-rw---- lofarsys/lofarsys 201327073 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART12.fil
-rw-rw---- lofarsys/lofarsys 201327073 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART16.fil
-rw-rw---- lofarsys/lofarsys 292946273 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART1.fil
-rw-rw---- lofarsys/lofarsys 192938593 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART18.fil
-rw-rw---- lofarsys/lofarsys 159384033 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART11.fil
-rw-rw---- lofarsys/lofarsys 285213153 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART17.fil
-rw-rw---- lofarsys/lofarsys 159384033 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART14.fil
-rw-rw---- lofarsys/lofarsys 184549793 2022-04-28 10:43 rawvoltages/SAP0/BEAM0/B9999+99_L2002360_SAP0_BEAM0_PART13.fil
-rw-rw-r-- lofarsys/lofarsys      1089 2022-04-28 10:42 9999+99.par

This behavior is caused by this if statement:

pulp/pulp_pipeunit.py

Line 1128 in 02137c5

if "_PART%d" % (self.part) in tfbase: return True

as it will return True for both PART1 as well as PART10 etc.

A solution would be to use if "_PART%d.fil" % (self.part) in tfbase: return True instead, though this assumes this function only works for filterbank files. Another solution would be to enforce 2 or 3 digit parts with leading zeros, but this may break backwards compatibility.