From 84c86cb518bc9f8e1106a54b598218701212462b Mon Sep 17 00:00:00 2001 From: shine <4771718+shinenelson@users.noreply.github.com> Date: Sat, 10 Apr 2021 20:29:43 +0530 Subject: [PATCH 1/5] stop opening options_ui in new tab --- src/manifest.firefox.json | 3 +-- src/manifest.json | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/manifest.firefox.json b/src/manifest.firefox.json index 70ea8c8..61d2196 100644 --- a/src/manifest.firefox.json +++ b/src/manifest.firefox.json @@ -18,8 +18,7 @@ }], "options_ui": { - "page": "options.html", - "open_in_tab": true + "page": "options.html" }, "permissions": [ diff --git a/src/manifest.json b/src/manifest.json index a4e7d28..79f87ce 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -11,8 +11,7 @@ }], "options_ui": { - "page": "options.html", - "open_in_tab": true + "page": "options.html" }, "permissions": [ From 93185c0bc38dfe656174a52c74cad9673ee7d0e2 Mon Sep 17 00:00:00 2001 From: shine <4771718+shinenelson@users.noreply.github.com> Date: Sat, 10 Apr 2021 20:25:26 +0530 Subject: [PATCH 2/5] remove logo and header since we are already in the context of the extension and the logo and title of the extension would already be in view. the logo and header within the `options_ui` would only make it redundant. --- src/css/options.css | 24 ------------------------ src/options.html | 3 --- 2 files changed, 27 deletions(-) diff --git a/src/css/options.css b/src/css/options.css index 86b388f..9f5c5ef 100644 --- a/src/css/options.css +++ b/src/css/options.css @@ -14,30 +14,6 @@ body { box-shadow: 0px 0px 10px #DDD; } -#logo { - margin: -5px 10px -5px 0; - width: 32px; - float: left; -} - -h1 { - color: #333; - font-size: 1.5em; - margin: 0.7em 0 0; -} - -#header { - background: linear-gradient(white, #EEE); - padding: 15px 0px 10px 10px; - height: 30px; - border-bottom: 1px solid #DDD; - margin: -12px -12px 20px -12px; - border-top-left-radius: 10px; - border-top-right-radius: 10px; - text-shadow: 1px 1px 1px white; - color: #666; -} - p { font-size: 12px; } diff --git a/src/options.html b/src/options.html index 59d26af..a64542e 100644 --- a/src/options.html +++ b/src/options.html @@ -8,9 +8,6 @@
- -

GitHub Contribution Color Graph Options

-

Choose graph color

@@ -44,7 +43,6 @@ -

From a8d6ec345f0d0d8ef1143000d764b22fef5a1adc Mon Sep 17 00:00:00 2001 From: shine <4771718+shinenelson@users.noreply.github.com> Date: Sun, 11 Apr 2021 02:38:15 +0530 Subject: [PATCH 4/5] use browser-style for options_ui elements we use both ` +