Skip to content

Why bother with PRs for usermods #5318

@blazoncek

Description

@blazoncek

Since usermods were converted to libraries (and can be included from any repository using lib_deps) is there any reason to keep PRs for usermods? Do you intend to merge and then maintain such usermods? Is there a plan for what to do with usermods that no longer work or compile or were abandoned?

I would suggest to keep just a list of all available repositories with usermods instead of bothering to test and "maintain" usermods included with WLED.

Instead I'd encourage users interested in WLED featuring their usermod to submit a change to lib_deps in platformio_override.ini sample. Rather than a PR wit usermod.

There is, however, a downside to such listing: endorsing an unverified and potentially malicious usermod.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions