From 1957ed724b3ede4b5d9d2e1e5e68ca1fb9059bd4 Mon Sep 17 00:00:00 2001 From: Massimo D'isidoro <49653612+massimodisidoro@users.noreply.github.com> Date: Sat, 31 Jan 2026 02:37:49 +0100 Subject: [PATCH 1/4] Fix mismatch between Timeserie write FMT and actual variable list in WRITE statement (#2265) TYPE: bug fix KEYWORDS: time series, TS, format, write, wrf solar, solar_diagnostics SOURCE: Massimo D'Isidoro (ENEA - Italian National Agency for New Technologies, Energy and Sustainable Economic Development) DESCRIPTION OF CHANGES: Problem: When solar diagnostics is activated in namelist.input, the WRF time series output WRITE statement lists 55 variables but the Fortran FMT only specifies 54 fields. This causes the last variable (ts_swddnic2) to be written in a separate record in the output files *.TS , leading to inconsistent time series data. Solution: The WRITE statement FMT has been corrected to match all 55 variables, ensuring that they are written on the same record in the TS file. ISSUE: This fixes part of issue #2255 LIST OF MODIFIED FILES: M share/wrf_timeseries.F TESTS CONDUCTED: 1. A WRF run with solar_diagnostics activated, compared to previous version to confirm the fix. 2. The regression tests have passed. RELEASE NOTE: Corrected a bug in the WRF time series output, when solar_diagnostics is activated, where the last variable (ts_swddnic2) was written in a separate record. TS files now correctly includes all the 55 variables on the same record. --- share/wrf_timeseries.F | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/wrf_timeseries.F b/share/wrf_timeseries.F index 53ccb27d1f..3aa9f77317 100644 --- a/share/wrf_timeseries.F +++ b/share/wrf_timeseries.F @@ -907,7 +907,7 @@ SUBROUTINE write_ts( grid ) grid%ts_clw(n,i) ELSE !!! WRF-Solar diagnostics - WRITE(UNIT=iunit,FMT='(i2,f13.6,i5,i5,i5,1x,49(f13.5,1x))') & + WRITE(UNIT=iunit,FMT='(i2,f13.6,i5,i5,i5,1x,50(f13.5,1x))') & grid%id, grid%ts_hour(n,i), & grid%id_tsloc(i), ix, iy, & grid%ts_t(n,i), & From f15568ccc1447780e3bd664b9f0196edd784bf33 Mon Sep 17 00:00:00 2001 From: Yuxuan Xie <77427610+cug-xyx@users.noreply.github.com> Date: Thu, 5 Feb 2026 10:16:19 +0800 Subject: [PATCH 2/4] Fix typo in comment (#2280) TYPE: text only KEYWORDS: WRF, diagnostics, WetBulbTemp, unit label, dewpoint, documentation SOURCE: Yuxuan Xie (IGSNRR, CAS) DESCRIPTION OF CHANGES: Problem: The WetBulbTemp utility variable tdC was documented with the wrong unit (K) in a comment, inconsistent with its Celsius usage. Solution: Update the unit in the comment to C in phys/module_diag_functions.F. LIST OF MODIFIED FILES: M phys/module_diag_functions.F RELEASE NOTE: Corrected the WetBulbTemp dewpoint temperature unit label to Celsius in comments. --- phys/module_diag_functions.F | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phys/module_diag_functions.F b/phys/module_diag_functions.F index 0466dff45f..9fc9de5b3e 100644 --- a/phys/module_diag_functions.F +++ b/phys/module_diag_functions.F @@ -1166,7 +1166,7 @@ FUNCTION WetBulbTemp ( p, tK, rh) result( wbt ) ! ----------------- real :: tdK !~ Dewpoint temperature ( K ) real :: tC !~ Temperature ( C ) - real :: tdC !~ Dewpoint temperature ( K ) + real :: tdC !~ Dewpoint temperature ( C ) real :: svapr !~ Saturation vapor pressure ( Pa ) real :: vapr !~ Ambient vapor pressure ( Pa ) real :: gamma !~ Dummy term From 87a9d7c4a77b09c3357da3af26f741a265017585 Mon Sep 17 00:00:00 2001 From: "Dr. Andrew SONG" <657276109@qq.com> Date: Fri, 27 Feb 2026 16:58:29 +0800 Subject: [PATCH 3/4] Fix typo in README.namelist Fix typo(Xiananjiang to Xinanjiang) --- run/README.namelist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run/README.namelist b/run/README.namelist index 4ce895b539..759b1a8d1e 100644 --- a/run/README.namelist +++ b/run/README.namelist @@ -1318,7 +1318,7 @@ Options for use with the Noah-MP Land Surface Model (sf_surface_physics=4): 5 = Miguez-Macho & Fan groundwater scheme (Miguez-Macho et al. 2007 JGR; Fan et al. 2007 JGR) geogrid must have been run with GEOGRID.TBL.ARW.noahmp, use with caution 6 = Variable Infiltration Capacity Model surface runoff scheme (Wood et al., 1992, JGR) - 7 = Xiananjiang Infiltration and surface runoff scheme ((Jayawardena and Zhou, 2000) + 7 = Xinanjiang Infiltration and surface runoff scheme ((Jayawardena and Zhou, 2000) 8 = Dynamic VIC surface runoff scheme (Liang and Xie, 2001) opt_infdv = 0, ! Noah-MP infiltration option in dynamic VIC runoff scheme (only works for opt_run=8) 1 = Philip scheme From 7d7cefae1c040558da1bae620ee89f1f2c437d0d Mon Sep 17 00:00:00 2001 From: "Dr. Andrew SONG" <657276109@qq.com> Date: Fri, 27 Feb 2026 17:11:25 +0800 Subject: [PATCH 4/4] Fix typo in Registry.EM_COMMON Fix typo(Xiananjiang to Xinanjiang) --- Registry/Registry.EM_COMMON | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Registry/Registry.EM_COMMON b/Registry/Registry.EM_COMMON index 4d133c9bfa..ab6c7b2afa 100644 --- a/Registry/Registry.EM_COMMON +++ b/Registry/Registry.EM_COMMON @@ -2683,7 +2683,7 @@ rconfig integer madwrf_cldinit namelist,physics 1 rconfig integer dveg namelist,noah_mp 1 4 h "dveg" "dynamic vegetation (1 -> off ; 2 -> on)" "" rconfig integer opt_crs namelist,noah_mp 1 1 h "opt_crs" "canopy stomatal resistance (1-> Ball-Berry; 2->Jarvis)" "" rconfig integer opt_btr namelist,noah_mp 1 1 h "opt_btr" "soil moisture factor for stomatal resistance (1-> Noah; 2-> CLM; 3-> SSiB)" "" -rconfig integer opt_run namelist,noah_mp 1 3 h "opt_run" "runoff and groundwater (1->SIMGM; 2->SIMTOP; 3->Schaake96; 4->BATS; 5->Miguez-Macho & Fan; 6->VIC; 7->Xiananjiang; 8->Dynamic VIC)" "" +rconfig integer opt_run namelist,noah_mp 1 3 h "opt_run" "runoff and groundwater (1->SIMGM; 2->SIMTOP; 3->Schaake96; 4->BATS; 5->Miguez-Macho & Fan; 6->VIC; 7->Xinanjiang; 8->Dynamic VIC)" "" rconfig integer opt_sfc namelist,noah_mp 1 1 h "opt_sfc" "surface layer drag coeff (CH & CM) (1->M-O; 2->Chen97)" "" rconfig integer opt_frz namelist,noah_mp 1 1 h "opt_frz" "supercooled liquid water (1-> NY06; 2->Koren99)" "" rconfig integer opt_inf namelist,noah_mp 1 1 h "opt_inf" "frozen soil permeability (1-> NY06; 2->Koren99)" ""