Support for automatically linting Dockerfiles via hadolint

[tzabbi]

The current version of this extension does not support lining the Dockerfiles, which is to my mind very useful. In my opinion, an integration of hadolint would be a really nice feature for this extension.

EDIT: If the maintainer accepts this feature request, I can also provide an implementation for it.

[notpeter]

That looks nifty. Currently Zed only supports diagnostics via LSP. If they added support for that it could be easily integrated.

[tzabbi]

Do you know if there is any plan to support linter without lsp in zed?

[notpeter]

Not in the nearterm, no. The issue is that every linter provides slightly different ways of highlighting / show the areas of the impacted text. So basically it requires writing a custom parser/regexes and a way to associate diagnostics with chunks of code. And this is unique for each linting tool. In many ways this is comparable to the work of creating an lsp wrapper around the linter. For example, that's what bash-language-server does around shellcheck

As an alternative you can invoke hadolint as a zed task with the ZED_RELATIVE_FILE variable and it'll show you any output from hadolint. You can even assign a keybind if desired.

I filed an issue upstream:

• LSP mode: hadolint-language-server hadolint/hadolint#1094

[tzabbi]

Alright, thank you very much for the good explanation. Really appreciate it!

[notpeter]

If we supported arbitrary linting tools via tasks, it would like be leveraging something like this:

• Add problemMatcher support to tasks zed-industries/zed#18952